Re: [PR] CKS Enhancements docs [cloudstack-documentation]

2025-05-27 Thread via GitHub
kiranchavala commented on PR #458: URL: https://github.com/apache/cloudstack-documentation/pull/458#issuecomment-2915026817 > @nvazquez Should we add some images for: > > * Custom template registration - where `for CKS` is highlighted > > * CNI Configuration >

Re: [I] Secondary storage list/update/delete API endpoints [cloudstack-go]

2025-05-27 Thread via GitHub
catalinpan commented on issue #110: URL: https://github.com/apache/cloudstack-go/issues/110#issuecomment-2913838191 Thanks @DaanHoogland ! It looks like functionality is part of the `ImageStoreService.go` as you've mentioned, I'll use that one. -- This is an automated message from the Ap

Re: [I] Secondary storage list/update/delete API endpoints [cloudstack-go]

2025-05-27 Thread via GitHub
catalinpan closed issue #110: Secondary storage list/update/delete API endpoints URL: https://github.com/apache/cloudstack-go/issues/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: Where should I base my changes off of?

2025-05-27 Thread João Jandre Paraquetti
Jason, From a cursory glance, your change adds an optional new parameter to an existing API. It seems like an enhancement to the existing feature. Best regards, João Jandre On 5/27/25 16:39, Jason Hollis wrote: João, Thanks for the information, however I'm still not sure how things are cla

Re: Where should I base my changes off of?

2025-05-27 Thread Jason Hollis
João, Thanks for the information, however I'm still not sure how things are classified as enhancement vs new feature. I would assume this would be an enhancement of the `update loadbalancerrule` , because it's adding a new parameter to specify the source cidr. I just thougth I'd make sure before

Where should I base my changes off of?

2025-05-27 Thread Jason Hollis
I have some code for Cloudstack that I have tested and works on 4.19.2.0 instance that I have. I would like to submit this for review and get it merged in, but not sure which branch/tag I should/should've used to do this Here is the code and I had tested by basing it off of the 4.19 branch https:

Re: Where should I base my changes off of?

2025-05-27 Thread João Jandre Paraquetti
Hi Jason, If it is a bug/enchancement, I advise you to submit it to the oldest LTS branch that is affected by the bug (or that is compatible with the enhancement). You can check the LTS list here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS If it is a new feature you should su

[VOTE] Apache CloudStack 4.20.1.0 (RC2)

2025-05-27 Thread Pearl Dsilva
Hi All, I've created a 4.20.1.0 release (RC2), with the following artifacts up for a vote: Git Branch and Commit SH: https://github.com/apache/cloudstack/tree/4.20.1.0-RC20250527T2349 Commit: ff492442005bf06eeb2c9cecea1d95bff2235cc5 Source release (checksums and signatures are available at the s

Re: [VOTE] Apache CloudStack 4.20.1.0

2025-05-27 Thread Pearl Dsilva
Hi All, I’ll be closing this vote due to an issue with the build. I’ll address the problem and create a new RC shortly. Thanks, Pearl On Tue, May 27, 2025 at 8:50 PM Pearl Dsilva wrote: > Hi All, > > I've created a 4.20.1.0 release, with the following artifacts up for a > vote: > > Git Branch

[VOTE] Apache CloudStack 4.20.1.0

2025-05-27 Thread Pearl Dsilva
Hi All, I've created a 4.20.1.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://github.com/apache/cloudstack/tree/4.20.1.0-RC20250527T2039 Commit: 354c86b34285a261ea0e350e59bdb2e58a6685fe Source release (checksums and signatures are available at the same lo

Re: [Discussion] Versioning

2025-05-27 Thread Nicolas Vazquez
Hi all, Sorry for the delay, took time to digest all that has been discussed on the thread. I’ll try to summarize the discussion points raised by Joao for simplicity, please correct me if there are some misunderstandings from my side: * On breaking changes: * Allow bigger refactorin

[VOTE] Apache Cloudstack 4.19.3.0

2025-05-27 Thread Daan Hoogland
Hi All, I've created a 4.19.3.0 release, with the following artifacts up for a vote: Git Branch and Commit SH: https://github.com/apache/cloudstack/tree/4.19.3.0-RC20250527T1642 Commit: b00400d5fa8ad2b08a85139ae32f443adfb793a1 Source release (checksums and signatures are available at the same lo

[PR] [WIP] Release notes for 4.20.1 [cloudstack-documentation]

2025-05-27 Thread via GitHub
Pearl1594 opened a new pull request, #509: URL: https://github.com/apache/cloudstack-documentation/pull/509 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Xen-like limitations for ISO use [cloudstack-documentation]

2025-05-27 Thread via GitHub
DaanHoogland opened a new pull request, #508: URL: https://github.com/apache/cloudstack-documentation/pull/508 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] 4.19 release notes [cloudstack-documentation]

2025-05-27 Thread via GitHub
DaanHoogland commented on code in PR #508: URL: https://github.com/apache/cloudstack-documentation/pull/508#discussion_r2108880385 ## source/releasenotes/about.rst: ## @@ -71,6 +77,31 @@ https://docs.cloudstack.apache.org/en/4.19.0.0/releasenotes/changes.html .. _guestosids

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-05-27 Thread via GitHub
vishesh92 commented on PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#issuecomment-2912049804 @kevin-lii Can you reabase your PR against the latest main branch. I added a github action (https://github.com/apache/cloudstack-go/pull/111) which will help in testing this PR.

Re: [PR] Modify State Changing Requests to Utilize POST Request [cloudstack-go]

2025-05-27 Thread via GitHub
DaanHoogland commented on PR #107: URL: https://github.com/apache/cloudstack-go/pull/107#issuecomment-2912048663 @kevin-lii , can you rebase on latest to have the post requests tested against a simulator running in a container, please? (see #111 ) -- This is an automated message from the

Re: [PR] Add github actions for verifying different type input params with go sdk [cloudstack-go]

2025-05-27 Thread via GitHub
DaanHoogland merged PR #111: URL: https://github.com/apache/cloudstack-go/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloud

Re: [PR] Add github actions for verifying different type input params with go sdk [cloudstack-go]

2025-05-27 Thread via GitHub
DaanHoogland commented on PR #111: URL: https://github.com/apache/cloudstack-go/pull/111#issuecomment-2911903601 concept looks good as long as run-time can be acceptably short ;) (and it passes) -- This is an automated message from the Apache Git Service. To respond to the message, please