[PR] system vm destroy behaviour [cloudstack-documentation]

2024-07-23 Thread via GitHub
rajujith opened a new pull request, #416: URL: https://github.com/apache/cloudstack-documentation/pull/416 Adding a note on how system vm expunging is handled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] update listApis.json and update Quota API [cloudstack-go]

2024-07-23 Thread via GitHub
tonymmm1 commented on PR #90: URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246743626 Fixed the double/float type generation. ```Running Suite: Encoding Suite - /home/user1/git/cloudstack-go/test ==

Re: [PR] update listApis.json and update Quota API [cloudstack-go]

2024-07-23 Thread via GitHub
tonymmm1 commented on PR #90: URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246736045 seems to be an issue with generator.go on double types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] update listApis.json and update Quota API [cloudstack-go]

2024-07-23 Thread via GitHub
tonymmm1 commented on PR #90: URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246719750 ```user@linux make mocks user1@s1-desktopt1 go test -v ./... # github.com/apache/cloudstack-go/v2/cloudstack cloudstack/QuotaService.go:235:5: v declared and not used cloudst

Re: [PR] work on expanding Quota api [cloudstack-go]

2024-07-23 Thread via GitHub
tonymmm1 commented on PR #90: URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246696439 quotaUpdate that was generated has additional response fields in the struct when the documentation states it should only show "updated_on". ``` type QuotaUpdateResponse struct

Re: [PR] work on expanding Quota api [cloudstack-go]

2024-07-23 Thread via GitHub
tonymmm1 commented on PR #90: URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2246638950 I noticed that the listApis.json was missing the api functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-23 Thread via GitHub
nvazquez commented on code in PR #69: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1688116891 ## cloudstack_loadbalancer.go: ## @@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId string, publicPort int, pr re