[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #57: Fix RoleService bug where response doesn't match struct

2023-04-14 Thread via GitHub
rohityadavcloud commented on PR #57: URL: https://github.com/apache/cloudstack-go/pull/57#issuecomment-1509062985 Agree, the changes should ideally be fixed in generator otherwise they maybe reverted the next time we update the code base against new listApis. -- This is an automated mess

[GitHub] [cloudstack-go] mlsorensen commented on pull request #57: Fix RoleService bug where response doesn't match struct

2023-04-14 Thread via GitHub
mlsorensen commented on PR #57: URL: https://github.com/apache/cloudstack-go/pull/57#issuecomment-1509042199 We will need to fix it in the code gen. I think this is another manifestation of #55 - anything that doesn't return a list type response seems to be broken. We will need to come up

[GitHub] [cloudstack-go] hasan07 opened a new pull request, #57: Fix RoleService bug where response doesn't match struct

2023-04-14 Thread via GitHub
hasan07 opened a new pull request, #57: URL: https://github.com/apache/cloudstack-go/pull/57 Example raw response: ``` {"role":{"type":"DomainAdmin","id":"fake-id-12312312","name":"test-name","description":"test Role"}} ``` Struct doesn't match raw response, so the u

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #310: describe source NAT fields

2023-04-14 Thread via GitHub
blueorangutan commented on PR #310: URL: https://github.com/apache/cloudstack-documentation/pull/310#issuecomment-1508881524 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/310. (QA-JID 71) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #310: describe source NAT fields

2023-04-14 Thread via GitHub
blueorangutan commented on PR #310: URL: https://github.com/apache/cloudstack-documentation/pull/310#issuecomment-1508879409 @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Ser

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #310: describe source NAT fields

2023-04-14 Thread via GitHub
DaanHoogland commented on PR #310: URL: https://github.com/apache/cloudstack-documentation/pull/310#issuecomment-1508875084 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-documentation] DaanHoogland opened a new pull request, #310: describe source NAT fields

2023-04-14 Thread via GitHub
DaanHoogland opened a new pull request, #310: URL: https://github.com/apache/cloudstack-documentation/pull/310 to go with [cloudastack#6442](https://github.com/apache/cloudstack/pull/6442) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-kubernetes-provider] dependabot[bot] opened a new pull request, #45: Bump github.com/emicklei/go-restful from 2.9.5+incompatible to 2.16.0+incompatible

2023-04-14 Thread via GitHub
dependabot[bot] opened a new pull request, #45: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/45 Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible. Changelog Sourced from https://githu

[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud merged pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19

2023-04-14 Thread via GitHub
rohityadavcloud merged PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev

[GitHub] [cloudstack-kubernetes-provider] rohityadavcloud commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19

2023-04-14 Thread via GitHub
rohityadavcloud commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1508288264 Thanks @RolphH @hrak I'll merge this based on your tests and feedback. Pl do followup with other changes you think we need for the codebase. -- This is an au

[GitHub] [cloudstack-kubernetes-provider] hrak commented on pull request #44: Update to Kubernetes 1.24.12 + Use Go 1.19

2023-04-14 Thread via GitHub
hrak commented on PR #44: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/44#issuecomment-1508127314 > We are running this without any issues so far on Cloudstack 4.17. We have some more changes in the pipeline once this is merged. Well, maybe i should clarify: The

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #309: vmware8: update compatibility matrix

2023-04-14 Thread via GitHub
blueorangutan commented on PR #309: URL: https://github.com/apache/cloudstack-documentation/pull/309#issuecomment-1508119741 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/309. (QA-JID 70) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #309: vmware8: update compatibility matrix

2023-04-14 Thread via GitHub
blueorangutan commented on PR #309: URL: https://github.com/apache/cloudstack-documentation/pull/309#issuecomment-1508118612 @weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Se

[GitHub] [cloudstack-documentation] weizhouapache commented on pull request #309: vmware8: update compatibility matrix

2023-04-14 Thread via GitHub
weizhouapache commented on PR #309: URL: https://github.com/apache/cloudstack-documentation/pull/309#issuecomment-1508117481 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack-documentation] weizhouapache opened a new pull request, #309: vmware8: update compatibility matrix

2023-04-14 Thread via GitHub
weizhouapache opened a new pull request, #309: URL: https://github.com/apache/cloudstack-documentation/pull/309 this is the doc PR for https://github.com/apache/cloudstack/pull/7380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git