[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #34: Add instance data source

2022-06-10 Thread GitBox
Damans227 commented on code in PR #34: URL: https://github.com/apache/cloudstack-terraform-provider/pull/34#discussion_r894961017 ## cloudstack/data_source_cloudstack_instance_test.go: ## @@ -22,45 +22,43 @@ package cloudstack import ( "testing" - "github.com/a

[GitHub] [cloudstack-terraform-provider] davidjumani commented on pull request #36: Adding support for Kubernetes ISOs

2022-06-10 Thread GitBox
davidjumani commented on PR #36: URL: https://github.com/apache/cloudstack-terraform-provider/pull/36#issuecomment-1152147506 Requires https://github.com/apache/cloudstack-go/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [cloudstack-terraform-provider] davidjumani opened a new pull request, #36: Adding support for Kubernetes ISOs

2022-06-10 Thread GitBox
davidjumani opened a new pull request, #36: URL: https://github.com/apache/cloudstack-terraform-provider/pull/36 Adding support for Kubernetes ISOs Contains the following actions : - Create - Update (enable / disable) - Delete -- This is an automated message from the Apache

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala merged pull request #35: Adding support for Kubernetes Clusters

2022-06-10 Thread GitBox
harikrishna-patnala merged PR #35: URL: https://github.com/apache/cloudstack-terraform-provider/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack-terraform-provider] harikrishna-patnala closed issue #13: Add kubernetes service related resources to terraform

2022-06-10 Thread GitBox
harikrishna-patnala closed issue #13: Add kubernetes service related resources to terraform URL: https://github.com/apache/cloudstack-terraform-provider/issues/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-go] Pearl1594 commented on pull request #38: Add ACS 4.17 support

2022-06-10 Thread GitBox
Pearl1594 commented on PR #38: URL: https://github.com/apache/cloudstack-go/pull/38#issuecomment-1152110573 Yes, was going to spend some time on that, hence was marked as a draft PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack-go] davidjumani commented on pull request #38: Add ACS 4.17 support

2022-06-10 Thread GitBox
davidjumani commented on PR #38: URL: https://github.com/apache/cloudstack-go/pull/38#issuecomment-1152094223 @Pearl1594 You may wanna test / update the testdata to ensure that it hasn't changed in 4.17 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [cloudstack-go] davidjumani opened a new pull request, #39: Update test parsing to ensure ID is present

2022-06-10 Thread GitBox
davidjumani opened a new pull request, #39: URL: https://github.com/apache/cloudstack-go/pull/39 Ensures that the ID field is not blank when parsing a response in the unit tests ``` go test ./... ok github.com/apache/cloudstack-go/v2/test 0.037s ``` -- This is an auto