[GitHub] [cloudstack-documentation] abdelouahabb commented on a change in pull request #189: Update kvm.rst

2021-05-24 Thread GitBox
abdelouahabb commented on a change in pull request #189: URL: https://github.com/apache/cloudstack-documentation/pull/189#discussion_r638373138 ## File path: source/installguide/hypervisor/kvm.rst ## @@ -613,7 +613,7 @@ Modify the interfaces file to look like this: auto cl

[GitHub] [cloudstack-documentation] Hudratronium edited a comment on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0

2021-05-24 Thread GitBox
Hudratronium edited a comment on pull request #192: URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-847138265 > > > @Hudratronium that's no true, you need to mask the services to get old behaviour. We've fixed that in cloudstack-agent I think, @shwstpp

[GitHub] [cloudstack-documentation] Hudratronium commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0

2021-05-24 Thread GitBox
Hudratronium commented on pull request #192: URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-847138265 > > > @Hudratronium that's no true, you need to mask the services to get old behaviour. We've fixed that in cloudstack-agent I think, @shwstppr @davi

[GitHub] [cloudstack-documentation] GabrielBrascher commented on pull request #155: Inclusivity changes for CloudStack in the documentation - Rename default git branch name from 'master' to 'main' an

2021-05-24 Thread GitBox
GabrielBrascher commented on pull request #155: URL: https://github.com/apache/cloudstack-documentation/pull/155#issuecomment-847036493 THanks for the PR @DaanHoogland, I have seen some projects changing from `white-list` & `black-list` to `welcome-list` & `block-list`. I have no

Re: [RESULT][VOTE] Renaming default git branch name from 'master' to 'main' and replace offensive words as appropriate for inclusiveness

2021-05-24 Thread Rich Bowen
On 2021/05/24 09:13:45, Andrija Panic wrote: > (it's interesting to see that " sanity check " (a very common, > non-offensive wording used in coding) is considered inappropriate (by > whatever authority...???) I don't think that "inappropriate" is really the point here. Rather, the goal is t

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #155: Inclusivity changes for CloudStack in the documentation - Rename default git branch name from 'master' to 'main' and replace

2021-05-24 Thread GitBox
rhtyd commented on pull request #155: URL: https://github.com/apache/cloudstack-documentation/pull/155#issuecomment-847016246 @sureshanaparti pl address build conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #212: mysql update warnings

2021-05-24 Thread GitBox
andrijapanicsb commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-847002466 @rhtyd this is still very confusing - can you please review my proposal above ^^^ -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack-documentation] rhtyd merged pull request #199: ui: added customization details

2021-05-24 Thread GitBox
rhtyd merged pull request #199: URL: https://github.com/apache/cloudstack-documentation/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #199: ui: added customization details

2021-05-24 Thread GitBox
rhtyd commented on pull request #199: URL: https://github.com/apache/cloudstack-documentation/pull/199#issuecomment-846958590 Nevermind my last comment - let's merge this - it's better for users to see the whole list. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #212: mysql update warnings

2021-05-24 Thread GitBox
rhtyd commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-846951811 @DaanHoogland can you rebase against 4.15 branch? Changes are more specific now, LGTM. Let's also wait for other reviewers to give them lgtm. -- This is a

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #211: Update docs

2021-05-24 Thread GitBox
rhtyd commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-846950954 @davidjumani pl address merge conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [cloudstack-documentation] rhtyd merged pull request #205: VMware vSphere datastore cluster synchronisation

2021-05-24 Thread GitBox
rhtyd merged pull request #205: URL: https://github.com/apache/cloudstack-documentation/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd merged pull request #204: Remove IRC reference as it is no longer used

2021-05-24 Thread GitBox
rhtyd merged pull request #204: URL: https://github.com/apache/cloudstack-documentation/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd merged pull request #202: Reminder for adding package repository

2021-05-24 Thread GitBox
rhtyd merged pull request #202: URL: https://github.com/apache/cloudstack-documentation/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd merged pull request #201: Added remarks for clearifcation / addes commands for ubuntu installation

2021-05-24 Thread GitBox
rhtyd merged pull request #201: URL: https://github.com/apache/cloudstack-documentation/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd merged pull request #200: Updated list of provisioned packages

2021-05-24 Thread GitBox
rhtyd merged pull request #200: URL: https://github.com/apache/cloudstack-documentation/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd closed pull request #197: Added information of deprecated feature "basic networking" for a zone

2021-05-24 Thread GitBox
rhtyd closed pull request #197: URL: https://github.com/apache/cloudstack-documentation/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd merged pull request #198: Added AMD output and vlan/vni range values

2021-05-24 Thread GitBox
rhtyd merged pull request #198: URL: https://github.com/apache/cloudstack-documentation/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #197: Added information of deprecated feature "basic networking" for a zone

2021-05-24 Thread GitBox
rhtyd commented on pull request #197: URL: https://github.com/apache/cloudstack-documentation/pull/197#issuecomment-846949863 Hi @Hudratronium closing this, UI support basic zone creation now. The fix will be in the future 4.15.1+ releases, until then you may use the legacy UI with 4.15 f

[GitHub] [cloudstack-documentation] rhtyd merged pull request #196: Changes for synchronize structure of setup wizard in GUI with installation guide

2021-05-24 Thread GitBox
rhtyd merged pull request #196: URL: https://github.com/apache/cloudstack-documentation/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #199: ui: added customization details

2021-05-24 Thread GitBox
sureshanaparti commented on a change in pull request #199: URL: https://github.com/apache/cloudstack-documentation/pull/199#discussion_r637849029 ## File path: source/adminguide/ui.rst ## @@ -273,8 +285,177 @@ Some assorted primary theme colours: - Green: #52C41A - Purple: #

[GitHub] [cloudstack-documentation] rhtyd merged pull request #195: Update _pkg_repo.rst

2021-05-24 Thread GitBox
rhtyd merged pull request #195: URL: https://github.com/apache/cloudstack-documentation/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd merged pull request #194: clearification of the advanced network setup in section "Host KVM installation"

2021-05-24 Thread GitBox
rhtyd merged pull request #194: URL: https://github.com/apache/cloudstack-documentation/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0

2021-05-24 Thread GitBox
rhtyd commented on pull request #192: URL: https://github.com/apache/cloudstack-documentation/pull/192#issuecomment-846947792 @Hudratronium that's no true, you need to mask the services to get old behaviour. We've fixed that in cloudstack-agent I think, @shwstppr @davidjumani - can you co

[GitHub] [cloudstack-documentation] rhtyd merged pull request #190: add ufw bridged connection issue solution

2021-05-24 Thread GitBox
rhtyd merged pull request #190: URL: https://github.com/apache/cloudstack-documentation/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd commented on a change in pull request #189: Update kvm.rst

2021-05-24 Thread GitBox
rhtyd commented on a change in pull request #189: URL: https://github.com/apache/cloudstack-documentation/pull/189#discussion_r637846419 ## File path: source/installguide/hypervisor/kvm.rst ## @@ -613,7 +613,7 @@ Modify the interfaces file to look like this: auto cloudbr0

[GitHub] [cloudstack-documentation] rhtyd merged pull request #172: Update user-data.rst

2021-05-24 Thread GitBox
rhtyd merged pull request #172: URL: https://github.com/apache/cloudstack-documentation/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd merged pull request #169: Updated docs with the new storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

2021-05-24 Thread GitBox
rhtyd merged pull request #169: URL: https://github.com/apache/cloudstack-documentation/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #169: Updated docs with the new storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

2021-05-24 Thread GitBox
rhtyd commented on pull request #169: URL: https://github.com/apache/cloudstack-documentation/pull/169#issuecomment-846945140 The dev/code PR was merged, merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #155: Inclusivity changes for CloudStack in the documentation - Rename default git branch name from 'master' to 'main' and

2021-05-24 Thread GitBox
blueorangutan commented on pull request #155: URL: https://github.com/apache/cloudstack-documentation/pull/155#issuecomment-846944971 @rhtyd a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #157: Virtual Router Service Offering

2021-05-24 Thread GitBox
rhtyd commented on pull request #157: URL: https://github.com/apache/cloudstack-documentation/pull/157#issuecomment-846944688 ping @ustcweizhou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #155: Inclusivity changes for CloudStack in the documentation - Rename default git branch name from 'master' to 'main' and replace

2021-05-24 Thread GitBox
rhtyd commented on pull request #155: URL: https://github.com/apache/cloudstack-documentation/pull/155#issuecomment-846944515 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #140: [WIP] Update xenserver.rst

2021-05-24 Thread GitBox
rhtyd commented on pull request #140: URL: https://github.com/apache/cloudstack-documentation/pull/140#issuecomment-846944358 cc @Spaceman1984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #60: Volumes metrics doc update

2021-05-24 Thread GitBox
rhtyd commented on pull request #60: URL: https://github.com/apache/cloudstack-documentation/pull/60#issuecomment-846944295 cc @Spaceman1984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack-documentation] rhtyd commented on a change in pull request #199: ui: added customization details

2021-05-24 Thread GitBox
rhtyd commented on a change in pull request #199: URL: https://github.com/apache/cloudstack-documentation/pull/199#discussion_r637843143 ## File path: source/adminguide/ui.rst ## @@ -273,8 +285,177 @@ Some assorted primary theme colours: - Green: #52C41A - Purple: #722ED1

Re: [RESULT][VOTE] Renaming default git branch name from 'master' to 'main' and replace offensive words as appropriate for inclusiveness

2021-05-24 Thread Andrija Panic
All good Rohit, I get that, inside the code in particular, it should usually always be "it", simply due to grammar. I'm waiting for the moment where using "monkey" words and other animals would be found inappropriate to be used with software (like i.e. cloudmonkey and many others) due to someone f

Re: [RESULT][VOTE] Renaming default git branch name from 'master' to 'main' and replace offensive words as appropriate for inclusiveness

2021-05-24 Thread Rohit Yadav
Andrija, I think the point in particular with "he/she" is for projects to consider updating their code/docs with gender-neutral terms. Regards. From: Andrija Panic Sent: Monday, May 24, 2021 14:43 To: dev Cc: priv...@cloudstack.apache.org Subject: Re: [RESUL

Re: [RESULT][VOTE] Renaming default git branch name from 'master' to 'main' and replace offensive words as appropriate for inclusiveness

2021-05-24 Thread Andrija Panic
(it's interesting to see that " sanity check " (a very common, non-offensive wording used in coding) is considered inappropriate (by whatever authority...???) ( also "he/she" is considered "gender" and that also seems inappropriate? - I can't believe this nonsense (otherwise, it may be grammati