[GitHub] [cloudstack-primate] rhtyd commented on pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
rhtyd commented on pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#issuecomment-737715600 Thanks for the update @davidjumani This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack-primate] davidjumani commented on pull request #885: createnetworkform: Displaying api errors

2020-12-02 Thread GitBox
davidjumani commented on pull request #885: URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737714797 @rhtyd It copies the behaviour of the old UI even for regular users ![Screenshot from 2020-12-03 12-42-37](https://user-images.githubusercontent.com/8244774/

[GitHub] [cloudstack-primate] davidjumani commented on pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
davidjumani commented on pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#issuecomment-737712136 @rhtyd Requested changes from @Pearl1594 so that the form is not closed in case of an error so the user can try again without reentering the data all over again

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #835: [FEATURE] server: update template to another template type

2020-12-02 Thread GitBox
rhtyd edited a comment on issue #835: URL: https://github.com/apache/cloudstack-primate/issues/835#issuecomment-737704937 We merged the UI PR yesterday based on David and Gabriels' review, as the backend PR was already merged in Oct. @PaulAngus to revert both frontend/backend PRs/commi

[GitHub] [cloudstack-primate] rhtyd commented on issue #882: [BUG] When editing physical network traffic labels - existing labels are not shown

2020-12-02 Thread GitBox
rhtyd commented on issue #882: URL: https://github.com/apache/cloudstack-primate/issues/882#issuecomment-737708343 @andrijapanicsb please test and close against latest This is an automated message from the Apache Git Service

[GitHub] [cloudstack-primate] rhtyd closed issue #882: [BUG] When editing physical network traffic labels - existing labels are not shown

2020-12-02 Thread GitBox
rhtyd closed issue #882: URL: https://github.com/apache/cloudstack-primate/issues/882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
rhtyd merged pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
rhtyd commented on pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737708116 LGTM, tested few cases with different traffic types. Existing values seen populated in the update form: ![Screenshot from 2020-12-03 12-27-29](https://user-images.git

[GitHub] [cloudstack-primate] rhtyd commented on pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
rhtyd commented on pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#issuecomment-737706725 @davidjumani @Pearl1594 is this good to go? This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack-primate] rhtyd commented on pull request #885: createnetworkform: Displaying api errors

2020-12-02 Thread GitBox
rhtyd commented on pull request #885: URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737706151 Could this break previous behaviour @davidjumani, does old UI show any exception? Also is this shown only to admins? ---

[GitHub] [cloudstack-primate] rhtyd commented on issue #835: [FEATURE] server: update template to another template type

2020-12-02 Thread GitBox
rhtyd commented on issue #835: URL: https://github.com/apache/cloudstack-primate/issues/835#issuecomment-737704937 We merged the UI PR yesterday based on David and Gabriels' review, as the backend PR was already merged in Oct. @PaulAngus to revert both frontend/backend PRs/commits see

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #835: [FEATURE] server: update template to another template type

2020-12-02 Thread GitBox
davidjumani edited a comment on issue #835: URL: https://github.com/apache/cloudstack-primate/issues/835#issuecomment-737704136 @PaulAngus The backend commit went in October, the UI component was merged a couple of days ago. Should the UI addition be reverted? That would make the feature

[GitHub] [cloudstack-primate] davidjumani commented on issue #835: [FEATURE] server: update template to another template type

2020-12-02 Thread GitBox
davidjumani commented on issue #835: URL: https://github.com/apache/cloudstack-primate/issues/835#issuecomment-737704136 @PaulAngus The backend commit went in October, the UI component was merged a couple of days ago. Should the UI addition be reverted? That would make the feature unusabl

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
blueorangutan commented on pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737663870 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/884 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
blueorangutan commented on pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737661260 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
davidjumani commented on pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737661019 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

Re: Please unsubscribe me from this list

2020-12-02 Thread Andrew Wetmore
Hi, Sree: To unsubscribe send separate emails, with "unsubscribe" in the subject line, to users-unsubscribe@infra and dev-unsubscribe@cloudstack Andrew On Wed, Dec 2, 2020 at 10:48 AM Sree wrote: > Unsubscribe from dev@cloudstack.apache.org > and us...@infra.apache.org > -- Andrew Wetmore T

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
davidjumani commented on a change in pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534073614 ## File path: src/views/storage/TakeSnapshot.vue ## @@ -181,10 +181,9 @@ export default { catchMessage: this.$t('error.fetchin

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
davidjumani commented on a change in pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534073614 ## File path: src/views/storage/TakeSnapshot.vue ## @@ -181,10 +181,9 @@ export default { catchMessage: this.$t('error.fetchin

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
blueorangutan commented on pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#issuecomment-737149592 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/880 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
blueorangutan commented on pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#issuecomment-737143807 @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
Pearl1594 commented on pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#issuecomment-737143241 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
Pearl1594 commented on a change in pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534062127 ## File path: src/views/storage/TakeSnapshot.vue ## @@ -181,10 +181,9 @@ export default { catchMessage: this.$t('error.fetching.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #885: createnetworkform: Displaying api errors

2020-12-02 Thread GitBox
blueorangutan commented on pull request #885: URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737129251 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/885 (JID-3

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
davidjumani commented on a change in pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r534038067 ## File path: src/views/infra/network/EditTrafficLabel.vue ## @@ -0,0 +1,235 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
davidjumani commented on a change in pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r534038067 ## File path: src/views/infra/network/EditTrafficLabel.vue ## @@ -0,0 +1,235 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #885: createnetworkform: Displaying api errors

2020-12-02 Thread GitBox
blueorangutan commented on pull request #885: URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737122601 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #885: createnetworkform: Displaying api errors

2020-12-02 Thread GitBox
davidjumani commented on pull request #885: URL: https://github.com/apache/cloudstack-primate/pull/885#issuecomment-737121831 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
davidjumani commented on a change in pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534028919 ## File path: src/views/storage/TakeSnapshot.vue ## @@ -181,10 +181,9 @@ export default { catchMessage: this.$t('error.fetchin

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #880: Close snapshot form in case of an error

2020-12-02 Thread GitBox
davidjumani commented on a change in pull request #880: URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534028919 ## File path: src/views/storage/TakeSnapshot.vue ## @@ -181,10 +181,9 @@ export default { catchMessage: this.$t('error.fetchin

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
blueorangutan commented on pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737115428 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/884 (JID-3

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #885: createnetworkform: Displaying api errors

2020-12-02 Thread GitBox
davidjumani opened a new pull request #885: URL: https://github.com/apache/cloudstack-primate/pull/885 Shows errors while fetching network offerings. Especially noticeable when there are multiple guest physical networks in a zone but are untagged. Makes life easier for the user so he kno

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
blueorangutan commented on pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737110276 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] utchoang commented on pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
utchoang commented on pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#issuecomment-737109759 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #884: FIX - Update physical network traffic labels

2020-12-02 Thread GitBox
davidjumani commented on a change in pull request #884: URL: https://github.com/apache/cloudstack-primate/pull/884#discussion_r534016321 ## File path: src/views/infra/network/EditTrafficLabel.vue ## @@ -0,0 +1,235 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [cloudstack-primate] PaulAngus commented on issue #835: [FEATURE] server: update template to another template type

2020-12-02 Thread GitBox
PaulAngus commented on issue #835: URL: https://github.com/apache/cloudstack-primate/issues/835#issuecomment-737104971 We were in a code freeze yesterday. please revert this commit This is an automated message from the Apac

Please unsubscribe me from this list

2020-12-02 Thread Sree
Unsubscribe from dev@cloudstack.apache.org and us...@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #883: phynetworks: Adding tags and zonename to list & detail view

2020-12-02 Thread GitBox
rhtyd merged pull request #883: URL: https://github.com/apache/cloudstack-primate/pull/883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd closed issue #881: [BUG] Physical Network tags not shown

2020-12-02 Thread GitBox
rhtyd closed issue #881: URL: https://github.com/apache/cloudstack-primate/issues/881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #878: createsharednetworkform: Fix for multiple physical networks

2020-12-02 Thread GitBox
rhtyd merged pull request #878: URL: https://github.com/apache/cloudstack-primate/pull/878 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd merged pull request #879: Fix showing esxi host label instead of vCentre host

2020-12-02 Thread GitBox
rhtyd merged pull request #879: URL: https://github.com/apache/cloudstack-primate/pull/879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd merged pull request #874: Add button to enable/disable storage pool

2020-12-02 Thread GitBox
rhtyd merged pull request #874: URL: https://github.com/apache/cloudstack-primate/pull/874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to