[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #711: FIX - Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
davidjumani commented on a change in pull request #711: URL: https://github.com/apache/cloudstack-primate/pull/711#discussion_r488405615 ## File path: src/views/network/IpAddressesTab.vue ## @@ -272,7 +272,7 @@ export default { errorMethod: () => { this.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #711: FIX - Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
blueorangutan commented on pull request #711: URL: https://github.com/apache/cloudstack-primate/pull/711#issuecomment-692459971 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/711 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #711: FIX - Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
blueorangutan commented on pull request #711: URL: https://github.com/apache/cloudstack-primate/pull/711#issuecomment-692456680 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #711: FIX - Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
davidjumani commented on pull request #711: URL: https://github.com/apache/cloudstack-primate/pull/711#issuecomment-692456421 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] utchoang opened a new pull request #711: FIX - Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
utchoang opened a new pull request #711: URL: https://github.com/apache/cloudstack-primate/pull/711 @rhtyd cc @svenvogel Fixes #708 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack-primate] nvazquez opened a new pull request #710: vApps fix: use deployasisdetails instead of details

2020-09-14 Thread GitBox
nvazquez opened a new pull request #710: URL: https://github.com/apache/cloudstack-primate/pull/710 As per PR https://github.com/apache/cloudstack/pull/4307: - deploy-as-is templates details are retrieved by a new parameter instead of template details - details name refactor ---

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #703: [BUG] "VPN uses" missing from the network-related main menu

2020-09-14 Thread GitBox
andrijapanicsb commented on issue #703: URL: https://github.com/apache/cloudstack-primate/issues/703#issuecomment-692151069 Alright - so we need a fix for this - to show only when there is > 0 VPNs enabled for the given account... -

[GitHub] [cloudstack-primate] ravening commented on issue #703: [BUG] "VPN uses" missing from the network-related main menu

2020-09-14 Thread GitBox
ravening commented on issue #703: URL: https://github.com/apache/cloudstack-primate/issues/703#issuecomment-692125616 @andrijapanicsb I was able to add vpn user only if there are existing remote access vpn connection. In the old ui, we first check the count of remote access vpn. If its

Re: Question about documentation

2020-09-14 Thread Slavka Peleva
Hi David, Thanks for the quick response! I will check the links that you provided. Best regards, Slavka P. On Mon, Sep 14, 2020 at 3:51 PM David Jumani wrote: > Hi Slavka, > > You can have a look at the documentation here and add the docs of your > feature (where you think it's appropriate) >

Re: Question about documentation

2020-09-14 Thread David Jumani
Hi Slavka, You can have a look at the documentation here and add the docs of your feature (where you think it's appropriate) http://docs.cloudstack.apache.org/en/latest/adminguide/storage.html?highlight=snapshot#working-with-volume-snapshots You can edit the docs and send a PR https://github.com

Question about documentation

2020-09-14 Thread Slavka Peleva
Hi all, We have a pull request #3724 for which Andrija Panic requested documentation. I couldn't find any guide or requirements on how to structure documents with new features. Could you please help with this -

[GitHub] [cloudstack-primate] rhtyd commented on issue #689: [BUG] Buttons not clickable while error popup present

2020-09-14 Thread GitBox
rhtyd commented on issue #689: URL: https://github.com/apache/cloudstack-primate/issues/689#issuecomment-691991391 @andrijapanicsb Well you can click on the cross to close the error box? This is an automated message from the

[GitHub] [cloudstack-primate] rhtyd closed issue #705: [BUG] listing 500 events per page breaks page

2020-09-14 Thread GitBox
rhtyd closed issue #705: URL: https://github.com/apache/cloudstack-primate/issues/705 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #708: [BUG] PROPOSAL: Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
rhtyd commented on issue #708: URL: https://github.com/apache/cloudstack-primate/issues/708#issuecomment-691990788 The max limit 500 was used as that's why is documented for most APIs (the max. limit of page size to be 500). But I see no harm in using 200 as max page size for UI. @utch

[GitHub] [cloudstack-primate] rhtyd commented on issue #705: [BUG] listing 500 events per page breaks page

2020-09-14 Thread GitBox
rhtyd commented on issue #705: URL: https://github.com/apache/cloudstack-primate/issues/705#issuecomment-691991088 Closing on your remark @andrijapanicsb and the other issue, we can limit max. page size to 200 which is a fairly large number ---

[GitHub] [cloudstack-primate] rhtyd merged pull request #709: Fix small typo in message

2020-09-14 Thread GitBox
rhtyd merged pull request #709: URL: https://github.com/apache/cloudstack-primate/pull/709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] ravening opened a new pull request #709: Fix small typo in message

2020-09-14 Thread GitBox
ravening opened a new pull request #709: URL: https://github.com/apache/cloudstack-primate/pull/709 Remove extra `}` from the popup message This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-14 Thread GitBox
andrijapanicsb commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-691976530 that is correct only for StaticNAT @ravening - needs to be fixed also for PF or LB - I'm not sure if @davidjumani is already on it or not? -

[GitHub] [cloudstack-primate] ravening commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-14 Thread GitBox
ravening commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-691975730 @andrijapanicsb I dont see any port forwarding or loadbalancer tab is static nat is enabled ![Screenshot 2020-09-14 at 12 50 05](https://user-images.githubuserconte

[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #152: [WIP] Update to java 11

2020-09-14 Thread GitBox
ACSGitBot commented on pull request #152: URL: https://github.com/apache/cloudstack-documentation/pull/152#issuecomment-691942243 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr152 Build Log Output: No log errors found to report

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #152: [WIP] Update to java 11

2020-09-14 Thread GitBox
rhtyd commented on pull request #152: URL: https://github.com/apache/cloudstack-documentation/pull/152#issuecomment-691941042 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #152: [WIP] Update to java 11

2020-09-14 Thread GitBox
ACSGitBot commented on pull request #152: URL: https://github.com/apache/cloudstack-documentation/pull/152#issuecomment-691941139 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long.

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #151: cks: root disk controller and nic adapter for CoreOS VMware

2020-09-14 Thread GitBox
rhtyd commented on pull request #151: URL: https://github.com/apache/cloudstack-documentation/pull/151#issuecomment-691940722 cc @Pearl1594 @PaulAngus This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack-primate] utchoang edited a comment on issue #708: [BUG] PROPOSAL: Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
utchoang edited a comment on issue #708: URL: https://github.com/apache/cloudstack-primate/issues/708#issuecomment-691891042 @andrijapanicsb Agreed, I think 200 items per page is ok. @rhtyd @davidjumani Thoughts? This is

[GitHub] [cloudstack-primate] utchoang commented on issue #708: [BUG] PROPOSAL: Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
utchoang commented on issue #708: URL: https://github.com/apache/cloudstack-primate/issues/708#issuecomment-691891042 @andrijapanicsb Agree, I think 200 items per page is ok. @rhtyd @davidjumani Thoughts? This is an auto

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #708: [BUG] Reduce max pagination from 500/page to 200/page

2020-09-14 Thread GitBox
andrijapanicsb opened a new issue #708: URL: https://github.com/apache/cloudstack-primate/issues/708 - If you choose to list 500 records per page in i.e. Event, the machine with 6 CPU cores @ 4.0 Ghz becomes almost unusable (Firefox does complain that the page is slowing down the computer

[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #707: Fixing currentAction null while processing the response

2020-09-14 Thread GitBox
andrijapanicsb merged pull request #707: URL: https://github.com/apache/cloudstack-primate/pull/707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #707: Fixing currentAction null while processing the response

2020-09-14 Thread GitBox
andrijapanicsb commented on pull request #707: URL: https://github.com/apache/cloudstack-primate/pull/707#issuecomment-691874121 LGTM, tested the PR. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack-primate] andrijapanicsb closed issue #706: [BUG] minor: fix the weird "Deleted" / "Undefined" message

2020-09-14 Thread GitBox
andrijapanicsb closed issue #706: URL: https://github.com/apache/cloudstack-primate/issues/706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #706: [BUG] minor: fix the weird "Deleted" / "Undefined" message

2020-09-14 Thread GitBox
andrijapanicsb commented on issue #706: URL: https://github.com/apache/cloudstack-primate/issues/706#issuecomment-691873921 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-documentation] davidjumani opened a new pull request #152: [WIP] Update to java 11

2020-09-14 Thread GitBox
davidjumani opened a new pull request #152: URL: https://github.com/apache/cloudstack-documentation/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us