[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #142: Added basic and advanced customization sections to the primate doc

2020-07-09 Thread GitBox
ACSGitBot commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-656495096 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr142 Build Log Output: No log errors found to report

[GitHub] [cloudstack-documentation] Pearl1594 commented on pull request #142: Added basic and advanced customization sections to the primate doc

2020-07-09 Thread GitBox
Pearl1594 commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-656494344 requesting docbuild This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #142: Added basic and advanced customization sections to the primate doc

2020-07-09 Thread GitBox
ACSGitBot commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-656494371 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long.

[GitHub] [cloudstack-documentation] Pearl1594 opened a new pull request #142: Added basic and advanced customization sections to the primate doc

2020-07-09 Thread GitBox
Pearl1594 opened a new pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142 Added details : Basic customization: modifying themes, adding custom plugins Advanced customization: Adding new sections

[GitHub] [cloudstack-primate] utchoang commented on pull request #527: [WIP] Enable searching for templates/iso while vm deployment

2020-07-09 Thread GitBox
utchoang commented on pull request #527: URL: https://github.com/apache/cloudstack-primate/pull/527#issuecomment-656424066 @ravening @rhtyd I think we should fix it as follows: - Regarding fetch data or search template/isos, you should call API by tab instead of fetching all as currentl

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-09 Thread GitBox
blueorangutan commented on pull request #382: URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656251123 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/382 (JID-2

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #382: Enabling Role based Users in Projects

2020-07-09 Thread GitBox
blueorangutan commented on pull request #382: URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656246625 @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects

2020-07-09 Thread GitBox
Pearl1594 commented on pull request #382: URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656246028 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] ravening opened a new pull request #527: [WIP] Enable searching for templates/iso while vm deployment

2020-07-09 Thread GitBox
ravening opened a new pull request #527: URL: https://github.com/apache/cloudstack-primate/pull/527 Curertly we cant search for templates using api while deploying a vm. It searches for local cache and not from api server. Allow searching for templates from backend using filters

[GitHub] [cloudstack-primate] alamintech opened a new issue #526: [TESTPLAN] Full Test Plan for $Version for $Role, $Hypervisor, ACS $Version

2020-07-09 Thread GitBox
alamintech opened a new issue #526: URL: https://github.com/apache/cloudstack-primate/issues/526 Note: for User role test exclude after Account/User feature, for DomainAdmin role exclude after Infrastructure (except for Offerings) **Common** - [ ] Project selector - [ ] Languag

[GitHub] [cloudstack-primate] ravening commented on pull request #521: Adding search option to SettingsTab

2020-07-09 Thread GitBox
ravening commented on pull request #521: URL: https://github.com/apache/cloudstack-primate/pull/521#issuecomment-656061320 LGTM ![Screenshot 2020-07-09 at 13 01 27](https://user-images.githubusercontent.com/10645273/87032068-502c3480-c1e4-11ea-92fe-ccf0fb2188ec.png) --

[GitHub] [cloudstack-primate] ravening edited a comment on issue #520: [BUG] DeployVM Wizard does not properly search for templates

2020-07-09 Thread GitBox
ravening edited a comment on issue #520: URL: https://github.com/apache/cloudstack-primate/issues/520#issuecomment-656060475 @rhtyd @davidjumani I tried adding ``` @handle-search-filter="($event) => handleSearchFilter('templates', $event)" ``` under `

[GitHub] [cloudstack-primate] ravening commented on issue #520: [BUG] DeployVM Wizard does not properly search for templates

2020-07-09 Thread GitBox
ravening commented on issue #520: URL: https://github.com/apache/cloudstack-primate/issues/520#issuecomment-656060475 @rhtyd @davidjumani I tried adding ``` @handle-search-filter="($event) => handleSearchFilter('templates', $event)" ``` under `

[GitHub] [cloudstack-primate] ravening commented on pull request #524: offerings: Removing tags for offerings

2020-07-09 Thread GitBox
ravening commented on pull request #524: URL: https://github.com/apache/cloudstack-primate/pull/524#issuecomment-656056744 @davidjumani sometimes we do use tags for offerings to manage vm deployments and vm migrations depending on offering and host tags. So removing may not be a good idea

[GitHub] [cloudstack-primate] rhtyd merged pull request #525: Display URL for the template to admins

2020-07-09 Thread GitBox
rhtyd merged pull request #525: URL: https://github.com/apache/cloudstack-primate/pull/525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #525: Display URL for the template to admins

2020-07-09 Thread GitBox
rhtyd commented on pull request #525: URL: https://github.com/apache/cloudstack-primate/pull/525#issuecomment-656053715 Confirmed URL not seen is API does not return the key. Can merge as probably some CloudStack forks maybe returning the URL as part of list API response. ---

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #382: Enabling Role based Users in Projects

2020-07-09 Thread GitBox
Pearl1594 commented on pull request #382: URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656048886 @rhtyd it is ready, however, wrt to the view of multiple project Admins if the list project API changes, there may be a small change in the UI

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #525: Display URL for the template to admins

2020-07-09 Thread GitBox
blueorangutan commented on pull request #525: URL: https://github.com/apache/cloudstack-primate/pull/525#issuecomment-656047614 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/525 (JID-2

[GitHub] [cloudstack-primate] rhtyd commented on issue #520: [BUG] DeployVM Wizard does not properly search for templates

2020-07-09 Thread GitBox
rhtyd commented on issue #520: URL: https://github.com/apache/cloudstack-primate/issues/520#issuecomment-656044630 @utchoang can you have a look at this, we want: - The search to actually search the template/iso API - Render the results on their own specific tabs (i.e. filtered tabs o

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #525: Display URL for the template to admins

2020-07-09 Thread GitBox
blueorangutan commented on pull request #525: URL: https://github.com/apache/cloudstack-primate/pull/525#issuecomment-656043844 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects

2020-07-09 Thread GitBox
rhtyd commented on pull request #382: URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-656043912 @Pearl1594 is this ready again for review/testing? This is an automated message from the Apache Git Serv

[GitHub] [cloudstack-primate] rhtyd commented on pull request #521: Adding search option to SettingsTab

2020-07-09 Thread GitBox
rhtyd commented on pull request #521: URL: https://github.com/apache/cloudstack-primate/pull/521#issuecomment-656043627 LGTM did not test it though This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] rhtyd commented on pull request #525: Display URL for the template to admins

2020-07-09 Thread GitBox
rhtyd commented on pull request #525: URL: https://github.com/apache/cloudstack-primate/pull/525#issuecomment-656043055 The listTemplates response does not return URL, but we can still accept the change as if it does we can display it @blueorangutan package ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #524: offerings: Removing tags for offerings

2020-07-09 Thread GitBox
rhtyd commented on pull request #524: URL: https://github.com/apache/cloudstack-primate/pull/524#issuecomment-656042435 @davidjumani please check against old UI, while we may not support this in UI - the API supports the tags parameter

[GitHub] [cloudstack-primate] rhtyd merged pull request #522: dashboard: Adding state to redirect path of dashboard

2020-07-09 Thread GitBox
rhtyd merged pull request #522: URL: https://github.com/apache/cloudstack-primate/pull/522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #522: dashboard: Adding state to redirect path of dashboard

2020-07-09 Thread GitBox
rhtyd commented on pull request #522: URL: https://github.com/apache/cloudstack-primate/pull/522#issuecomment-656041567 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-primate] rhtyd commented on pull request #436: feature: template ovf properties

2020-07-09 Thread GitBox
rhtyd commented on pull request #436: URL: https://github.com/apache/cloudstack-primate/pull/436#issuecomment-656040657 Tested with backend, will do a final test by tomorrow and merge. This is an automated message from the A

[GitHub] [cloudstack-primate] ravening opened a new pull request #525: Display URL for the template to admins

2020-07-09 Thread GitBox
ravening opened a new pull request #525: URL: https://github.com/apache/cloudstack-primate/pull/525 In legacy UI, we display the url of the template to admins. Do the same thing here also Below is the view for admin ![Screenshot 2020-07-09 at 11 25 07](https://user-images.g