[GitHub] [cloudstack-primate] utchoang commented on issue #307: [FIX] VM Deployment Wizard Changes

2020-04-22 Thread GitBox
utchoang commented on issue #307: URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618208782 Hi @rhtyd I have some questions: 1. For adding new network, do you mean you want to make it similar to the first version? (add networking in a network section) 2. Chang

[GitHub] [cloudstack-primate] shwstppr commented on issue #231: storage: fix volume actions

2020-04-22 Thread GitBox
shwstppr commented on issue #231: URL: https://github.com/apache/cloudstack-primate/pull/231#issuecomment-618201337 @rhtyd fixed actions and args error. Tested for different scenarios Allocated volume without VM ![Screenshot from 2020-04-23 11-07-54](https://user-images.githubuse

[GitHub] [cloudstack-primate] utchoang edited a comment on issue #307: [FIX] VM Deployment Wizard Changes

2020-04-22 Thread GitBox
utchoang edited a comment on issue #307: URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618147573 * Move template/iso filter to left of search box ![image](https://user-images.githubusercontent.com/13766648/80054266-f0a97b80-8548-11ea-87bf-cf2643134b1a.png)

[GitHub] [cloudstack-primate] utchoang commented on issue #307: [FIX] VM Deployment Wizard Changes

2020-04-22 Thread GitBox
utchoang commented on issue #307: URL: https://github.com/apache/cloudstack-primate/pull/307#issuecomment-618147573 * Move template/iso filter to left of search box ![image](https://user-images.githubusercontent.com/13766648/80054199-c9eb4500-8548-11ea-9a0f-434cf36973ec.png) -

[GitHub] [cloudstack-primate] utchoang opened a new pull request #307: [FIX] VM Deployment Wizard Changes

2020-04-22 Thread GitBox
utchoang opened a new pull request #307: URL: https://github.com/apache/cloudstack-primate/pull/307 Open for https://github.com/apache/cloudstack-primate/issues/306 @rhtyd cc @svenvogel * [ ] Template filter can be left to search box and not working * [ ] TBD: should we add/have a

[GitHub] [cloudstack-primate] shwstppr commented on issue #296: view: fix api error handling

2020-04-22 Thread GitBox
shwstppr commented on issue #296: URL: https://github.com/apache/cloudstack-primate/pull/296#issuecomment-617831261 @onitake change was due to an internal review comment. I like `?:` myself, easier to understand. Although, we might have to refactor the error handling more exhaustively a

[GitHub] [cloudstack-primate] onitake commented on issue #296: view: fix api error handling

2020-04-22 Thread GitBox
onitake commented on issue #296: URL: https://github.com/apache/cloudstack-primate/pull/296#issuecomment-617825950 I tested b3805f8 and it solved the issue reported in #294 . I haven't tested 944c5f6 yet. Is there a specific reason why you changed `(x && y) || z` to `x ? y : z`? A ge

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #15: Maintenance

2020-04-22 Thread GitBox
onitake commented on issue #15: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/15#issuecomment-617727040 @iamcryptoki Thanks for the offer! The project is very much alive, but still needs some love from a few sides. If you have any issues, input or pull reque

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #9: Support loadBalancerSourceRanges

2020-04-22 Thread GitBox
onitake commented on issue #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-617720855 I reverted all changes that are covered by the other PRs for easier review. This is an automated mess

[GitHub] [cloudstack-primate] shwstppr commented on issue #296: view: fix api error handling

2020-04-22 Thread GitBox
shwstppr commented on issue #296: URL: https://github.com/apache/cloudstack-primate/pull/296#issuecomment-617705363 @rhtyd I've fixed that message comparison issue. I don't have a better solution right now for the whole notification thing. Maybe we can add a parameter for `api` function

[GitHub] [cloudstack-primate] shwstppr commented on issue #297: view: fix runDiagnostic output display

2020-04-22 Thread GitBox
shwstppr commented on issue #297: URL: https://github.com/apache/cloudstack-primate/pull/297#issuecomment-617684250 @rhtyd it works with a lab env and also with cloudmonkey local env Made changes to show stderr and errorCode, ![Screenshot from 2020-04-22 15-36-06](https://user-images

[GitHub] [cloudstack-primate] rhtyd commented on issue #300: [BUG] Upload local template - empty Hypervisor drop-down after selecting incomplete zone

2020-04-22 Thread GitBox
rhtyd commented on issue #300: URL: https://github.com/apache/cloudstack-primate/issues/300#issuecomment-617659679 @vladimirpetrov please re-test and close against latest master. This is an automated message from the Apache

[GitHub] [cloudstack-primate] rhtyd commented on issue #304: view: upload template form hypervisor fix

2020-04-22 Thread GitBox
rhtyd commented on issue #304: URL: https://github.com/apache/cloudstack-primate/pull/304#issuecomment-617659321 okay LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [cloudstack-primate] rhtyd commented on issue #273: [FIX] VM Deployment Wizard Issues

2020-04-22 Thread GitBox
rhtyd commented on issue #273: URL: https://github.com/apache/cloudstack-primate/pull/273#issuecomment-617655406 Further issues can be fixed for https://github.com/apache/cloudstack-primate/issues/306 cc @utchoang Thanks. T

[GitHub] [cloudstack-primate] rhtyd opened a new issue #306: [BUG] VM Deployment Wizard Changes

2020-04-22 Thread GitBox
rhtyd opened a new issue #306: URL: https://github.com/apache/cloudstack-primate/issues/306 We need to address the following: - Template filter can be left to search box; does n't seem to work - if I select something like Community in primate-qa server env it should show no templates (e

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #305: fixes

2020-04-22 Thread GitBox
shwstppr opened a new pull request #305: URL: https://github.com/apache/cloudstack-primate/pull/305 Fixes: #301 Fixes: #302 Fixes: #303 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack-primate] shwstppr commented on issue #304: view: upload template form hypervisor fix

2020-04-22 Thread GitBox
shwstppr commented on issue #304: URL: https://github.com/apache/cloudstack-primate/pull/304#issuecomment-617637737 @rhtyd we don't have hypervisor field in ISO form and I just checked there is no similar code while handling zone selection

[GitHub] [cloudstack-primate] rhtyd commented on issue #304: view: upload template form hypervisor fix

2020-04-22 Thread GitBox
rhtyd commented on issue #304: URL: https://github.com/apache/cloudstack-primate/pull/304#issuecomment-617625634 @shwstppr can you also check/test the `.../views/image/RegisterOrUploadIso.vue` for the same issue/pattern? Th

Re: Start problem with Marvin

2020-04-22 Thread Sven Vogel
Hi Dirk, Nice to see you here. Cheers Sven __ Sven Vogel Lead Cloud Solution Architect EWERK DIGITAL GmbH Brühl 24, D-04109 Leipzig P +49 341 42649 - 99 F +49 341 42649 - 98 s.vo...@ewerk.com www.ewerk.com Geschäftsführer: Dr. Erik Wende, Hendrik Schubert, Tassilo Möschke Registergericht: L

[GitHub] [cloudstack-primate] utchoang commented on issue #298: [WIP] Quota UI

2020-04-22 Thread GitBox
utchoang commented on issue #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-617623921 Hi @rhtyd . Regarding Issue https://github.com/apache/cloudstack-primate/issues/210 (Missing calendar functionality in Quota > Tariff), I found there is a conflict as I rest

[GitHub] [cloudstack-primate] rhtyd commented on issue #173: [BUG] Selected instance actions difference between old and new UI

2020-04-22 Thread GitBox
rhtyd commented on issue #173: URL: https://github.com/apache/cloudstack-primate/issues/173#issuecomment-617621867 @vladimirpetrov @borisstoyanov please re-test against master. I've removed the `VM volume snapshot` action on purpose, this button shouldn't exist for VM view; if we need tha

[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #173: [BUG] Selected instance actions difference between old and new UI

2020-04-22 Thread GitBox
vladimirpetrov opened a new issue #173: URL: https://github.com/apache/cloudstack-primate/issues/173 **Describe the bug** Here are the differences between the old and new UI: | Running instance - old UI | Running instance - Primate UI | |---|-

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #231: storage: fix volume actions

2020-04-22 Thread GitBox
rhtyd edited a comment on issue #231: URL: https://github.com/apache/cloudstack-primate/pull/231#issuecomment-617617002 @shwstppr please review existing actions against old UI implementation; it seems some cases are not covered. There is another issue with the `args`. Have you tested your

[GitHub] [cloudstack-primate] rhtyd commented on issue #231: storage: fix volume actions

2020-04-22 Thread GitBox
rhtyd commented on issue #231: URL: https://github.com/apache/cloudstack-primate/pull/231#issuecomment-617617002 @shwstppr please review existing actions against old UI implementation; it seems some cases are not covered. There is another issue with the `args`. Have you tested your change

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #231: storage: fix volume actions

2020-04-22 Thread GitBox
rhtyd commented on a change in pull request #231: URL: https://github.com/apache/cloudstack-primate/pull/231#discussion_r412757975 ## File path: src/config/section/storage.js ## @@ -150,20 +150,45 @@ export default { icon: 'picture', label: 'Create Templat

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #304: view: upload template form hypervisor fix

2020-04-22 Thread GitBox
shwstppr opened a new pull request #304: URL: https://github.com/apache/cloudstack-primate/pull/304 Fixes #300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #245: [BUG] Normal user: non-working links (insufficient rights)

2020-04-22 Thread GitBox
vladimirpetrov opened a new issue #245: URL: https://github.com/apache/cloudstack-primate/issues/245 **Describe the bug** The following links could generate (if the normal user lacks the required permissions) a 404 (not found) or 500 (Internal server error) errors - template, zone, host

[GitHub] [cloudstack-primate] rhtyd commented on issue #245: [BUG] Normal user: non-working links (insufficient rights)

2020-04-22 Thread GitBox
rhtyd commented on issue #245: URL: https://github.com/apache/cloudstack-primate/issues/245#issuecomment-617606306 @vladimirpetrov cc @borisstoyanov please test and close against latest master. This is an automated message

[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #233: [BUG] Domain admin: non-working links (insufficient rights)

2020-04-22 Thread GitBox
vladimirpetrov opened a new issue #233: URL: https://github.com/apache/cloudstack-primate/issues/233 **Describe the bug** The following links could generate (if the domain admin lacks the required permissions) a 404 (not found) or 500 (Internal server error) errors - template, zone, hos

[GitHub] [cloudstack-primate] rhtyd commented on issue #233: [BUG] Domain admin: non-working links (insufficient rights)

2020-04-22 Thread GitBox
rhtyd commented on issue #233: URL: https://github.com/apache/cloudstack-primate/issues/233#issuecomment-617606254 @vladimirpetrov cc @borisstoyanov please test and close against latest master. This is an automated message

[GitHub] [cloudstack-primate] rhtyd commented on issue #297: view: fix runDiagnostic output display

2020-04-22 Thread GitBox
rhtyd commented on issue #297: URL: https://github.com/apache/cloudstack-primate/pull/297#issuecomment-617602855 @shwstppr the output should also show stderr and exit value like old UI: ``` exitcode: 0 stderr: stdout: PING 8.8.8.8 (8.8.8.8): 56 data bytes 64 bytes from 8