[GitHub] [cloudstack-primate] onitake commented on issue #18: Large number of errors from eslint

2019-11-20 Thread GitBox
onitake commented on issue #18: Large number of errors from eslint URL: https://github.com/apache/cloudstack-primate/issues/18#issuecomment-556548318 That's correct - because I applied all the fixes that were suggested by the vue/standard lint rules. It's up to you to decide if you

[GitHub] [cloudstack-primate] onitake commented on issue #22: Add container build files and instructions

2019-11-20 Thread GitBox
onitake commented on issue #22: Add container build files and instructions URL: https://github.com/apache/cloudstack-primate/pull/22#issuecomment-556546380 A segfault?!?!? That sounds pretty serious... But I never ran into anything of that sort myself. Are you sure it's not a Docker o

[GitHub] [cloudstack-primate] onitake commented on issue #21: Add build dependencies to package.json and document production build properly

2019-11-20 Thread GitBox
onitake commented on issue #21: Add build dependencies to package.json and document production build properly URL: https://github.com/apache/cloudstack-primate/pull/21#issuecomment-556542860 Nice, I didn't even think about running Primate inside the Cloudstack mgmt server. The jetty ins

[GitHub] [cloudstack-primate] rhtyd commented on issue #18: Large number of errors from eslint

2019-11-20 Thread GitBox
rhtyd commented on issue #18: Large number of errors from eslint URL: https://github.com/apache/cloudstack-primate/issues/18#issuecomment-556124434 @onitake but latest master seems to be passing lint checks: https://travis-ci.org/apache/cloudstack-primate/builds/614449601 I'll have

[GitHub] [cloudstack-primate] onitake commented on issue #18: Large number of errors from eslint

2019-11-20 Thread GitBox
onitake commented on issue #18: Large number of errors from eslint URL: https://github.com/apache/cloudstack-primate/issues/18#issuecomment-556112462 The way I see it, this needs to be fixed either by removing the standard vue rules, or by adopting their coding style. Even if it works w

[GitHub] [cloudstack-primate] onitake commented on issue #18: Large number of errors from eslint

2019-11-20 Thread GitBox
onitake commented on issue #18: Large number of errors from eslint URL: https://github.com/apache/cloudstack-primate/issues/18#issuecomment-555982768 See https://travis-ci.org/apache/cloudstack-primate/builds/614182897 This i

[GitHub] [cloudstack-primate] onitake commented on issue #18: Large number of errors from eslint

2019-11-20 Thread GitBox
onitake commented on issue #18: Large number of errors from eslint URL: https://github.com/apache/cloudstack-primate/issues/18#issuecomment-555982520 I tried with eslint 4.0, but it still reported errors. Not sure if this was caused by leftovers or something else. I also did so in a fresh

[GitHub] [cloudstack-primate] rhtyd closed issue #14: Proxy to API should contain the full path

2019-11-20 Thread GitBox
rhtyd closed issue #14: Proxy to API should contain the full path URL: https://github.com/apache/cloudstack-primate/issues/14 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-primate] rhtyd commented on issue #14: Proxy to API should contain the full path

2019-11-20 Thread GitBox
rhtyd commented on issue #14: Proxy to API should contain the full path URL: https://github.com/apache/cloudstack-primate/issues/14#issuecomment-555939583 Per your comment @onitake as https://github.com/apache/cloudstack-primate/pull/21 is merged, closing this as this gets obsolete per yo

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #18: Large number of errors from eslint

2019-11-20 Thread GitBox
rhtyd edited a comment on issue #18: Large number of errors from eslint URL: https://github.com/apache/cloudstack-primate/issues/18#issuecomment-555939090 I'm unable to reproduce them on latest master @onitake - does it fix to use the eslint4.x version? ``` > npm run lint > pr

[GitHub] [cloudstack-primate] rhtyd commented on issue #18: Large number of errors from eslint

2019-11-20 Thread GitBox
rhtyd commented on issue #18: Large number of errors from eslint URL: https://github.com/apache/cloudstack-primate/issues/18#issuecomment-555939090 I'm unable to reproduce them on latest master @onitake - does it fix to use the eslint4.x version? ``` > npm run lint > primate@0

[GitHub] [cloudstack-primate] rhtyd merged pull request #22: Add container build files and instructions

2019-11-20 Thread GitBox
rhtyd merged pull request #22: Add container build files and instructions URL: https://github.com/apache/cloudstack-primate/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack-primate] rhtyd commented on issue #22: Add container build files and instructions

2019-11-20 Thread GitBox
rhtyd commented on issue #22: Add container build files and instructions URL: https://github.com/apache/cloudstack-primate/pull/22#issuecomment-555937847 I'll go ahead and merge this @onitake - if there are any issues post merge, kindly test and send another PR. I'll test later this week.

[GitHub] [cloudstack-primate] rhtyd closed issue #12: Add instructions on how to avoid system-wide global npm package installation

2019-11-20 Thread GitBox
rhtyd closed issue #12: Add instructions on how to avoid system-wide global npm package installation URL: https://github.com/apache/cloudstack-primate/issues/12 This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack-primate] rhtyd merged pull request #21: Add build dependencies to package.json and document production build properly

2019-11-20 Thread GitBox
rhtyd merged pull request #21: Add build dependencies to package.json and document production build properly URL: https://github.com/apache/cloudstack-primate/pull/21 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack-primate] rhtyd commented on issue #22: Add container build files and instructions

2019-11-20 Thread GitBox
rhtyd commented on issue #22: Add container build files and instructions URL: https://github.com/apache/cloudstack-primate/pull/22#issuecomment-555935885 I'll test again, @onitake I get the following: Step 4/11 : COPY . /build/ ---> f33ff9fa996b Step 5/11 : RUN npm install

[GitHub] [cloudstack-primate] rhtyd commented on issue #22: Add container build files and instructions

2019-11-20 Thread GitBox
rhtyd commented on issue #22: Add container build files and instructions URL: https://github.com/apache/cloudstack-primate/pull/22#issuecomment-555936053 Sorry just read, we'll need to merge #12 first it seems This is an autom

[GitHub] [cloudstack-primate] rhtyd commented on issue #23: Change CRLF editor config to LF

2019-11-20 Thread GitBox
rhtyd commented on issue #23: Change CRLF editor config to LF URL: https://github.com/apache/cloudstack-primate/pull/23#issuecomment-555933128 Thanks @onitake - I personally only use vim, this was from the scaffolding/template boilerplate. --

[GitHub] [cloudstack-primate] rhtyd merged pull request #23: Change CRLF editor config to LF

2019-11-20 Thread GitBox
rhtyd merged pull request #23: Change CRLF editor config to LF URL: https://github.com/apache/cloudstack-primate/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PRIMATE][SIG] Meeting Notes

2019-11-20 Thread Rohit Yadav
Hi Greg, I'll float the idea of moving the time by few hours with the SIG group or see if people want to have two meetings to broadly cover two timezones. Let me find some time later this week or the next, I can split the checklist tasks into individual Github issues with well defined scope/req

Re: [DISCUSS] Use of Github packages for hosting version specific maven packages?

2019-11-20 Thread Rohit Yadav
Hi Marcus, Thanks for testing, I should've mentioned that not all the 4.13.0.0 jar/pom artifacts have been uploaded. I've pushed the cloud-engine artifact: https://github.com/apache/cloudstack/packages/59489 I've pushed a few more artifacts, esp. those from plugins. For the next release, we can

[GitHub] [cloudstack-primate] onitake commented on issue #14: Proxy to API should contain the full path

2019-11-20 Thread GitBox
onitake commented on issue #14: Proxy to API should contain the full path URL: https://github.com/apache/cloudstack-primate/issues/14#issuecomment-555888081 Ah yes, I forgot about the console proxy. It won't work with only the /client/api redirection. I don't quite understand with /clie