Re: [VOTE] Primate as modern UI for CloudStack

2019-10-10 Thread Sven Vogel
Sounds interesting Gregor! Von meinem iPhone gesendet __ Sven Vogel Teamlead Platform EWERK DIGITAL GmbH Brühl 24, D-04109 Leipzig P +49 341 42649 - 99 F +49 341 42649 - 98 s.vo...@ewerk.com www.ewerk.com Geschäftsführer: Dr. Erik Wende, Hendrik Schubert, Frank Richter Registergericht: Leipzi

Re: [VOTE] Primate as modern UI for CloudStack

2019-10-10 Thread Riepl, Gregor (SWISS TXT)
Automated UI testing is usually done by running a web browser, generating artificial user input, then verifying the result either by DOM analysis or image recognition on screenshots. Our devs have achieved good results with TestCafe: https://devexpress.github.io/testcafe/ It's very easy to writ

Re: [DISCUSS][PROPOSAL]merge policy ratification

2019-10-10 Thread Andrija Panic
We are here talking about the one who presses the trigger (merge), not the one submitting PR/code/etc - merge action has to be considered if it is OK to merge or not. On Thu, 10 Oct 2019 at 13:53, Sven Vogel wrote: > > Catching inefficient or poorly written code is important, but no one > will

Re: [DISCUSS][PROPOSAL]merge policy ratification

2019-10-10 Thread Sven Vogel
> Catching inefficient or poorly written code is important, but no one will > care that the code is beautifully written, if the SSVM deletes a users' VMs > because what looked good in theory didn't work in practice. Agree Paul. --trust maybe I was misunderstood. if a person has a lot of commi

RE: [DISCUSS][PROPOSAL]merge policy ratification

2019-10-10 Thread Paul Angus
Yes, the 'independent verification' could come from one of the LGTM committers, although an explanation (+'proof') would still be required for sanity checking. Catching inefficient or poorly written code is important, but no one will care that the code is beautifully written, if the SSVM delet

Re: [DISCUSS][PROPOSAL]merge policy ratification

2019-10-10 Thread Sven Vogel
I think 2 LGTM should be ok if anyone of them has tested it. The main thing is you need to trust anyway that the person if he has tested it E.g. manually. That’s live and trust from committers I think. Apache is also a chain of trust. Von meinem iPhone gesendet __ Sven Vogel Teamlead Platfor

Re: [DISCUSS][PROPOSAL]merge policy ratification

2019-10-10 Thread Andrija Panic
Is there a way to "force" some text into the PR description - i.e. like we do for ISSUES (there is some predefined text when creating one). My idea ^^^ is to make those rules visible in every PR - besides having rules more explicit, they need to be more visible (as a reminder) to humans pulling the

RE: [DISCUSS][PROPOSAL]merge policy ratification

2019-10-10 Thread Paul Angus
BUMP. Hey Guys, We have a lot of new people in the community these days; this seems like an important exercise to ensure that we're all on the same page, whether that ends up simply re-signing up to the existing practices or evolving them. _personally_ I'd like the conditions to be more explic

RE: [VOTE] Primate as modern UI for CloudStack

2019-10-10 Thread Paul Angus
That sounds great Ivan! You can see the code at https://github.com/shapeBlue/primate Hopefully within a couple of weeks it'll be able to be included in the Apache repo. paul.an...@shapeblue.com  www.shapeblue.com Amadeus House, Floral Street, London WC2E 9DPUK @shapeblue -Original