Github user murali-reddy commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1666#discussion_r77119259
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -145,40 +145,41 @@ def add_rule(self, cidr):
logging.debu
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1670#discussion_r77118387
--- Diff: setup/db/db/schema-490to491.sql ---
@@ -23,3 +23,11 @@
UPDATE `cloud`.`roles` SET `description`='Default user role' WHERE `id`=4
AND `
We (Abhi, Boris and me) opened couple of marvin test bugs to automate the gaps
[1], we will start to work on them. If any one wishes to contribute please feel
free to pick them up.
[1]
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router%3A+Smoke+and+Integration+tests+gap+analy
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1666#discussion_r77116561
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -145,40 +145,41 @@ def add_rule(self, cidr):
logging.debug("C
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
@jburwell I added marvin test, this are results on VMware env:
```
[root@ussarlabcsmgt41 cloudstack]# cat
/tmp//MarvinLogs/test_deploy_vgpu_enabled_vm_OG63Q9/results.txt
# 1. Re
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77080602
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -212,20 +251,47 @@ public Snapsh
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77080424
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77080328
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77079861
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77079527
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34 @@
@
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77079000
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private voi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77078902
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private voi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77077921
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private voi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77077963
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private voi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77075736
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -328,15 +412,64 @@ private voi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77074337
--- Diff: core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java
---
@@ -51,6 +50,7 @@
private final String url;
private Ma
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77074073
--- Diff:
api/test/org/apache/cloudstack/api/command/test/CreateSnapshotCmdTest.java ---
@@ -0,0 +1,130 @@
+// Licensed to the Apache Software Found
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77073945
--- Diff:
api/test/org/apache/cloudstack/api/command/test/CreateSnapshotCmdTest.java ---
@@ -0,0 +1,130 @@
+// Licensed to the Apache Software Found
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77073521
--- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
---
@@ -82,6 +82,10 @@
@Param(description = "valid types are hourly,
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1624
LGTM for code review. Do we have someone testing for the second LGTM?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1624
@ProjectMoon we have a code review LGTM on #1654, and have someone lined up
to test it and provide the second LGTM. We should have the second LGTM by 1
Sept 2016 at which time you can re-kick
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@syed per our conversation on Slack, the following is the test procedure to
verify this PR:
1. Create a fresh install 4.8.1. Since we are verifying the database
upgrade, the install o
Hi Martin,
Looks like something went wrong with the CloudStack generated public/private
keys. You should not be prompted for any password when trying to ssh to
systemvms on port 3922. Can you try to destroy the VRs or create a new network
which would create a new VR.
Regarding the /bin/bash
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1667
@abhinandanprateek thanks, can you close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user fmaximus commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r76993494
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -2645,6 +2669,18 @@ public DhcpServicePro
Github user fmaximus commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r76991083
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -242,6 +249,40 @@ public void reserve(NicP
Github user fmaximus commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1578#discussion_r76991270
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -403,4 +448,25 @@ private HostVO getNuageV
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1666
LGTM based on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1644
### ACS CI BVT Run
**Sumarry:**
Build Number 86
Hypervisor xenserver
NetworkType Advanced
Passed=99
Failed=4
Skipped=3
_Link to logs Folder (search by
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1651
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1669
Thanks @milamberspace I've modified the build process to generate l10n
translation JS (dictionary) files when client/UI is built. I think if we use
json file, then also we will need some sort of t
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1666
@abhinandanprateek @borisstoyanov review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Thanks Erik for correcting.
More precisely, this is in context of migration of mysql db to Galera cluster,
where there is a limitation with Galera cluster that it supports only InnodDB
for replication due to its transactional nature.
Regards,
-abhi
On 31/08/16, 12:44 PM, "Erik Weber" wrote
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1669
@rhtyd Probably the best way will be to change the Transifex L10N resources
files type from Unicode Properties to JSON Key/value
A sample are here:
https://www.transifex.com/ke
Just nit-picking, but MyISAM allows replication as well.
I'm +1 to the change.
--
Erik
On Wed, Aug 31, 2016 at 5:37 AM, Abhinandan Prateek <
abhinandan.prat...@shapeblue.com> wrote:
> Thanks, Koushik.
>
> Have created a PR to make the engine type consistent for all tables.
> InnoDB allows for
36 matches
Mail list logo
