Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843327
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software F
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843281
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843227
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843039
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java
---
@@ -0,0 +1,128 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843031
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForHostCmd.java
---
@@ -0,0 +1,107 @@
+// Licen
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843007
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java
---
@@ -0,0 +1,107 @@
+// Lice
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843036
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForZoneCmd.java
---
@@ -0,0 +1,105 @@
+// Licen
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843025
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForClusterCmd.java
---
@@ -0,0 +1,105 @@
+// Li
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843002
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java
---
@@ -0,0 +1,127 @@
+// Licensed
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843006
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForClusterCmd.java
---
@@ -0,0 +1,105 @@
+// L
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61842996
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -0,0 +1,116 @@
+// Lice
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61843016
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForZoneCmd.java
---
@@ -0,0 +1,105 @@
+// Lice
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1528#issuecomment-216448597
LGTM but let's run as much marvin tests as possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Hi,
I have upgraded my cloudstack from 4.4 to 4.8. After upgrading, the agent on
hosts cannot start. I receive the following message:
20:08:45,833 ERROR [cloud.agent.AgentShell] (main:null) (logid:) Unable to
start agent:
com.cloud.utils.exception.CloudRuntimeException: Unable to start the c
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216446492
@swill It seems reasonable to me. It doesn't look like equivalent
functionality to what was previously there, but presumably that was why it was
changed?
-
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-216444177
I tested this by walking through with the debugger when the delete method
on Host was invoked from a test script of mine.
---
If your project is set up for
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1529
Marvin: Replace a timer.sleep(30) with pulling logic
https://issues.apache.org/jira/browse/CLOUDSTACK-9374
From the ticket:
In the base.py file, there is a Host class wi
also check java version and upgrade nss
http://blog.backslasher.net/java-ssl-crash.html
~Rajani
On Tue, May 3, 2016 at 7:36 AM, Simon Weller wrote:
> Ellie,
>
> Can you try forcing ACS Management to only bind to IPV4?
> Normally this is done in the JAVA_OPTS by setting
> -Djava.net.preferIPv4St
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216442417
@DaanHoogland I'm seeing a lot of commits, can you rebase against 4.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216442130
@rhtyd thanks for fixing the merge conflicts. ð
@GabrielBrascher and @mike-tutkowski, I know you guys have spent some time
with this file, would you guys
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-216442091
@DaanHoogland can you do a rebase and push -f, Travis failed for
`test_01_scale_vm` test
In general, LGTM (just code review)
---
If your project is set up f
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216441837
Thanks @rhtyd, this makes me feel a little more comfortable. @borisroman
if you can give us a bit of an outline of what you have tested, I think it will
help everyon
hopefully we will have labels soon™. i am working on trying to get the
repo moved from the 'apache' github org to 'apache-cloudstack' so we can
control this sort of stuff and enable labels. it will make things SOO much
easier.
simon's contributions have been very helpful for me as RM though, so
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-216440946
Thanks @rhtyd. I will do a CI run on master before I merge anything else.
I will also pull in a couple people who I know have worked on this code to
review your upd
great job Simon David and Will.
Given that we dont have github labels, this is very useful for the RM to
pickup the prs to merge and for others to review pending.
~Rajani
On Tue, May 3, 2016 at 9:47 AM, Simon Weller wrote:
> All,
>
> Will mentioned a little project we've been working on to try
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-216436317
@rafaelweingartner for a project with thousands of commits, splitting the
commits for a PR or bug that solves for the same logical issue results in
fragmented history
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216435537
@sudhansu7 can you rebase against latest master, squash the changes to a
single commit and push -f to re-kick travis. Thanks
---
If your project is set up for it, yo
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-216435475
@DaanHoogland thanks, how about you have consecutive changes by the same
author squashed to one commit; while keep it separate per author in general
---
If your proj
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-216435381
@swill agree for keeping it against 4.7; but it would be great if @dsclose
can squash the changes to a single commit as all of them solve for
Cloudstack-9339 issue
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216435191
@swill yes indeed we've performed upgrade tests with 4.8.1 to
4.9.0-SNAPSHOT (not using the feature by default) and then using
migrate-dyanamicroles.py script; the ot
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216435060
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216435050
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1528#issuecomment-216433425
LGTM based on the discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216433479
Obviously this merge conflict exists because something has been refactored
in master which was not merged into previous versions. We need to understand
what was done
All,
Will mentioned a little project we've been working on to try and help get a
grasp on the open PR list.
You can access it here: http://acs:a...@acspr.ena.net
Due to the lack of github labels currently, there's quite a bit of
regex/pattern matching involved in determining data sets, so plea
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1321#discussion_r61833885
--- Diff:
engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java ---
@@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer() throw
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216423449
@swill yes that's what I meant, therefore commented that it's ready for
merge. Thanks.
---
If your project is set up for it, you can reply to this email and have you
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-216423344
@swill no objection, let's merge this
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r61833516
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1364,15 @@ private Answer attachVolume(Co
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1321#discussion_r61833399
--- Diff:
engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java ---
@@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer() throw
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r61833203
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1364,15 @@ private Answer attachVolume(Co
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1321#discussion_r61833186
--- Diff:
engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java ---
@@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer() throw
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216421909
@swill forced pushed; the Jenkins server is not reliable -- as long as
Travis is green we are alright; the only additional check Jenkins does is the
rat check, which
Ellie,
Can you try forcing ACS Management to only bind to IPV4?
Normally this is done in the JAVA_OPTS by setting
-Djava.net.preferIPv4Stack=true -Djava.net.preferIPv4Addresses=true
I think on the ACS Ubuntu release, JAVA_OPTS is set in your init scripts, but
I'm not absolutely sure about that.
Github user Slair1 commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-216396939
@kiwiflyer and @rhtyd I've been troubleshooting the proxy issue and it was
an issue in my environment! i have things worked out and everything works
fine.
---
I
Hello All,
As you all know, I am the RM for the 4.9 release. Unfortunately, this is
not a position I will be able to maintain for the long term, so we should
start this discussion sooner rather than later.
I am actively working to simplify the RM role by working towards the
following goals:
- Get
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61817458
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61816897
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
ACS PRs
- 1433 - master (ready)
- 1230 - master (ready)
- 1350 - master (ready)
- 1463 - master (ready)
- 1502 - master (ready, pending comments)
- 1054 - master (ready, do grep)
- 1515 (1375) - 4.8 (ready, pending new 4.7 PR)
- 1477 - 4.7 (ready, pending verification)
-
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61816189
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61816081
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user serverchief commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216382896
@kiwiflyer,
My testing with this patch - if you have at least several hundred KVM
nodes connected to 2 MS via VIP and take 1 MS down, you will notice
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61815152
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61815144
--- Diff: test/integration/smoke/test_outofbandmanagement.py ---
@@ -0,0 +1,561 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61814453
--- Diff:
server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java
---
@@ -0,0 +1,119 @@
+// Licensed to the Apach
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61814182
--- Diff:
server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java
---
@@ -0,0 +1,119 @@
+// Licensed to the Apach
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61813894
--- Diff: server/test/com/cloud/resource/MockResourceManagerImpl.java ---
@@ -172,6 +173,12 @@ public Cluster getCluster(final Long clusterId) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61813822
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61813461
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216378613
Thank you @kiwiflyer. ð
@rhtyd can you force push this PR again to try to get Jenkins green?
Thanks... Otherwise this one is ready...
---
If your pro
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216375175
I pulled this into a hardware lab on 4.8.1. I setup a number of fake
clients and hammered 8250. Prior to the patch the agents end up in a
disconnected state afte
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61810525
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61810461
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61810223
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61809934
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1527#issuecomment-216371746
Previous PR was #1374, for book keeping...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
If a couple people could review this (it should be fast), I opened the
following PR:
https://github.com/apache/cloudstack/pull/1528
Thanks!
Mike
From: Tutkowski, Mike
Sent: Sunday, May 1, 2016 7:16 PM
To: dev@cloudstack.apache.org
Subject: Re: Python Ques
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1528
CLOUDSTACK-9373: Class methods over-shawdowing instance methods
We have some methods in base.py that are named the same.
Per my findings below, Python methods in a class should n
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1527
Update L10N resource files with 4.7 strings from Transifex (20160502)
Force "translator" mode with the transifex client.
cc @swill the new PR.
You can merge this pu
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1321#discussion_r61808445
--- Diff:
engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java ---
@@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer() throw
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216370438
@swill ok I will do this. But you must understand that the L10N resources
files for each CS version are different and cannot merge together. On the
Transifex
Github user milamberspace closed the pull request at:
https://github.com/apache/cloudstack/pull/1374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61807854
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r61807823
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1364,15 @@ private Answer attachVolume(Co
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61806348
--- Diff:
api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java
---
@@ -0,0 +1,51 @@
+// Licensed to the Apache Softwar
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61804388
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61803751
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-216354858
After rebasing today, I re-ran SolidFire-related automated integration
tests (about 3.5 hours of tests) and all were successful.
test_01_create_volum
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216354228
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user imduffy15 commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216353475
I'm not familiar with that block of code, remi's changes and justification
seem fine though.
Some very oddly/badly worded variable names.
---
If your pr
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-216353485
@rafaelweingartner I squashed them, thanks for your comments and reviews!
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61798443
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-216351223
Just an update,
I forgot to ask, can you squash the commits?
I think this one it is better to have all of the changes into a single
commit.
---
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61795721
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java
---
@@ -0,0 +1,532 @@
+// Licensed to the Apache
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61795629
--- Diff:
server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementBackgroundTask.java
---
@@ -0,0 +1,45 @@
+// Licensed to the Apac
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-216347918
@nvazquez, that is great.
As always your PRs are perfect, great job;)
LGTM from me here.
---
If your project is set up for it, you can reply to t
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216347252
@milamberspace I think that is probably the best option. Then I will merge
the new one (with these changes) first and forward merge and then merge #1515
and then if
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61793974
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -251,8 +262,9 @@ public boolean start() {
}
private void init(Ma
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61792886
--- Diff:
plugins/outofbandmanagement-drivers/ipmitool/test/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapperTest.java
---
@@ -
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-216337441
Here are the results of my automated regression test:
test_add_remove_host_with_solidfire_plugin
(TestAddRemoveHosts.TestAddRemoveHosts) ... === TestN
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r61790055
--- Diff:
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
---
@@ -117,4 +153,60 @@ public void testStartVm
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1524#issuecomment-216336787
this does not work for me as well.
If there are multiple public interfaces in the VR, only the last one works.
---
If your project is set up for it, you ca
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216336456
@swill @DaanHoogland Yes, on my local machine, the branch are open against
thr 4.7 branch. The PR in github is against the master, but will be against 4.7.
Just an FYI that I no longer see this problem (as was expected).
Thanks!
From: Tutkowski, Mike
Sent: Monday, April 18, 2016 12:05 PM
To: dev@cloudstack.apache.org
Subject: Re: Strange XenServer SR behavior when deploying system VMs in Basic
Zone on 4.9
T
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r61789411
--- Diff:
plugins/outofbandmanagement-drivers/ipmitool/src/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapper.java
---
@@ -0,0 +
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-216333866
How should I test this? I think this is in a pretty good place pending
some verification...
---
If your project is set up for it, you can reply to this email and hav
1 - 100 of 391 matches
Mail list logo
