[GitHub] cloudstack pull request: CLOUDSTACK-9164: Prevent firefox's quick ...

2016-04-24 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1271#issuecomment-214154019 @swill done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2016-04-24 Thread priyankparihar
Github user priyankparihar commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-214146326 @koushik-das Currently UI does not allow migration between different versions, and changing UI for this change is not elegant. Purpose of doing this chang

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-04-24 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-214143155 LGTM. Code Reviewed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-04-24 Thread alexandrelimassantana
Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1516#discussion_r60852850 --- Diff: engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java --- @@ -962,35 +962,59 @@ public boolean removeBy(Short capacityType

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-04-24 Thread sudhansu7
Github user sudhansu7 commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-213954430 @DaanHoogland Thanks for the review. I have made necessary changes. I think in t=your test setup op_host_capacity does not have capacity details, for which t

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-04-24 Thread sudhansu7
Github user sudhansu7 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1516#discussion_r60844257 --- Diff: engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java --- @@ -962,35 +962,58 @@ public boolean removeBy(Short capacityType, Long zone