[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

2016-01-20 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-173474463 @remibergsma RebootCoomand is used by rebootVirtualMachine API. Refer to test_03_reboot_vm in smoke/test_vm_life_cycle.py. It is also used in rebootSystemVm API

Build failed in Jenkins: build-master-slowbuild #3037

2016-01-20 Thread jenkins
See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

2016-01-20 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1310#issuecomment-173439752 Thanks for your help @cristofolini! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Build failed in Jenkins: build-master-slowbuild #3036

2016-01-20 Thread jenkins
See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

2016-01-20 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1338#issuecomment-173436054 Thanks @remibergsma. Sorry I saw your comments bit late. You have already figured it out. Thanks @DaanHoogland --- If your project is set up for it, you ca

Build failed in Jenkins: build-master-slowbuild #3035

2016-01-20 Thread jenkins
See Changes: [nitin.maharana] CLOUDSTACK-9229: Autoscale policy creation failing in VPC due to zoneid [nitin.maharana] CLOUDSTACK-9235: Autoscale button is missing in VPC [nitin.maharana] CLOUDSTACK-9237: Create LB Health

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173398341 @rafaelweingartner I have no idea about 'those magic numbers' I didn't touch them. I can remove the @author. it was auto generated. thanks for the compl

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50336727 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -190,4 +196,28 @@ Use VIR_

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50335474 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -190,4 +196,28 @@ Use VIR_DO

[VOTE] Apache CloudStack 4.8.0

2016-01-20 Thread Remi Bergsma
Hi all, I've created a 4.8.0 release candidate, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.8.0-RC20160120T2343 Commit: 62f218b7bd005d201d1c8516180d8e6d6797 Source release (checksums and signa

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173392186 @remibergsma that is serious. migration is failing for us with the tested code and the test is failing with the fix. I have work to do it seems. :) Can you sen

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173389882 @wido the problem we encountered in our env is not with NFS servers but with RBD. sorry for the misdirection. --- If your project is set up for it, you can re

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50334011 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -190,4 +196,28 @@ Use VIR_

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50333804 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -48,6 +49,9 @@ @Resou

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50333689 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -1,4 +1,5 @@ // +

[VOTE] Apache CloudStack 4.7.1

2016-01-20 Thread Remi Bergsma
Hi all, I've created a 4.7.1 release candidate, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.7.1-RC20160120T2318 Commit: 5ea07dc93799f28dd6c268b17514867d92dc53f7 Source release (checksums and signa

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50325672 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -48,6 +49,9 @@ @Resourc

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50325617 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -1,4 +1,5 @@ // +

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173364862 @DaanHoogland This test is failing: ``` Test migrate VM ... === TestName: test_08_migrate_vm | Status : EXCEPTION === ERROR ``` Det

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1334#issuecomment-173364778 LGTM :+1: Based on code review and screenshot from remi --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

2016-01-20 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1310#issuecomment-173364669 Thanks again, @nvazquez. The unit test you wrote is a nice improvement and I'm fine with it. :) Code LGTM. --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: build-master-slowbuild #3034

2016-01-20 Thread jenkins
See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173360077 Except for the concern that there may be multiple graphics element where the method would clearly fail, LGTM. Please also squash your commits. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r50319348 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -190,4 +196,28 @@ Use VIR_DOMA

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173358933 Hi @DaanHoogland, I would only suggest you extracting those magic numbers at line 97 to constant variables (using some descriptive names).

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1340 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

2016-01-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1340#issuecomment-173357915 LGTM, wasn't able to check it with a Netscaler setup. Looks good and syntax of js is OK. https://cloud.githubusercontent.com/assets/1630096/12462979/7f44d4c2

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-01-20 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1348#issuecomment-173357364 Looking at this test I see the problem indeed. I actually created this regression while fixing it. One thing though, you mean that the IP of the NFS server is

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

2016-01-20 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1310#issuecomment-173350754 Thanks @cristofolini I've tryied writing a marvin test for testing this feature which would be: * Select (or create) a vm (id=) which is already running

Build failed in Jenkins: build-master-slowbuild #3033

2016-01-20 Thread jenkins
See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #3032

2016-01-20 Thread jenkins
See Changes: [bharat.kumar] CLOUDSTACK-8860: improve error messages in VM deployment code path. [Rajani Karuturi] updating rabbitmq amqp client to 3.5.4 from 3.4.2 [Rajani Karuturi] CLOUDSTACK-8885: added blocked connecti

[GitHub] cloudstack pull request: Refactor test_vpc_vpn, add test for multi...

2016-01-20 Thread bheuvel
GitHub user bheuvel opened a pull request: https://github.com/apache/cloudstack/pull/1355 Refactor test_vpc_vpn, add test for multiple VPNs Refactored to clear usage of setup/setupClass, teardown/teardownClass Refactored TestVpcSite2SiteVpn to include class TestRVPCSite2Site

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50259649 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py --- @@ -96,29 +96,8 @@ def configure_server(self): self.conf.search(sli

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50259430 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def ma

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-173220018 @wilderrodrigues Agreed @pedro-martins comments, persé should add to the clarity of the code, even javadoc. If the name is explanatory and there are no unexpe

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50259249 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def ma

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread pdube
Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50259089 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def ma

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

2016-01-20 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-173218775 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: UI: improve filter dropdown width

2016-01-20 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1354#issuecomment-173218473 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

2016-01-20 Thread Patrick Dube
Congratulations! On Wed, Jan 20, 2016 at 12:57 AM, Sanjeev N wrote: > Congrats Boris !! > > On Wed, Jan 20, 2016 at 12:10 AM, ilya > wrote: > > > Warm welcome Boris.. > > > > On 1/19/16 4:15 AM, Wilder Rodrigues wrote: > > > The Project Management Committee (PMC) for Apache CloudStack is please

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

2016-01-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1323#issuecomment-173214346 :) @wilderrodrigues obviously; it is a test, @sanju1010 tested it himself, do you want to test it in different environments? --- If your project is set up for

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/857 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/864 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9195: Cancelled/failed async j...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9195: Cancelled/failed async j...

2016-01-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1272#issuecomment-173205246 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50252187 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py --- @@ -96,29 +96,8 @@ def configure_server(self): self.conf.

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50251936 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1346 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50251745 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50251651 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py --- @@ -96,29 +96,8 @@ def configure_server(self): self.conf.sear

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50251563 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/846#issuecomment-173198529 Ping @remibergsma @borisroman @kishankavala added a unit test to cover his change. I went through the code and haven't found any issue. The

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/864#issuecomment-173197587 Ping @remibergsma @borisroman Please, make it happen! :) Cheers, Wilder --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/857#issuecomment-173197191 Ping @remibergsma @borisroman I don;t have a way to test it now, but looked at the code - just like @DaanHoogland @wido and @runseb did. I trust the

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1198#issuecomment-173196826 Ping @remibergsma @borisroman This one needs an integration test to cover the changes. Worth writing one for. Who got time left? :) Cheers

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1200#issuecomment-173196336 @koushik-das Is there any integration test that can cover this? If so, we will run it and get this merged. Otherwise I can help writing one

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1323#issuecomment-173196099 Ping @remibergsma @borisroman This one needs to be tested. Cheers, Wilder --- If your project is set up for it, you can reply to this

RE: [PROPOSAL] LTS Release Cycle

2016-01-20 Thread Paul Angus
Absolutely Remi, we're looking to learn all that we can from those who already use Marvin. It's tougher for us non-developers to get started, but once we get the understanding in terms which we are used to working with, then we can better explain it to users and expand the number of people who c

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-173195505 Ping @remibergsma This one ca have the integrations tests executed against. @pedro-martins: no need to add javadocs. The code should be se

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-173194446 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: UI: improve filter dropdown width

2016-01-20 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1354 UI: improve filter dropdown width Giving a little more space to fix new line, see [after and before](https://photos.google.com/share/AF1QipP6ZeMO4B_fSLCBocr0MQmgbbq3gAf0vDY8Hy4YjUgqLH_VY8vpP2y5U6

Re: [PROPOSE] Dynamic inter VPC routing

2016-01-20 Thread Erik Weber
Thans Abhi, glad to hear :-) -- Erik On Wed, Jan 20, 2016 at 1:06 PM, Abhinandan Prateek < abhinandan.prat...@shapeblue.com> wrote: > Erik, > > Updated the doc to reflect that the CIDR partitioning is not rigid. > > > > > > [image: ShapeBlue] > Abhinandan Prateek > So

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1346#issuecomment-173187438 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1238#issuecomment-173186580 Closing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1232#issuecomment-173186549 Closing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

Build failed in Jenkins: build-master-slowbuild #3031

2016-01-20 Thread jenkins
See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/720#issuecomment-173186487 Been open for 3 months, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/720 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-173185763 No reviews, so closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1236#issuecomment-173185634 Closing because of preference to logback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-173185402 Conflicts, won't resolve them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-173185348 Conflicts, won't resolve them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-173185222 When the network stack get's refactored this won't be necessary anymore. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/886 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/832#issuecomment-173184982 Most of them have already been resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/832 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1340#issuecomment-173184740 LGTM :+1: Reviewed code, and according to the screenshots it works. --- If your project is set up for it, you can reply to this email and have your rep

Re: [PROPOSE] Dynamic inter VPC routing

2016-01-20 Thread Abhinandan Prateek
Erik, Updated the doc to reflect that the CIDR partitioning is not rigid. [ShapeBlue] Abhinandan Prateek Software Architect , ShapeBlue d: | s: +44 203 603 0540 | m: +91 970 11 99011 e: abhinandan.prat...@shapeblue.com | t: <

Re: [PROPOSAL] LTS Release Cycle

2016-01-20 Thread Daan Hoogland
Rohit, I don't see any reasons beyond lack of discipline, ignorance, and laziness in your description. Not of an RM or other individual btw but of the community as a whole. In point 1 and 2 you are describing how cherry-pick and forward merge are actually the same amount of work. In the case of fo

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r50241366 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): d

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1346#issuecomment-173169424 Ping @borisroman @remibergsma PR LGTM :+1: * Environment * Hardware required: TRUE * Management Server + MySQL on CentOS 7.1

Re: [PROPOSAL] LTS Release Cycle

2016-01-20 Thread Remi Bergsma
Hi Paul, I just hope you won’t reinvent the wheel ;-) Feel free to use what was build to test the 500+ PRs that got merged over the last couple of months to build 4.6, 4.7 and 4.8. For results see the comments in all these PRs. More info: https://github.com/schubergphilis/MCT-shared This is

Re: [PROPOSAL] LTS Release Cycle

2016-01-20 Thread Rohit Yadav
Based on my long-time experience with maintaining and doing release work on 4.3 and later 4.5, there are many reasons where backporting is needed and forward merge won’t work; 1. Due to high codebase changes mostly due to major refactorings, it is not possible to simply cherry-pick a commit; ba

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: build-master-slowbuild #3030

2016-01-20 Thread jenkins
See -- [...truncated 28713 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [PROPOSAL] LTS Release Cycle

2016-01-20 Thread Daan Hoogland
John, I really don't see any reason to allow backporting. We refuse new features in LTS and with that have no excuse to backport anything any more. Can you give an example to prove me wrong? On Tue, Jan 19, 2016 at 10:01 PM, Paul Angus wrote: > Hi Ilya (and all others), > > We (ShapeBlue) agree

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

2016-01-20 Thread nislim
Github user nislim commented on the pull request: https://github.com/apache/cloudstack/pull/1352#issuecomment-173123805 Same result with the refactored code: ``` root@v-23-VM:~# route -n Kernel IP routing table Destination Gateway Genmask Flags Metric

Re: Help with JUnits

2016-01-20 Thread B Prakash
Ok. I have extended rootdiskresize functionality for xenserver. It was an existing KVM implementation and I extended it to include xenserver. I was also hoping to reuse its junits but couldnt find. Please let me know if you are aware of any means of finding junits for UserVmManagerImpl.commi