Re: Let’s discuss database upgrades

2016-01-03 Thread John Burwell
All, I completely agree with Wido that the notion of the ACS version (e.g. 4.6.0, 4.6.1, 4.7.0, etc) should be a purely logical concept. It points to particular git hash, a version of the database schema, etc. I also agree that supporting downgrade is a fools errand as many database schema ch

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

2016-01-03 Thread priyankparihar
GitHub user priyankparihar opened a pull request: https://github.com/apache/cloudstack/pull/1302 CLOUDSTACK-9104: VM naming convention in case vmware is used I have reverted all the changes. Now functionality is same as it was in earlier version. ACS Bug Link is as follow ==>

[GitHub] cloudstack pull request: CLOUDSTACK-9104: VM naming convention in ...

2016-01-03 Thread priyankparihar
Github user priyankparihar closed the pull request at: https://github.com/apache/cloudstack/pull/1165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Build failed in Jenkins: build-master-slowbuild #2901

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-01-03 Thread kansal
Github user kansal commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r48704472 --- Diff: server/src/com/cloud/user/AccountManager.java --- @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s public static fi

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-01-03 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-168581991 cc @DaanHoogland @jburwell Okay. Agreed with that. So I am setting the default value to false but for running tests and maybe some other existing integration we wil

Re: [DISCUSS] Move to Github

2016-01-03 Thread John Burwell
All, I am +1 to make Github the “repo of record” for the record. I believe it has been suggested to keep a secondary, read-only mirror of the repo on ASF which seems like a prudent, low effort backup. Personally, I think both Confluence and Github are fairly poor wiki implementations. Therefor

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-01-03 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-168570237 @DaanHoogland I complete agree with you regarding exposing credential information. The best practice when credentials are lost is to require that they be changed.

Build failed in Jenkins: build-master-slowbuild #2900

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

Build failed in Jenkins: build-master-slowbuild #2899

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

Re: Let’s discuss database upgrades

2016-01-03 Thread Rafael Weingärtner
That is it Ron ;) Initially, my intentions were only to change the technology, from a homemade approach to an improved one to manage/run upgrade routines to the DB. However, after giving some thought to the point you brought up, I think that we can use this thread to discuss it too. To use Flyway

Re: Let’s discuss database upgrades

2016-01-03 Thread Ron Wheeler
On 03/01/2016 7:19 AM, Rafael Weingärtner wrote: Sorry the delay on answering your inquiries, during this period of New Year’s Eve I was AFK. Thanks for the contributions of all. I will comment your questions and suggestions as follows: Ron, I understand your point that there are some projects

Build failed in Jenkins: build-master-slowbuild #2898

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

Re: [DISCUSS] Move to Github

2016-01-03 Thread Sebastien Goasguen
> On Jan 3, 2016, at 4:28 PM, humbed...@gmail.com wrote: > > > > On 2016-01-03 12:25, Sebastien Goasguen wrote: >> Bringing this one discuss thread to the top of the ML to get stronger >> consensus. >> >> We need it if we want to request a move to GitHub. >> >> Note that this is not about

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-01-03 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r48695937 --- Diff: server/src/com/cloud/user/AccountManager.java --- @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s public stat

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-168527922 @remibergsma There are internal political issues that people may face with certain upgrade, be they with or without reason. --- If your project is set up for

Re: [DISCUSS] Move to Github

2016-01-03 Thread humbed...@gmail.com
On 2016-01-03 12:25, Sebastien Goasguen wrote: > Bringing this one discuss thread to the top of the ML to get stronger > consensus. > > We need it if we want to request a move to GitHub. > > Note that this is not about leaving the ASF, it is about using GitHub to its > full potential. > >

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

2016-01-03 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-168527559 @kansal I don't agree that making noise first is the way to go. We should disable the return of the key first and document it. Security demands that we play it

Build failed in Jenkins: build-master-slowbuild #2897

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

Build failed in Jenkins: build-master-slowbuild #2896

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

Re: Let’s discuss database upgrades

2016-01-03 Thread Rafael Weingärtner
Sorry the delay on answering your inquiries, during this period of New Year’s Eve I was AFK. Thanks for the contributions of all. I will comment your questions and suggestions as follows: Ron, I understand your point that there are some projects that do not allow database change in minor version

Build failed in Jenkins: build-master-slowbuild #2895

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

[GitHub] cloudstack pull request: Quota: findbug fixes

2016-01-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1289#issuecomment-16848 Ping @bhaisaab @agneya2001 the quota plugin unit tests are failing in `4.7` and `master` branches: ``` [INFO] -

Re: [DISCUSS] Move to Github

2016-01-03 Thread Sebastien Goasguen
Bringing this one discuss thread to the top of the ML to get stronger consensus. We need it if we want to request a move to GitHub. Note that this is not about leaving the ASF, it is about using GitHub to its full potential. The ASF board is investigating ways for a project to use Github and st

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-168489874 @nitin-maharana See thread on dev-list: the errors are due to quota plugin failing since Jan 1st 2016. Once this is resolved, you can rebase. @DaanHoogl

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-03 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-168489232 @remibergsma : My new PRs are failing in 4.7. With the same change it was successful in master. I think there is some issue with the branch. --- If your pr

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-03 Thread Daan Hoogland
Remi, If a fix can be made agains 4.6, let's do that. Merging forward is no biggy and we'll be helping more people this way. On Sun, Jan 3, 2016 at 10:39 AM, remibergsma wrote: > Github user remibergsma commented on the pull request: > > https://github.com/apache/cloudstack/pull/1273#issueco

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2016-01-03 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-168481572 @nitin-maharana Any bug fix should be against 4.7, any new feature against master. Bug fixes will be forward merged to master after it is merged to 4.7. --- If

Re: [Master] Build Failing

2016-01-03 Thread Remi Bergsma
Hi, The Jenkins build "Build-master-slowbuild" has been failing since Dec 2. First due to 5 new findbugs issues, and indeed, since 2016 (build #2876) due to the quota unit tests. @abhi @rohit can you guys fix this asap? It is also the reason why Jenkins builds of PR #1300 and #1301 are failing

Build failed in Jenkins: build-master-slowbuild #2894

2016-01-03 Thread jenkins
See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg