[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-168290892 Closing this PR as made a new PR #1301 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1301#issuecomment-168290875 Reference PR #1258 (Against master). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1301 CLOUDSTACK-9186: Root admin cannot see VPC created by Domain admin user Issue: = Root admin cannot see LB rules and Public LB IP addresses created by domain-admin in UI there

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-168289642 Closing this PR as made a new PR #1300 (Against 4.7 which will be merged in master later). --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1300#issuecomment-168289311 Reference #1264 (The PR against master). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing Reproducible Steps: 1.Create a customer gateway for a VPC. 2.Edit it using UI(API call is UpdateVpnCustom

Build failed in Jenkins: build-master-slowbuild #2877

See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1273#issuecomment-168284288 @remibergsma : Shall I make this one against 4.7. I mean, should I make all pending PRs against 4.7? Is it not going to be merged? --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-168282637 Sure @remibergsma. I will a PR against 4.7. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Build failed in Jenkins: build-master-slowbuild #2876

See -- [...truncated 6042 lines...] at net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlatedCCNForSingleFile(ComplexityCalculator.java:143) at net.sourceforg

Build failed in Jenkins: build-master-slowbuild #2875

See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-168254105 pinging every badoy again: @borisroman @wido @resmo @llambiel @pyr @bhaisaab @wilderrodrigues --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-168254041 done some testing: ![screen shot 2015-12-31 at 22 55 55](https://cloud.githubusercontent.com/assets/2486961/12068663/38964556-b012-11e5-83a3-efd0e5be58

Build failed in Jenkins: build-master-slowbuild #2874

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-168246377 Great that the tests pass now! We need to be careful and test it thoroughly. I will hopefully be able to test it soon and try to finish it before the 4.8 freeze.

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-168245371 @nitin-maharana This fix should be against 4.7 IMHO. Can you make a PR for that please? We can still refer to the reviews that have been done. This way both 4.7

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-168244857 @nitin-maharana Thanks for the fix! I'd suggest making this PR against 4.7 (it will end up on master as well). --- If your project is set up for it, you can re

Build failed in Jenkins: build-master-slowbuild #2873

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2872

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1152#issuecomment-168200764 @kansal when you say 'I have deprecated that as many regressions were using the secret key from those APIs for authentication', I think we should adjust those

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1152#discussion_r48657695 --- Diff: server/src/com/cloud/user/AccountManager.java --- @@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s public sta

[GitHub] cloudstack pull request: CLOUDSTACK-6485 prevent ip asignment of p...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1299#issuecomment-168197900 LGTM, this is a regression from a code reformat in a51690be4b07bea5208344b9b07a3d38fb0cbc60. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-6485 prevent ip asignment of p...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1299#issuecomment-168196828 @remibergsma I looked it up but the commit is present in 4.7. Let's find the breaking commit. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-6485 prevent ip asignment of p...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1299#issuecomment-168193893 Pinging @DaanHoogland remember this one? It's fixed in `4.4` but I hit it again today in `4.7`. --- If your project is set up for it, you can reply to this ema

[GitHub] cloudstack pull request: CLOUDSTACK-6485 prevent ip asignment of p...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface Prevent ipaddress asignment of gateway to gateway-interface on vpc router by setting vpcid to null in network. This was fixed in 4.4

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1298 CLOUDSTACK-9204 Do not error when staticroute is already gone When deleting a static route fails because it isn't there any morei (KeyError), it should succeed instead. Error seen:

Build failed in Jenkins: build-master-slowbuild #2871

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #2870

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-168152239 @bhaisaab I am waiting for the LGTM. Can u please review the changes and give LGTM --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1264#issuecomment-168148620 LGTM. This is same to the fix in our internal branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub