GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1226
Removed .pydevproject from plugin kvm hypervisor.
Ping @wido @wilderrodrigues @remibergsma @miguelaferreira
It's there for no apparent reason...
Running integration tests n
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1225
Cloudstack 9147
Ping @wilderrodrigues @wido @remibergsma @miguelaferreira
Refactored the Apache CloudStack Plugin - Hypervisor KVM to combine
com.cloud and org.apache.cloudstack. Ru
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1224
CLOUDSTACK-9146: Refactor Hypervisor KVM into default Maven directory
structure.
Ping @wilderrodrigues @wido @remibergsma @miguelaferreira
Refactored the `Apache CloudStack Plugin
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1221#discussion_r47416109
--- Diff: test/integration/smoke/test_internal_lb.py ---
@@ -286,9 +302,12 @@ def setUpClass(cls):
%s" % (cls.account.name,
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164071815
Hi @wilderrodrigues ,
Looks good! Thanks for making the tests compliant!
```
Test create, assign, remove of an Internal LB with roundrobin ht
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-164069434
did a test build:
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
-
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164065917
LGTM :+1:
Ran tests on Ubuntu 14.04
```Create a redundant VPC with two networks with two VMs in each network
... === TestName: test_01_create_r
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/859#issuecomment-164062856
@kishankavala in your test case you are creating two UsageNetworkOfferings
and then assure that two are persisted. How does this test two nics being
created fro
Hi,
This week a bug has been fixed in the private gateway. It just missed the 4.6.1
release.
https://github.com/apache/cloudstack/pull/1184
It will be included in both 4.6.2 and 4.7.0.
You may build packages from the 4.6 branch and give those a go (packaging
folder). Also integration tests hav
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1223#issuecomment-164039298
@remibergsma Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Hi all,
We’ve been testing a lot this week with ACS 4.7 and it looks pretty good (just
one blocker!). By the end of the weekend we plan to cut a RC for 4.7.0 release.
If you’ve bug fixes you’d like to have included, please send a PR soon and/or
help review existing PRs.
Regards,
Daan / Remi
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164021612
@wido please have a look:
```
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/hom
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164019927
I have started the integration tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164018739
Ping @DaanHoogland @remibergsma @miguelaferreira @borisroman
@davidamorimfaria
Tests have been executed again and all looks fine!
```
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164016942
This where and why the vpc vr refactor started, isn't it? code lgtm, let's
have a regression test and put it in!
---
If your project is set up for it, you can
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1223#issuecomment-164015841
Hi @syed can you please squash the commits into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-164014731
LGTM, both offerings mentioned above are created fine:
```
[root@cs1 integration]# cloudmonkey
â Apache CloudStack � cloudmonkey 5.3.2. Type
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-164013935
code lgtm and @remibergsma ran the regression tests. If people complain we
have a a regression to decide on but it seems ok to me.
---
If your project is set
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164011079
@bhaisaab squash done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1223
Remove template ulimit from createtmplt.sh and createvolume.sh
Both createvolume.sh and createtmplt.sh have a 40GB hardcoded limit for
the size of the template that gets created. I could not find
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1222#issuecomment-164008050
Ping @remibergsma @DaanHoogland @miguelaferreira @borisroman
@michaelandersen
One test failed due to a network hiccup. I will run only that test aga
Team, VPC private gateway static route is not created in VR.. However its
reflecting on UI. But there is no entry on static_route table…using ip route
show table static_route.
For any clarification please do revert.
Kaushik Bora
Consultant - Networks & Cloud
A-98, LGF, C.R.Park, New Delhi
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1222
CLOUDSTACK-4374 - As a Developer I want to have HA enabled for routers that
are part or a redundant network or VPC
This PR fixes the issue we were facing with crashed redundant routers
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-164003619
Put some time in reading the RFC - yes, I actually did - and also went
through the code (with the latest changes). It LGTM :+1:
I think last @terbo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1221#issuecomment-164001738
Ping @remibergsma @DaanHoogland @borisroman @michaelandersen @bhaisaab
@karuturi @miguelaferreira
Please, keep in mind that this PR depends on PR #
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1221
CLOUDSTACK-9135 - As a Developer I want the test_internal_lb.py to test
Redundant VPCs
This PR refactors the existing tests and adds tests to cover internal LB
with Redundant VPCs.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-163999132
@DaanHoogland I changed base.py (under tools/marvin) to allow the use of
the multiple providers, but that will be in the PR I am about to create for the
new
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1215#issuecomment-163988697
@wilderrodrigues did run the add commands in an old setup, will run the
integration/regression suits and the cloudmonkey commands. code lgtm
---
If your proje
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163980980
@terbolous If you'd use a setup like that, you'd also use NAT in which case
it will still work. I think we're fine.
---
If your project is set up for it, you c
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163980356
Integration tests pass:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_pas
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163977752
Not sure what happened, the test passes fine now. LGTM.
```
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH_default_
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163967401
We used separate environment, but provided by the same infra.
What I don't get is why the tests are being executed from
```/data/git/cs1/cloudstack/
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-163964178
LGTM (just code review)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-163964303
@milamberspace squash them into one commit please, or logically split per
lang translation
---
If your project is set up for it, you can reply to this email and h
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1220
CLOUDSTACK-9141: Validate userdata for valid base64
This prevents the userdata from going through the stack completely
and finding out very late in the process that it is invalid data.
You can
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163940491
Elaborating on my LGTM: The changes are in right upgrade path. The sql
script is error free. It adds guest os support for 6.0 excluding the ones that
are depreca
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163939898
Sorry, I just started looking at PRs, next time I will elaborate on my LGTM.
For this particular one when a account is deleted it leaves the ssh key in
the us
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163930683
@agneya2001 please expand on *what* LGTY, the titel of the PR, the commit
message, your test results?
---
If your project is set up for it, you can reply to t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163927873
@agneya2001 What made you LGTM this? the titel of the PR? The description
of the feature in the ticket? code review? testing?
---
If your project is set up fo
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163912372
Although it is technically possible to use official ip address space on the
public network with routes to rfc1918 I don't know if those scenarios are
widespread o
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-163912073
@DaanHoogland
Prior Behaviour
| 127 | VOLUME.DELETE | 2 | 2015-12-08 09:30:18 |
1 | 25 | ROOT-14
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163908940
@terbolous I found an easier solution. When the public nic is on RFC1918,
we do not set the routes. When it is a real public ip, we can safely set the
routes. M
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163906540
Not sure how easy it is to implement, but a configuration setting for
'route rfc1918 per default via the internal network' would probably satisy my
worries as the
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1219
CLOUDSTACK-9139 make zwps default when defined on zone level
When a marvin definition contains a primary storage definition at zone
level it will default to zone scope. A test run is under
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163905174
@terbolous OK, I see what you mean. Let me have a look and handle this
scenario.
---
If your project is set up for it, you can reply to this email and have you
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1218#issuecomment-163903907
Testcase Result:
Dedicated cluster and router allocation ... === TestName:
test_01_dedicated_cluster_allocation | Status : SUCCESS ===
ok
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/1218
CLOUDSTACK-9140: Testcase to verify if Dedicated cluster is used for
virtual routers that belong to non dedicated account
You can merge this pull request into a Git repository by running
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-163903617
@priyankparihar please expand on testing that can prove prior and new
behaviour.
---
If your project is set up for it, you can reply to this email and have yo
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-16388
My point would be a setup like this:
Management network: 10.1.1.0/24 - this is the internal network on eth2
Configured public network: 172.16.1.0/24 -
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163898820
Working console:
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163896132
@remibergsma @wilderrodrigues @DaanHoogland
I guess you tested in the same env, right?
It might be a network issue, eg DNS or Ipv6 ?
---
If your projec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1214#issuecomment-163895685
@terbolous I appreciate your worries, and I'll try to explain why I think
there is nothing to worry about.
Right now, everything that has no specific ro
Github user SudharmaJain commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1196#discussion_r47336103
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
---
@@ -236,4 +236,15 @@ public static String
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1192#issuecomment-163885160
Re-review it, with the new commit. LGTM.
cc @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47335119
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(QuotaB
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-163885070
Alright, re-review it. LGTM.
cc @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1197#issuecomment-163883953
Guys, I think (and hate myself for bringing it up again despite my
intentions not to) you are giving an argument to merge MCT-shared#20 I use the
merge procedu
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47334512
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(Quot
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47333986
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(QuotaB
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47333902
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -83,7 +83,12 @@ public void setDomainId(Long domainI
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-163882122
LGTM (tested on Abhi's env)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1192#issuecomment-163881993
LGTM, better refactoring (fix tested on Abhi's env)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-163881611
Thanks @terbolous and @agneya2001
The PR has been updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user agneya2001 closed the pull request at:
https://github.com/apache/cloudstack/pull/1194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1194#issuecomment-163880656
Closing it as translations are submitted via transfix website.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1216#issuecomment-163879896
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-163879371
@milamberspace pt_BR updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
No idea, sorry. I have destroyed the test VMs.
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
- Original Message -
> From: "Jochim, Ingo"
> To: us...@cloudstack.apache.org
> Cc: "dev"
> Sent: Friday, 11 December, 2015 07:57:13
> Subject: AW: AW: Run Windows on t
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-163875819
ping @milamberspace Norwegian updated :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1198#issuecomment-163875769
@wilderrodrigues thanks!
I am not in a hurry to merge it into 4.6 or master. Let's merge it after
fully testing (scripts and functional test) and 2+ LGTM.
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1217
L10N update before 4.7.0 RC1
Some sentences (mainly for the new quota plugin) needs to be translated
before the 4.7.0 release candidate (planned for 14th december)
https://www.transif
74 matches
Mail list logo
