[GitHub] cloudstack pull request: 4.6 to master

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160390043 @bhaisaab The change in PR #1119 is the same as in this PR, except for an extra comma? Anyway, we should now close this PR @DaanHoogland as the result n

[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1100#issuecomment-160389915 LGTM based on the tests below. Can't really judge the change itself. ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,re

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user pdube commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1134#discussion_r46086641 --- Diff: test/integration/component/test_affinity_groups_projects.py --- @@ -0,0 +1,1083 @@ +#!/usr/bin/env python +# Licensed to the Apache Softw

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1135#issuecomment-160353791 I will check it out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: Forgotten license added

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1137#issuecomment-160339609 GPL?! ...naa just kidding. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: 4.6 to master

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160336829 @remibergsma @DaanHoogland the merge conflict resolution did not include the fix for master, I've merged #1119 to address that. `git diff master..4.6 ui/scripts` c

[GitHub] cloudstack pull request: [master] ui: Fix undefined check in insta...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Forgotten license added

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1137 Forgotten license added You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack rats Alternatively you can review and

[GitHub] cloudstack pull request: 4.6 to master

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160332479 LGTM, since the change is in the UI I built that from this branch. Two checks: - The metrics feature still works properly ![screen shot 2015-11-2

[GitHub] cloudstack pull request: [4.6.1] [4.7] CLOUDSTACK-9022: keep Destr...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-160332029 @ustcweizhou If you want this in 4.6.1, please quickly rebase and resolve conflict. Then ping me so I can run the integration tests. Thanks! --- If your projec

[GitHub] cloudstack pull request: update release to 4.7.0 so it use proper ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1103#issuecomment-160331954 @pdion891 I'm OK with this, but I think you do not need to change the version in `tools/docker/systemtpl.sh` until there is a 4.7 version. Otherwise it will res

[GitHub] cloudstack pull request: Fix secondary storage not working with sw...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1133#issuecomment-160331765 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CID-1339965 handle return value on failur...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CID-1339965 handle return value on failur...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1129#issuecomment-160324069 LGTM based on integration tests run above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-8988: Removed unused adapters ...

Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-160323858 Hi guys. Sorry for the delay. Thank you all for helping me out. I had some personal problems. My bad. Thanks once again! I hope this commit will help in

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-160323830 Hi guys. Sorry for the delay. Thank you all for helping me out. I had some personal problems. My bad. Thanks once again! I hope this commit will help in

[GitHub] cloudstack pull request: [master] ui: Fix undefined check in insta...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1119#issuecomment-160323261 PR #1136 will bring this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8988: Removed unused adapters ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-160321659 looks good, waiting on jenkins and will ask @remibergsma to schedule integration tests. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: 4.6 to master

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160321329 @bhaisaab please make sure I made the right merge decisions. @karuturi @remibergsma second LGTM? --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: 4.6 to master

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1136 4.6 to master two conflicts: ui/scripts/system.js ui/scripts/instances.js You can merge this pull request into a Git repository by running: $ git pull https://github.com/D

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9020: UI enhancements fr...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-160300884 @DaanHoogland problem fixed ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: Fix secondary storage not working with sw...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1133#issuecomment-160298443 @pdube Any news on your testing? :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-160298327 If we want this in 4.6, please don't merge this. When #1116 is merged in 4.6, it will be fwd merged to master as well. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-8988: Removed unused adapters ...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-160297495 @Daanhooglan, I got your point. So, what about if we just fix the reference for that class in “async-job-component.xml”. We could also remove the re

[GitHub] cloudstack pull request: [4.6] Add select template dropdown when r...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1081#issuecomment-160296576 sure, it was not meant as a -1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9068: Listing Port Forwarding ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1081#issuecomment-160296533 @DaanHoogland This is already much better, when you have 30 port forwarding rules the UI is unusable without this fix. When we want to make more improvements, l

[GitHub] cloudstack pull request: [4.6] Add select template dropdown when r...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1101#issuecomment-160296525 @remibergsma I had already seen the code but missed the PR; LGTM --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: [4.6] Add select template dropdown when r...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1101#issuecomment-160296404 @bhaisaab @DaanHoogland Can you guys also review please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: [4.6] Add select template dropdown when r...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1101#issuecomment-160296390 @ustcweizhou LGTM, tested it and works as expected. Minor comment: the first item in the list is empty (it will then keep the same template), rest of th

[GitHub] cloudstack pull request: CLOUDSTACK-8988: Removed unused adapters ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-160294766 @rodrigo93 Jenkins can not merge this to master. please have a look. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: CLOUDSTACK-8988: Removed unused adapters ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-160294688 I am not sure if this allocator is used any where. As it is injected by it's interface StoragePoolAllocator, it will be a choice to use from a list. It is likel

[GitHub] cloudstack pull request: CLOUDSTACK-8988: Removed unused adapters ...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-160291603 PR rebased and commits squashed for @rodrigo93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1105#issuecomment-160290985 LGTM, haven't verified Debian packages though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-160288436 My bad, I did not waited till the Maven fixed all of projects configuration. I will fix that. --- If your project is set up for it, you can reply to th

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160288372 @pdube Awesome you added all the tests! Thanks! Will have a run some tests myself soon. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1134#discussion_r46079415 --- Diff: test/integration/component/test_affinity_groups_projects.py --- @@ -0,0 +1,1083 @@ +#!/usr/bin/env python +# Licensed to the Apache

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-160288187 @rafaelweingartner @rodrigo93 I see more changes then needed in the diff. Are there proper line endings in the files? this is a usual problem in those cases.

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9020: UI enhancements fr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-160288061 Thanks @remibergsma :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9020: UI enhancements fr...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-160288038 @bhaisaab had a busy week, so took a little longer ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9020: UI enhancements fr...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-160288024 LGTM, works fine and I was able to sort columns (example global settings). ![screen shot 2015-11-28 at 13 04 27 pm](https://cloud.githubusercontent.com/

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-4787 - vmware diskcontro...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1131#issuecomment-160288028 Ping @karuturi @remibergsma @sateesh-chodapuneedi @SudharmaJain @maneesha-p --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1121#issuecomment-160287951 Ping @wido @wilderrodrigues @remibergsma Related: https://github.com/apache/cloudstack/pull/1120 --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9020: UI enhancements fr...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1106#issuecomment-160287916 ping @remibergsma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1135#issuecomment-160287896 @pdube Had a look and you may also want to tweak these settings: # Network garbage collection network.gc.wait network.gc.interval # Stor

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-160287795 @remibergsma I have rebased and squashed the commits for @rodrigo93 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1135#issuecomment-160283528 @pdube Nice one, will give it a try! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: Quota

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-160282940 All integration tests pass, so that's good! Didn't look at the Quota functionality itself yet. ![screen shot 2015-11-28 at 12 35 17 pm](https://cloud.gi

[GitHub] cloudstack pull request: Create test cases to getPatchFilePath met...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/944#issuecomment-160277954 @DaanHoogland , I have fixed those trailing lines for @pedro-martins --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CID-1339965 handle return value on failur...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1129#issuecomment-160264892 Ran the regressions suites, inittially the redundant vpc test failed so I ran it again. [1129.network.results.txt](https://github.com/apache/cloudstack/fil