[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1066#discussion_r45030452 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java --- @@ -55,10 +55,10 @@ public void u

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1071#issuecomment-157299325 Had a look yesterday and lgtm, didn't want to comment untill I saw the test results. (It seemed so small ;) --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-157287092 Which automated tests? The ones in Travis that we cannot yet trust? For the sake of review/feedback, that's valid. But concerning tests, we also run

[GitHub] cloudstack pull request: CLOUDSTACK-9063 CitrixResourceBase refact...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1066#discussion_r45026523 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java --- @@ -55,10 +55,10 @@ public voi

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1071#issuecomment-157286509 Hi @remibergsma and @karuturi Went through the code, which was quite straight forward. Based on that, this PR LGTM :+1: Cheers, Wilde

Re: Hello 4.6.0, now what?!

2015-11-16 Thread Wilder Rodrigues
Nice email, Remi! The most important point that everyone has to be aware of: Master is release branch for 4.7 Master has now become the 4.7.0 release branch. Please see PR [2] to make that happen. Soon, we will start accepting all types of Pull Requests again. Bu

cloudstack UI

2015-11-16 Thread Abhinandan Prateek
Hi, I am considering some improvements to cloudstack UI. Like delinking the quick view with the details page. Such that the details page can contain listView. Another change that can make UI more compact and flexible is to have multiple listViews in a listView i.e. Recursive listViews or

[GitHub] cloudstack-docs-install pull request: 4.6.0 release update, url, p...

2015-11-16 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/25#issuecomment-157277510 Can you remove ./source/installation.rst.old file? I think its not used anymore. one minor correction :+1: otherwise --- If your project is

[GitHub] cloudstack-docs-install pull request: 4.6.0 release update, url, p...

2015-11-16 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack-docs-install/pull/25#discussion_r45024579 --- Diff: source/installation.rst.old --- @@ -86,7 +86,7 @@ Management Server may be placed on a virtual machine. - Operating sys

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

2015-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-www/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

2015-11-16 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack-www/pull/17#issuecomment-157274083 tested. the page load fine. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack-www pull request: 4.6.0 is out!

2015-11-16 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack-www/pull/18#issuecomment-157273709 release notes, install instructions links arent live yet. I am assuming they will be once the branch is created. One minor correction: "Configure Packag

Re: [DISCUSS] Shared Networks on Nicira NVP Plugin

2015-11-16 Thread Rajani Karuturi
check this thread http://markmail.org/thread/xzpiaxnganny3ian ~Rajani On Tue, Nov 17, 2015 at 1:16 AM, Nicolás Vázquez wrote: > Thanks Rajani! > > Is there any planned release date for 4.7 version? > > 2015-11-13 7:51 GMT-03:00 Rajani Karuturi : > > > Hi Nicolas, > > Right now master is frozen

[GitHub] cloudstack-docs-install pull request: 4.6.0 release update, url, p...

2015-11-16 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-docs-install/pull/25 4.6.0 release update, url, packages Updated doc for 4.6.0, does not include new features or dependency. but updated URL for systemvm and install repos. On LGTM I will merge

[GitHub] cloudstack-www pull request: Update the list of known CloudStack u...

2015-11-16 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-www/pull/17#issuecomment-157209722 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cloudstack-www pull request: 4.6.0 is out!

2015-11-16 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-www/pull/18 4.6.0 is out! This PR include updated download links for 4.6.0 and API docs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdion891/clo

Re: website API doc

2015-11-16 Thread Sebastien Goasguen
it’s all on the website now. that’s the last bit that is not automated. We need to build the html and push that directly. > On Nov 16, 2015, at 9:02 PM, Pierre-Luc Dion wrote: > > Hi all, Seb, > > I want to update API doc of our website to publish 4.6 API. do we use > https://github.com/apa

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1071#issuecomment-157169270 @DaanHoogland @wilderrodrigues @miguelaferreira Can either of you review so we can merge this and open master for new features? --- If your project is set up f

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1071#issuecomment-157168301 LGTM: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_vpc_redundant.py \

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-16 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-157154339 @miguelaferreira Great, I rebased my branch to master and pushed again --- If your project is set up for it, you can reply to this email and have your reply appear

website API doc

2015-11-16 Thread Pierre-Luc Dion
Hi all, Seb, I want to update API doc of our website to publish 4.6 API. do we use https://github.com/apache/cloudstack-www now? so I have to do a PR with the new API doc or it's still using SVN ? thanks. PL

Re: [DISCUSS] Shared Networks on Nicira NVP Plugin

2015-11-16 Thread Nicolás Vázquez
Thanks Rajani! Is there any planned release date for 4.7 version? 2015-11-13 7:51 GMT-03:00 Rajani Karuturi : > Hi Nicolas, > Right now master is frozen and RC2 is in progress (welcome to test and got > :)). Once RC2 is voted, 4.6 branch would be created and master would become > 4.7 > At this p

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-16 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1075#issuecomment-157133142 `package.sh -d centos7 -r 3` (...) `Wrote: /root/cloudstack-packaging_release_version/dist/rpmbuild/RPMS/x86_64/cloudstack-management-4.6.0-SNAPSHOT

[GitHub] cloudstack pull request: CLOUDSTACK-9065: Packaging RPM, add optio...

2015-11-16 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1075 CLOUDSTACK-9065: Packaging RPM, add option for package release version, cleanup and lint In package.sh * lint * adjust exit codes (1 for usage, 2 for maven, 3 for rpmbuild)

[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8708: gson update and Ar...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-157122201 get #987 working first then rethink this code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8708: gson update and Ar...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/932 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Add package release version option to RPM...

2015-11-16 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1074#issuecomment-157114580 closed pr, needs extra testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: Add package release version option to RPM...

2015-11-16 Thread davidamorimfaria
Github user davidamorimfaria closed the pull request at: https://github.com/apache/cloudstack/pull/1074 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Add package release version option to RPM...

2015-11-16 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1074 Add package release version option to RPM packaging script Add package release version option to RPM packaging script, and do some needed linting and code refactoring. You can merge t

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-157030796 running the integration tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

Re: code quality improvement

2015-11-16 Thread Daan Hoogland
great Wolf (and keep spreading the word) On Mon, Nov 16, 2015 at 12:08 PM, Wolf Halton wrote: > I am going to look into that. Code cleanup may be just my speed right now. > > Wolf Halton > Atlanta Cloud Technology > Cybersecurity & Disaster Recovery Solutions > Mobile/Text 678-687-6104 > > -- >

Re: code quality improvement

2015-11-16 Thread Wolf Halton
I am going to look into that. Code cleanup may be just my speed right now. Wolf Halton Atlanta Cloud Technology Cybersecurity & Disaster Recovery Solutions Mobile/Text 678-687-6104 -- Sent from my iPhone. Creative word completion courtesy of Apple, Inc. > On Nov 16, 2015, at 3:23 AM, Daan Hoo

Re: DevCloud deployment

2015-11-16 Thread Илья Толстихин
Thanks. 2015-11-16 10:28 GMT+06:00 Rajani Karuturi : > I find it easier to use devcloud4[1]. It the easiest way for xen6.2 > devcloud setup. > The documentation is also good. Just install the required tools/IP configs > mentioned in README [2]. Then, go to the advanced and follow the readme[3] >

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-16 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1059#issuecomment-156991846 @remibergsma #1073 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-16 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1073 CLOUDSTACK-9055: fix NPE in updating Redundant State of VPC networks This issue happened when the KVM nodes is down.It might also happen when the cloudstack-agent is killed unexpectedly. Y

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-16 Thread ustcweizhou
Github user ustcweizhou closed the pull request at: https://github.com/apache/cloudstack/pull/1059 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-156989823 @remibergsma this is a very cool *feature*. why do you suggest it be put in 4.6? --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1061 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156988390 #1072 contains this code to be merged on 4.6 (and rebased on post-release commit) --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1072 CLOUDSTACK-9057 remove old system vm upgrade code You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-156986694 I've run this for some time and it is really cool, thanks @bhaisaab LGTM If you consider back porting this to 4.5.3, then I think we should also include

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-16 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-156985757 @nvazquez last Friday 4.6.0 was released so current master is now 4.7.0. Could you please rebase your branch on latest master? Then @wilderrodrigues

[GitHub] cloudstack pull request: CLOUDSTACK-9055: fix NPE in updating Redu...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1059#issuecomment-156985363 @ustcweizhou Can you please make this PR against 4.6 branch? After merge it will be fwd-merged to master. Thanks! --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9058 Password server should re...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1062#issuecomment-156984813 @dsclose Can you please make this PR against 4.6 branch? After merge it will be fwd-merged to master. Thanks! --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156984574 @DaanHoogland Yes, please make this PR towards 4.6 please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156984124 @remibergsma @wilderrodrigues @karuturi is anything to be done with this? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1071#discussion_r44907513 --- Diff: build/replace.properties --- @@ -26,4 +26,4 @@ AGENTLOG=logs/agent.log MSMNTDIR=/mnt COMPONENTS-SPEC=components.xml REMOTEHOST=l

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1071#discussion_r44907228 --- Diff: build/replace.properties --- @@ -26,4 +26,4 @@ AGENTLOG=logs/agent.log MSMNTDIR=/mnt COMPONENTS-SPEC=components.xml REMOTEHOS

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1071#issuecomment-156980076 Thanks @karuturi will give it a test-drive soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Merge 4.6 release branch to master

2015-11-16 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/1071 Merge 4.6 release branch to master Initial merge of 4.6 to master ignored pom.xml version number changes and changes to debian/changelog and engine/schema/src/com/cloud/upgrade/DatabaseUpg

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-9063 CitrixResourceBase ...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-156976829 I will look at the changes to see if extra unit tests are needed. I have not introduced any logical changes so far. I aggree that we should not merge anythi

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-9063 CitrixResourceBase ...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1066#discussion_r44905330 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java --- @@ -55,10 +55,10 @@ public void u

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues closed the pull request at: https://github.com/apache/cloudstack/pull/1064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156974109 Please have a look at #1070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-156960642 @wilderrodrigues Starting my tests.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1064#issuecomment-156960593 Please close this PR, as will get #1070 in now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1070#issuecomment-156957978 Ping @remibergsma PR against 4.6 has been created. No we need people to review/test it. Cheers, Wilder --- If your project is set up

[GitHub] cloudstack pull request: [4.6.1] CLOUDSTACK-9015 - Redundant VPC V...

2015-11-16 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1070 [4.6.1] CLOUDSTACK-9015 - Redundant VPC Virtual Router's state is BACKUP & BACKUP or MASTER & MASTER This PR closes #1064 All the details can be found in the original PR, which

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-9063 CitrixResourceBase ...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1066#issuecomment-156955059 Hi @DaanHoogland Since this is still WIP, would be nice to extract local variable instead of calling all those methods in line. Also, I haven't see

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-9063 CitrixResourceBase ...

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1066#discussion_r44897995 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java --- @@ -55,10 +55,10 @@ public voi

[GitHub] cloudstack pull request: implement upgrade path from 4.6.0 to 4.6....

2015-11-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1067#issuecomment-156954538 Hi, @remibergsma and @DaanHoogland tested this PR and I reviewed the code. it LGTM :+1: Cheers, Wilder --- If your project is set

code quality improvement

2015-11-16 Thread Daan Hoogland
I know it is not sexy and we all much rather implement cool new things but there is some technical debt in cloudstack there a view tools running that analyse the code and report on it on the web. See links for those. I try to pick at least one issue a week and address it to hopefully get it reviewe

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

2015-11-16 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1069 javascript:TrailingComma sonacube issue considered blocker removed simple change in several locations You can merge this pull request into a Git repository by running: $ git pull http