[GitHub] cloudstack pull request: Removed unused classes and project.

2015-10-23 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-150744688 @borisroman Hi borisroman, sure! What about this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

Hyper-V clock on KVM node - CLOUDSTACK-8978

2015-10-23 Thread Josh Harshman
Just looking for some feedback on this idea for an improvement. Currently, for any windows guest OS, we set RTC for the clock source. This seems to contribute to clock-drift issues leading to BSODs on Windows Server 2008 R2 Guests. I believe a possible improvement would be to set Windows guest

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-150713484 This is far from done and i'll change the title to be prefixed with [wip] it is a crosscutting change the touches all internal communication of cloudstack. It i

Re: UI translation for 4.6

2015-10-23 Thread Stavros Konstantaras
Hi there, Maybe I could start a Greek translation as well. Just send me the “how to”. Cheers Stavros Konstantaras Stavros Konstantaras Science faculty Research IT support (FEIOG) University of Amsterdam, Science Park 904, 1098 XH Fingerprint: E5E5 9B19 D1CD 88CD 4

RE: UI translation for 4.6

2015-10-23 Thread Jaime Orlando Rojas Sanchez
Hello, I can help with Spanish translations. Let me know how could I help. Regards / Cordialmente, Jaime O. Rojas S. Technology Manager jaime.ro...@kumo.com.co Mobile: +57 301-3382382 Office: +57-1-8766767 x215 -Mensaje original- De: Milamber [mailto:milam...@apache.org] Enviado el: vi

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150701469 @DaanHoogland How do I restart that build (the one that failed due to a timeout)? Can I do it from this UI or do I have to go elsewhere? Thanks! --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8935 - Cannot remove [r]VPC ne...

2015-10-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/967#issuecomment-150700393 Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS

Re: UI translation for 4.6

2015-10-23 Thread Milamber
Hello translators, The way to translate the web UI of CloudStack is to go on Transifex website [1]. Apache CloudStack uses this specialized service to facilitate the translation process. It's very easy, you just need to create an account (free) and start to translate with the Transifex frien

Re: UI translation for 4.6

2015-10-23 Thread Milamber
On 23/10/2015 22:17, Yiping Zhang wrote: Well, is version 2.2 still relevant at all ? Why waste time on it ? Just if you can a 100% score on cloudstack homepage on transifex website. Probably we must remove this version 2.2 (and perhaps all unsupported versions of CS) @David & @Seb have

Re: UI translation for 4.6

2015-10-23 Thread Yiping Zhang
Well, is version 2.2 still relevant at all ? Why waste time on it ? On 10/23/15, 2:09 PM, "Milamber" wrote: >Hello, > >Thanks for the translation. > >I've just open the 2.2 resource for acceptance of translated strings, >you can now grow to 100% for All versions of CloudStack. > >Milamber >

Re: UI translation for 4.6

2015-10-23 Thread Milamber
Hello, Thanks for the translation. I've just open the 2.2 resource for acceptance of translated strings, you can now grow to 100% for All versions of CloudStack. Milamber On 23/10/2015 21:58, Yiping Zhang wrote: I took a look at Chinese, and finished last two messages for 4.5/4.6. All th

Re: UI translation for 4.6

2015-10-23 Thread Milamber
Hi Erik, Thanks to the norwegian translators. I've opened an "open" PR until the merge by the release manager team just before the future RC1 of CS 4.6. You can view and check the web UI in norwegian localization if you apply the PR #974 [1] on your local git branch Milamber [1] https://g

Re: UI translation for 4.6

2015-10-23 Thread Yiping Zhang
I took a look at Chinese, and finished last two messages for 4.5/4.6. All the remaining untranslated messages are for 2.2, but that one does not accept any more translations. So there is no way to get it to reach 100% :( Yiping On 10/23/15, 12:05 PM, "Erik Weber" wrote: >On Fri, Oct 23,

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-150681274 @karuturi @remibergsma Is this still actual? If so, could you please rebase? I'll then test it and it can be a bugfix for 4.6 :) --- If your project is set up fo

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150678276 Perhaps the management server serializes delete commands that it sends to a given plug-in. On Friday, October 23, 2015, Mike Tutkowski wro

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150677439 I have actually not witnessed any issue with concurrent deletions. I've run tests on that and they passed just fine. On Friday, October 23, 2015, p

Re: UI translation for 4.6

2015-10-23 Thread Sebastien Goasguen
> On Oct 23, 2015, at 9:05 PM, Erik Weber wrote: > > On Fri, Oct 23, 2015 at 6:11 PM, Milamber wrote: > >> Hello, >> >> The new stats for the translations of Web UI 4.6 (languages over 50%): >> >> French (France) 100% >> Portuguese (Brazil) 99% >> Japanese (Japan)

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150676794 @borisroman done. #954 and #976 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [4.6] Can't create template or volume from snapshot

2015-10-23 Thread Mike Tutkowski
4.5 should be OK. I tested this kind of stuff back then and didn't notice anything. Let me make sure I'm running with the most recent system VM template for 4.6. Prior to using your PR, I was not able to deploy a VM to local storage on VMware. With your PR, I was able to perform such a deploymen

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-10-23 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-150676496 @miguelaferreira thanks a lot for your help and advices! As suggested I post test_nicira_controller.py results: $ cat /tmp/MarvinLogs/test_nicira_controller

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create volume from...

2015-10-23 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/976 CLOUDSTACK-8964: Can't create volume from snapshot of a removed volume This issue happens on KVM as well. This is because the volume info is missing in the CopyCommand once the volume ha

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150675450 @mike-tutkowski Thanks. That makes more sense now. So concurrent deletions would still be a problem? --- If your project is set up for it, you can reply to this email

Re: [4.6] Can't create template or volume from snapshot

2015-10-23 Thread Wei ZHOU
Hi Mike, Does it work without this commit? I want to know if it is caused by this commit. Moreover, does it work on cloudstack 4.5 ? 2015-10-23 21:31 GMT+02:00 Mike Tutkowski : > I just tried it, though, with managed storage and it doesn't work. Same > error of sending the CopyCommand to the wr

[GitHub] cloudstack pull request: Removed unused adapters from async-job-co...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-150672917 @rodrigo93 Thanks for squashing! Could you also rename the commit title to something more sensible? --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150672117 @ustcweizhou You may do so! Then also separate the ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150671146 @borisroman yes, you are right. Should I seperate this PR to two ? --- If your project is set up for it, you can reply to this email and have your reply appear o

Re: [4.6] Can't create template or volume from snapshot

2015-10-23 Thread Mike Tutkowski
I just tried it, though, with managed storage and it doesn't work. Same error of sending the CopyCommand to the wrong server. On Fri, Oct 23, 2015 at 1:25 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > Hi Wei, > > So, I am able to spin up a VM using local storage now on VMware with y

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150670213 @miguelaferreira Could you force push your commit again? So we're all green? :) --- If your project is set up for it, you can reply to this email and have your

Re: [4.6] Can't create template or volume from snapshot

2015-10-23 Thread Mike Tutkowski
Hi Wei, So, I am able to spin up a VM using local storage now on VMware with your PR; however, I still see the following exceptions thrown when I look at the CS MS console: INFO [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-6:ctx-6046512a job-263/job-264 ctx-d61972a5) Unable to contact re

[GitHub] cloudstack pull request: Fix error message in test_isolate_network...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/972#issuecomment-150668944 Ok, here they are: ``` === TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS === ok === TestName: test_RVR_Network_FW_PF_

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-150667050 Verified with curl -v => LGTM :+1: Before: ``` [root@cs1 cloudstack]# curl -v 192.168.22.61:8080/client/ * About to connect() to 192.168.

Re: UI translation for 4.6

2015-10-23 Thread Erik Weber
On Fri, Oct 23, 2015 at 6:11 PM, Milamber wrote: > Hello, > > The new stats for the translations of Web UI 4.6 (languages over 50%): > > French (France) 100% > Portuguese (Brazil) 99% > Japanese (Japan)99% > Chinese (China) 99% > Norwegi

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150665355 @borisroman it fixes one ticket -- it should be one commit. In the grand scheme of the master log, the distinction is not valuable -- it only obfuscates the intent

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-150664161 @remibergsma @wilderrodrigues Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-150663941 @borisroman Thanks, will ask @wilderrodrigues to run some integration tests. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150663033 @DaanHoogland At present, I don't have any way to run SolidFire integration tests inside of the Apache community. Perhaps I can leverage a virtual appliance a

[GitHub] cloudstack pull request: Interface pattern check

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150662232 @borisroman I see your point on the commits. It was done because this combines two existing PRs and @dahn kept the hashes and the authors the same. Can y

[GitHub] cloudstack pull request: Interface pattern check

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150662287 Oh and push again so Jenkins can restart, please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-150662299 Based on code review, LGTM :+1: I haven't spun up a cluster to run integration tests... --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150661801 @jburwell I think it should be 2 commits... They fix 2 different things. The first fixes the Guru issue, while the second one makes it possible to create snapshot

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150660824 This seems like a pragmatic fix for 4.6. In the long term, I am concerns that the method provides an inaccurate view of system state. When no answer is found, it

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Fix KVM snap to vol and ...

2015-10-23 Thread snuf
Github user snuf closed the pull request at: https://github.com/apache/cloudstack/pull/962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150657287 @snuf @remibergsma I like this idea. I actually think we should have this kind behavior everywhere... Here's another example of non-deterministic behavior

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Fix KVM snap to vol and ...

2015-10-23 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/962#issuecomment-150657334 @NuxRo @karuturi Superseded by #975 and in . Closing this one! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Ovm3HypervisorGuru wrong answer and snaps...

2015-10-23 Thread snuf
GitHub user snuf opened a pull request: https://github.com/apache/cloudstack/pull/975 Ovm3HypervisorGuru wrong answer and snapshot to volume implementation. Fixes the wrong answer that is given for host delegation, the snapshot to volume is implemented and a small logger is added to

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-23 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/964#issuecomment-150653911 @remibergsma thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8981 coded a more obscure host...

2015-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/965 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150652979 @remibergsma not for the HypervisorGuru, as they are really specific, It does however conflict with the original idea behind the Gurus if I'm not mistaken, as a Guru is

[GitHub] cloudstack pull request: CLOUDSTACK-8981 coded a more obscure host...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/965#issuecomment-150652749 LGTM, based on a set of tests that I run on this branch: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardwa

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150651411 @snuf, if I understand correctly this PR only calls the Guru of whatever hypervisor you use, and doesn't call the others. I can remember a certain outage that wa

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-150648494 @DaanHoogland I have the same result as @borisroman reports: ``` Deploy DC Started Exception Occurred: ['Traceback (most recent call las

[GitHub] cloudstack pull request: Interface pattern check

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150647352 @DaanHoogland IMHO I think the unit test is a bit inconclusive. It would pass if 8 out of 10 of the possible prefixes were removed And maybe remove th

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150647256 @Nuxro @remibergsma @karuturi by adding a simple log line to the XenServerGuru.java you get the following when doing a snap to vol and a snap to temp: '2015-10-23 1

[GitHub] cloudstack pull request: CLOUDSTACK-8981 coded a more obscure host...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/965#issuecomment-150646084 Compilation and testing went successfull. As it only involved a change of a unit test, I hadn't ran integration tests. ``` Running com.cloud.utils.res

Re: UI translation for 4.6

2015-10-23 Thread Laszlo Hornyak
Hi, Thank you for the reminder! I can not promise it will ever be 100%, but I will review and cleanup the translation. Best regards, Laszlo On Fri, Oct 23, 2015 at 6:11 PM, Milamber wrote: > Hello, > > The new stats for the translations of Web UI 4.6 (languages over 50%): > > French (France)

[GitHub] cloudstack pull request: Update L10N resource files with 4.6 strin...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/974#issuecomment-150642444 Thanks, great stuff @milamberspace ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150642505 @NuxRo @remi it works like a charm and also prevents little accidents from happening. The interesting thing is that the XenserverGuru.java contains the exact same code

[GitHub] cloudstack pull request: Interface pattern check

2015-10-23 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150641877 Agreed. Thanks for taking care of this @DaanHoogland. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Update L10N resource files with 4.6 strin...

2015-10-23 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/974 Update L10N resource files with 4.6 strings from Transifex (20151023) This is a "open" PR until the RC1 for Apache CloudStack. I will updated this PR next week (a

[GitHub] cloudstack pull request: Interface pattern check

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150640879 Nice work @dahn, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150639519 @NuxRo I agree, I want a solution that you, @snuf and @karuturi agree on :-) --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8935 - Cannot remove [r]VPC ne...

2015-10-23 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/967#issuecomment-150638792 Ping @remibergsma @miguelaferreira @DaanHoogland @borisroman More tests: * 2 KVM hosts on CentOS 7.1 * Agent + Common built from source

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150638411 LGTM, build several times and it succeeds. The resulting war now works in tomcat, which is awesome. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread NuxRo
Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150638003 Count it, but @karuturi gave me the impression she was going for a different kind of fix, on the ovm3 side of things, might want to check with her. --- If your projec

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-150638131 @ke4qqq Are you OK with including it in the Developer profile as well. This obviously is not the default build. This would allow for war drop deployments in tomc

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150637364 @NuxRo Thanks! I'll count it as a LGTY? :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Fix error message in test_isolate_network...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/972#issuecomment-150635269 Thanks @miguelaferreira, run the tests and it works fine! LGTM ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_

[GitHub] cloudstack pull request: FIX: Ovm3 physical network traffic labels...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/964#issuecomment-150632854 LGTM, based on a set of tests that I run on this branch (results below). Also looked at the labels and they look fine. Thanks @snuf ! ``` nosetests -

[GitHub] cloudstack pull request: CLOUDSTACK-8935 - Cannot remove [r]VPC ne...

2015-10-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/967#issuecomment-150630220 Cool. Will run the build again with this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

Re: UI translation for 4.6

2015-10-23 Thread Milamber
Hello, The new stats for the translations of Web UI 4.6 (languages over 50%): French (France) 100% Portuguese (Brazil) 99% Japanese (Japan)99% Chinese (China) 99% Norwegian Bokmål (Norway) 99% Hungarian 98% D

[GitHub] cloudstack pull request: Interface pattern check

2015-10-23 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/973 Interface pattern check thsi closes #812 and #966 as well You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack interf

[GitHub] cloudstack pull request: CLOUDSTACK-8935 - Cannot remove [r]VPC ne...

2015-10-23 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/967#issuecomment-150605611 Ping @remibergsma @miguelaferreira @borisroman @DaanHoogland It's now fixed for real! ``` Test create VPC offering ... === TestName: tes

[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...

2015-10-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/971#issuecomment-150604553 @michaelandersen you did not specify `required_hardware=true` are you sure the tests have actually ran? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Fix error message in test_isolate_network...

2015-10-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/972#issuecomment-150602167 I've tested this in a 2 KVM hosts setup (a.k.a [mct-zone1-kvm1-kvm2.cfg](https://github.com/schubergphilis/MCT-shared/blob/master/marvin/mct-zone1-kvm1-kvm2.c

[GitHub] cloudstack pull request: Fix error message in test_isolate_network...

2015-10-23 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/972 Fix error message in test_isolate_network_FW_PF_default_routes While running test_isolate_network_FW_PF_default_routes it is expected that SSH'ing into a VM does not work immediately.

[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...

2015-10-23 Thread atrbgithub
Github user atrbgithub commented on the pull request: https://github.com/apache/cloudstack/pull/925#issuecomment-150595815 Hi Remi, I've forced-pushed the commit (amended the commit message and re-pushed) and it looks like the tests are running once more. I had a look at making a simi

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Fix KVM snap to vol and ...

2015-10-23 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/962#issuecomment-150590628 @NuxRo here's a list, there is no KVM Guru... ? funs@cs-mgmt:~/cloudstack/plugins/hypervisors$ find . -type f -name *.xml | xargs grep -A 1 Guru | grep property | aw

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150588016 @DaanHoogland Sounds good. I'll hold off. Thanks for the help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

Re: [4.6] Can't create template or volume from snapshot

2015-10-23 Thread Boris Schrijver
As long as it's functional logging, GOOD IDEA! > On October 23, 2015 at 4:03 PM Funs Kessen wrote: > > > Perhaps it would be nice to put the logging in all the GURUs so you can > actually see which > ones are used, and how it is used ? > > Cheers, > > Funs > > > On 23 Oct 2015, at 11:21, Wei

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150585840 @dmabry I am already writng a combination. please review when done --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150582452 I'll take a look at #812 and see about combining them into this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

Re: [4.6] Can't create template or volume from snapshot

2015-10-23 Thread Funs Kessen
Perhaps it would be nice to put the logging in all the GURUs so you can actually see which ones are used, and how it is used ? Cheers, Funs > On 23 Oct 2015, at 11:21, Wei ZHOU wrote: > > As I said in previous mail, the request should be sent to > KVMHypervisorGuru, not others. > Mike, can yo

[GitHub] cloudstack pull request: Add agent name in received response

2015-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/936 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Add agent name in received response

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/936#issuecomment-150578738 @remibergsma Did the same :) KVM Basic setup though. Integeration test: smoke/test_vm_life_cycle.py returned all success! LGTM :+1: --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

2015-10-23 Thread pdube
Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/968#issuecomment-150575383 The fix looks like it will work, but it seems like it is just a workaround. Shouldn't the column be updated correctly instead? Either in this method or the oth

[GitHub] cloudstack pull request: Add agent name in received response

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/936#issuecomment-150572549 LGTM, built infra and run this test: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false smoke/test_

[GitHub] cloudstack pull request: smoke/test_internal_lb.py: Fix template n...

2015-10-23 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/971#issuecomment-150571635 ran the following test: ``` nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=../../../mct-zone1-kvm1.cfg -a tags=advanced test

[GitHub] cloudstack pull request: Fix template not ready error

2015-10-23 Thread michaelandersen
GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/971 Fix template not ready error Add wait for template download Refactored template section of services You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Quota

2015-10-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42860960 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status) throws

[GitHub] cloudstack pull request: Quota

2015-10-23 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r42860149 --- Diff: framework/db/src/com/cloud/utils/db/Transaction.java --- @@ -59,4 +59,30 @@ public T doInTransaction(TransactionStatus status) throws RuntimeEx

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-150553777 @DaanHoogland Could you please have a look again? ``` WARN [c.c.a.m.AgentManagerImpl] (StatsCollector-1:ctx-94b6fe0e) Exception while sending java.lan

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150553318 Agreed with @remibergsma, but the code-wise this is a LGTM. One PR which includes #812 as well would be nice. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

2015-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/799#issuecomment-150552760 In the mean while work has been done on CentOS 7 (systemd) so that is not relevant any more. There also is another open issue that needs to address CentOS 7 pack

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

2015-10-23 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/890 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix for CLOUDSTACK-8937 - XenServer migra...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/925#issuecomment-150550247 Hi @atrbgithub thanks for the patch! Can you supply this patch also to master? We can only merge it, if it enters master first (will change soon, but right now t

[GitHub] cloudstack pull request: CLOUDSTACK-8979: add virtio support for C...

2015-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8979: add virtio support for C...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/963#issuecomment-150547987 @remibergsma All green now! LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150546240 See also PR #812 and the comments there. Can anyone combine the two and address the comments in PR #812 please? If it can be done soon, we can merge it in 4.6. T

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Can't create template or...

2015-10-23 Thread NuxRo
Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/954#issuecomment-150545386 I can confirm Wei's modifications fixes my problem. Both operations (create tmpl and create vol from snapshot) succeed with RPMs built from https://github.com/ustcw

  1   2   >