[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-148297173 @remibergsma The fix dose not cover the case of cmdline change when we stop start the router. I said how i intend to fix this and waiting to see if other

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/930#discussion_r42088163 --- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config --- @@ -128,7 +128,14 @@ get_boot_params() { echo $pubkey > /

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/930#discussion_r42088137 --- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config --- @@ -117,7 +117,7 @@ get_boot_params() { if [ ! -e /dev/vport0p1

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-148296716 Hi, one way to fix this as i mentioned earlier is to send some data which will tell us not to wait, using patchviasoket even when we reboot. This will sol

Re: List disk offerings cmd

Hi Patrick, If you remove/expunge a resource (instance,volume,offering, tempalte, etc), it means the resource will not be used any more. Hence, cloudstack will not list this kind of resources in the API response. If you want to disable offering temporarily, you can disable/enable it. If the offer

Re: [SUSPECTED SPAM]new features in 4.6 ?

On 08-Oct-2015, at 6:17 pm, Dustin Wright mailto:dwri...@untangledtechnology.com>> wrote: Any chance VMWare vCenter 6 support will be added? We're limited to 5.5 and I need improved OSX support in 6. A PR was merged on both master and 4.5 branches. I think both upcoming 4.6.0 and 4.5.3 (futur

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-148293227 @karuturi I think we can remove the loop only if we does not support Ubuntu 12.04 and CentOS 6.X any more. This PR LGTM if we assume the virtio port will work

Re: [SUSPECTED SPAM]new features in 4.6 ?

Does this Jira filter make sense? https://issues.apache.org/jira/issues/?filter=12332938 That's the list of new feature I was to use for the Release Notes, will also add Raja's comments. PL On Fri, Oct 9, 2015 at 8:09 AM, Dustin Wright < dwri...@untangledtechnology.com> wrote: > Raja, > > Thank

Re: [ACS460] QA days (part one)

That works for me. On Wednesday, October 14, 2015, Pierre-Luc Dion wrote: > Does anybody would be interested to participate to a global QA days for the > coming release 4.6.0 ? > > The idea would be to do a full day hackathon (remote or via User Groups) on > testing of ACS 4.6.0 by using availab

[ACS460] QA days (part one)

Does anybody would be interested to participate to a global QA days for the coming release 4.6.0 ? The idea would be to do a full day hackathon (remote or via User Groups) on testing of ACS 4.6.0 by using available online tools such as IRC, slack, GoToMeeting if we have access to one. so I would

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-148210912 @kstreckx There remain overly broad catches of Exception, and in some instances, ignoring of exceptions that must be addressed before merge. We also need the equal

Re: List disk offerings cmd

Thanks ilya. Yeah, I can still see them in the db, but I was wondering if they weren't exposed for a specific reason. I think it would be useful to either be able to see deleted disk/service offerings or to be able to disable them, like with network offerings, and filter them that way. Opinions? C

Re: List disk offerings cmd

Patrick As you may know, nothing is deleted in cloudstack db (for the most part), hence records are still accessible via direct db query. I'm not aware of any API call that would show Deleted disk offerings, though, but should not be too hard to implement.. Regards ilya On 10/14/15 10:41 AM, Pa

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r42049470 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +507,341 @@ public boolean deleteNua

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/933 Refactored & Added Internal LB smoke test Added 1VPC 2TIER internal lb roundrobin test Added 1VPC 1TIER internal lb admin stats test Refactored existing test Thanks @wilderrod

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-148146012 @DaanHoogland We shouldn't merge without running some functional tests. Can you run some please? --- If your project is set up for it, you can reply to this ema

Re: 4.6 release

Hi Paul, Yes, we should fix it. CentOS 7 for KVM hypervisors was also recently fixed. Someone opened a PR to fix the issue you describe: https://github.com/apache/cloudstack/pull/888/files Except for the fact that I tested the PR and it still fails. Do you have time to look into this and propo

[GitHub] cloudstack pull request: Usage event fixes for deleted accounts

Github user nnesic commented on the pull request: https://github.com/apache/cloudstack/pull/924#issuecomment-148138708 I added two unit tests to check that the account manager adheres to its new responsibility of emitting the usage events for root volumes of instances which were not i

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-148136391 @KrisSterckx Once @jburwell is happy with the code and gives his OK, I can run some tests again to check the integration. Shortly before that I might ask you to

List disk offerings cmd

Is there any way to list all disk offerings (via the API), even those that were deleted? If not, is there any particular reason why? Thanks, Patrick

[GitHub] cloudstack pull request: CLOUDSTACK-8923: Do not send zoneId with ...

Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/911 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-148123443 @remibergsma @jburwell thanks for all help and detailed review. Most comments have been addressed. Could we set for the remaining ones to take in next release? T

Build failed in Jenkins: build-master-jdk18 #366

See Changes: [wrodrigues] CLOUDSTACK-8947 - FW_EGRESS should be added only to filter table [wrodrigues] CLOUDSTACK-8947 - Open the input chain to IP when loadbalancer is configured [wrodrigues] CLOUDSTACK-8947 - Avoid multiple

TransactionContextInterceptor Keeps Releasing My Lock

I'm using the DAO API to create a lock in the lock table as per https://cwiki.apache.org/confluence/display/CLOUDSTACK/Data+Access+Layer. However, the lock seems to mysteriously vanish after acquireInLockTable or lockInLockTable method returns. Looking at the code, I've discovered that TransactionC

[GitHub] cloudstack pull request: CLOUDSTACK-8947 - Load Balancer not worki...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/931 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8947 - Load Balancer not worki...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/931#issuecomment-148107806 @wilderrodrigues based on below results LGTM. ``` echo "Running tests with required_hardware=true" nosetests --with-marvin --marvin-config=${marvi

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r42005230 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java --- @@ -0,0 +1,70 @@ +// +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-148077678 I think this issue is happening due to the outer while loops which got introduced in commit 50d756e87d26f0ac86e7897505ad2747735c4d5c The outer loop waits until c

[GitHub] cloudstack pull request: CLOUDSTACK-8947 - Load Balancer not worki...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/931#issuecomment-148070945 Thanks, @karuturi ! Will push a new PR today with more fixes. This time for the redundant VPC. Cheers, Wilder --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/932#discussion_r41998154 --- Diff: pom.xml --- @@ -73,7 +73,7 @@ 1.9.2 1.0.0-build217 2.6.9 -1.7.2 +[2.4,) --- End diff -- Our

Re: 4.6 release

Ladies & Gents, I've just tried installing the current 4.6 from Jenkins on CentOS 7 it fails to start the management service completely (Failed at step EXEC spawning /usr/sbin/tomcat-sysd: No such file or directory) I've updated https://issues.apache.org/jira/browse/CLOUDSTACK-8812 as CentOS 7

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41994256 --- Diff: plugins/network-elements/nuage-vsp/pom.xml --- @@ -28,6 +28,13 @@ 4.6.0-SNAPSHOT ../../pom.xml + + +

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41994074 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,60 @@ +// +// Licensed to t

[GitHub] cloudstack pull request: CLOUDSTACK-8947 - Load Balancer not worki...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/931#issuecomment-148048131 Hi @wilderrodrigues I ran all the tests in smoke folder(BVT) on a setup with 2 xenserver 6.5 hosts in advanced zone. All the tests passed except the below (

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990190 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990136 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java --- @@ -21,10 +21,10 @@ public interface Nuag

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990147 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java --- @@ -24,13 +24,18 @@ public interface

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990169 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Col

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990160 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Col

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990209 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990215 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspSyncClient.java --- @@ -21,7 +21,7 @@ public interface Nuage

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990201 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990195 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990167 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Col

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990174 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspGuruClient.java --- @@ -21,24 +21,22 @@ import java.util.Col

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990182 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspManagerClient.java --- @@ -0,0 +1,41 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990152 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java --- @@ -24,13 +24,18 @@ public interface

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990144 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspApiClient.java --- @@ -21,10 +21,10 @@ public interface Nuag

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990154 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/client/NuageVspElementClient.java --- @@ -24,13 +24,18 @@ public interface

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41990041 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java --- @@ -19,28 +19,86 @@ package net.nuage.v

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989984 --- Diff: plugins/network-elements/nuage-vsp/src/net/nuage/vsp/acs/NuageVspPluginClientLoader.java --- @@ -19,28 +19,86 @@ package net.nuage.v

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989892 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -437,31 +463,79 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989878 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -437,31 +463,79 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989853 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -424,9 +449,10 @@ private Answer executeRequest(

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989863 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -437,31 +463,79 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/932 CLOUDSTACK-8708: gson update and ArrayTypeAdaptor rewrite unit test for RequestTest is passing in eclipse. On macosx 10.11 using java 1.8 or 1.7 it fails from the command line. You can mer

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989738 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -424,9 +449,10 @@ private Answer executeRequest(

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989725 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -393,9 +401,10 @@ private Answer executeRequest(

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989708 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -360,32 +375,25 @@ private Answer executeReques

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989728 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -403,20 +412,36 @@ private Answer executeRequest

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/930#issuecomment-148042852 @bvbharatk Thanks for the PR, I'll test it today or tomorrow. Did you run the BVT tests that reboot the cpm and ssvm? If not, please do. If you did, please po

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/930#discussion_r41989612 --- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config --- @@ -128,7 +128,14 @@ get_boot_params() { echo $pubkey >

[GitHub] cloudstack pull request: CLOUDSTACK-8933 SSVm and CPVM do not surv...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/930#discussion_r41989516 --- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config --- @@ -117,7 +117,7 @@ get_boot_params() { if [ ! -e /dev/vport0

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41989312 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -360,32 +375,25 @@ private Answer executeReques

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41988797 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -262,15 +260,19 @@ public String getName() {

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41988458 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +525,345 @@ public boolean deleteNuag

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41988188 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +525,345 @@ public boolean deleteNuag

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41988124 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -247,6 +467,26 @@ public boolean deleteNuageV

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-148038282 LGTM indeed! @remibergsma and @karuturi can you please merge this one in your next batch? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41988014 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41987892 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41987775 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41987747 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41986962 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41986950 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41986904 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41986636 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41986564 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41986510 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,50 +243,179 @@ public NuageVspDeviceVO a

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41985759 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -122,13 +213,13 @@ cmdList.add(De

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41985628 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -109,12 +163,49 @@ @Inject V

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41985416 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -109,12 +163,49 @@ @Inject V

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41985327 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -67,25 +74,76 @@ import com.cloud.network

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41984914 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +442,28 @@ private String getVirtual

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41984944 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +442,28 @@ private String getVirtual

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41984374 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -322,35 +389,52 @@ public void shutdown(Netw

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41983983 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +134,94 @@ public Network design(Net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41983905 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +134,94 @@ public Network design(Net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41981328 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +134,94 @@ public Network design(Net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41981224 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -114,7 +117,9 @@ public Network design(Netwo

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41980525 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -447,13 +568,95 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41980490 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -368,18 +492,15 @@ public boolean applyStaticNats(

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41980442 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -303,13 +422,17 @@ protected boolean canHandle(Net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41980395 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -205,9 +254,79 @@ public boolean implement(Network

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41979565 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceAnswer.java --- @@ -0,0 +1,41 @@ +// +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41979581 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncVspAnswer.java --- @@ -31,4 +31,13 @@ public SyncVspAnswer(SyncVspCommand c

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41979553 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,60 @@ +// +// Licensed to th

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41979466 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspAnswer.java --- @@ -31,4 +31,14 @@ public DeallocateVmVspAnswer(

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41979446 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionAnswer.java --- @@ -0,0 +1,43 @@ +// +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r41979480 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspAnswer.java --- @@ -31,4 +31,13 @@ public ApplyAclRuleVspAnsw

  1   2   >