[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/786 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cloudstack pull request: CLOUDSTACK-5863: Add unit tests for volum...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/796 CLOUDSTACK-5863: Add unit tests for volume snapshot You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweizhou/cloudstack unit-tests-fo

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/780#issuecomment-139109578 I see tests only for LibrvirtResource. They are missing for StatsCollector, CitrixResourceBase, VmwareResource --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/780#discussion_r39122432 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -4662,8 +4663,14 @@ private VirtualMachineGuest

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/780#discussion_r39122397 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -189,6 +190,7 @@ private long _hvV

CloudStack dockerization

Hi, There was some questions on Tweeter around dockerization state of CloudStack. So far all the progress and Design spec is in this wiki page [1]. So far we have the simulator container automatically build from 3 branches, cloudstack-management on centos6 container build from master branch, clo

Re: [DISCUSS] Let's fix CloudStack Upgrades and DB migrations with CloudStack Chimp

+1 and also aligned with Wido for a 5.0 including DB change + Java 8. Great work for the Design document introduction Rohit! On Mon, Aug 31, 2015 at 6:47 PM, Rene Moser wrote: > +1! > > On 08/28/2015 08:51 AM, Rohit Yadav wrote: > > Hi all, > > > > Some of us have discussed in the past on fi

Re: ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

Andrija, The Ceph snapshot deletion is not currently implemented. See: https://issues.apache.org/jira/browse/CLOUDSTACK-8302 - Si From: Andrija Panic Sent: Wednesday, September 9, 2015 3:03 PM To: dev@cloudstack.apache.org; us...@cloudstack.apache.org S

ACS 4.5 - volume snapshots NOT removed from CEPH (only from Secondaryt NFS and DB)

Hi folks, we enounter issue in ACS 4.5.1 (perhaps other versions also affected) - when we delete some snapshot (volume snapshot) in ACS, ACS marks it as deleted in DB, deletes from NFS Secondary Storage but fails to delete snapshot on CEPH primary storage (doesn even try to delete it AFAIK) So we

RE: [Blocker/Critical] VR related Issues

Here is an update on the Automation being run on master - currently, passrates look pretty bad. I am still in the process of creating/correlating existing defects to the failures. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Automation+Results+-+Release+4.6.0 BTW, majority of the

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/794#discussion_r39085814 --- Diff: core/src/com/cloud/storage/template/LocalTemplateDownloader.java --- @@ -159,16 +159,4 @@ public long download(boolean resume, DownloadCompl

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/794#discussion_r39081547 --- Diff: core/src/com/cloud/storage/template/LocalTemplateDownloader.java --- @@ -159,16 +159,4 @@ public long download(boolean resume, DownloadCom

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-139001822 @DaanHoogland True that. But then the discussion arises; until there are Unit Tests , do we keep this useless code? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/795#issuecomment-139001500 Tested manually. Virtual size is correctly returned now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8819: Added QCOW2 virtual size...

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/795 CLOUDSTACK-8819: Added QCOW2 virtual size checking for S3. - Cleaned up S3TemplateDownloader - Created static QCOW2 utils class. - Reformatted some parts of DownloadManagerImpl You ca

Jenkins build is back to normal : build-master-jdk18 #340

See

Re: Dynamic Scalable Template issue

Vadium, Yes to both with the new tools from XS62ESP1028. Both Windows and CentOS have ‘Dynamic Scalable’ Option selected and in XenCenter they show the correct RAM. Todd Pigram http://about.me/ToddPigram www.linkedin.com/in/toddpigram/

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user maneesha-p commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/780#discussion_r39034863 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -4751,7 +4760,7 @@ private VirtualMachineGues

[GitHub] cloudstack pull request: CLOUDSTACK-8781 : Superfluous field durin...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/756#issuecomment-138889654 Hi @nlivens Okay... I will have a look at the code. Very weird to have it there and not use it. :) Cheers, Wilder --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/788 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/788#discussion_r39034047 --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java --- @@ -610,20 +608,22 @@ protected HypervisorType getClusterToStartDomainRou

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138889015 Will proceed with the merge. Thanks, guys! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39033655 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -95,9 +95,17 @@ def get_control_if(self): return ip

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138887396 My issue is also gone, so LGTM from me as well. Thanks for fixing this. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138887313 @koushik-das They have been different for a long time. I think when VPC was invented, they reordered the nics so that the tiers came last (because you can have N

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-138885057 Hi @wilderrodrigues will update once i am done testing against vpc networks. --- If your project is set up for it, you can reply to this email and have y

[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change while configur...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/791#issuecomment-138880396 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-138872339 @nitin-maharana, when I said that the String concatenation there might make ACS vulnerable to SQL injection attacks, I did not mean that your PR did that.

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

On 09 Sep 2015, at 12:14, koushik-das mailto:g...@git.apache.org>> wrote: One more doubt. Why the ordering of interfaces are different in regular VR and VPC VR? Has it changed recently or was like this since the beginning? And will it cause more issues down the line when VR or VPC VR scripts a

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138865017 One more doubt. Why the ordering of interfaces are different in regular VR and VPC VR? Has it changed recently or was like this since the beginning? And will it

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138861606 Other than one minor comment, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/788#discussion_r39025559 --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java --- @@ -610,20 +608,22 @@ protected HypervisorType getClusterToStartDomainRouterF

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-138858662 @borisroman I would like to see all the test-main removed as well but not without moving the actual test code into unit tests --- If your project is set up for

[GitHub] cloudstack pull request: Removal of test/debug code.

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/794#issuecomment-138855244 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138851642 I've tested the patch as well since I was hitting the exact same issue. All is working fine, and interfaces are configured correctly. :+1: --- If your project is se

[GitHub] cloudstack pull request: Removal of test/debug code.

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/794 Removal of test/debug code. Removed main() method from LocalTemplateDownloader.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/borisr

[GitHub] cloudstack pull request: CLOUDSTACK-8814 - Refactoring the configu...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/788#issuecomment-138846797 I tested the patch, now isolated network VR is coming up and the interfaces are configured in correct order. eth0 - guest eth1 - link local eth2

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/793 CLOUDSTACK-8827: Move the VM snapshots stuck in transitional states to stable states during managment server restart i.e. If snapshot in creating state move it to Error state and if it i

[GitHub] cloudstack pull request: CLOUDSTACK 8819: Return correct template ...

Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Build failed in Jenkins: build-master-jdk18 #339

See Changes: [jayapal] CLOUDSTACK-8690:Added remote access vpn and vpn users configuration [Vincent.Bernat] sysctl: don't modify /etc/sysctl.conf [jayapal] CLOUDSTACK-8690: Updated the iptables order --

[GitHub] cloudstack pull request: CLOUDSTACK 8819: Return correct template ...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/789#issuecomment-138829516 We don't need an external script for this. The QemuImg tools we already have in place can do this for you. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/784#discussion_r39018553 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py --- @@ -95,9 +95,17 @@ def get_control_if(self): return ip

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/776 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138822497 I went through the file history and it has been like this since when it was pushed (back in 2012). The change makes sense and the explanations given about ha

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/792#issuecomment-138819369 I had to undo changes from PR https://github.com/apache/cloudstack/pull/773 to run the tests. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8799 fixed the defalut routes

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/784#issuecomment-138818591 Hi @bvbharat , Any news on this PR? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cloudstack pull request: CLOUDSTACK-8690:Added remote access vpn a...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/772 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/792 CLOUDSTACK-8826: XenServer - Use device id passed as part of attach v… …olume API properly If device id passed as part of API and available then use it otherwise fallback on XS

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-138810904 Yes, It can be possible. But I have not hard-coded this change, I followed the way sql queries are generated everywhere. This way of generating SQL query is f

[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change while configur...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/791 CLOUDSTACK-8821: UI Change while configuring firewall rule. It provides appropriate message in the UI when configuring the firewall rules in Network page. If the default egress policy