I changed it to critical. It is only a blocker if we agree on this
list that it is.
On Thu, Jul 30, 2015 at 6:44 AM, Sanjeev N wrote:
> Hi,
>
> In latest ACS builds, the ip table rules in VR have ACCEPT as the default
> policy in INPUT and FORWARD chains, instead of DROP.
>
> Created a blocker bu
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126204154
Fair enough, @DaanHoogland
Thanks for the exaplanation. :)
LGTM :+1:
---
If your project is set up for it, you can reply to this email an
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126202911
@koushik-das, Ignoring interrupted exceptions means that you do not allow
the user or other threads to interrupt you. To me that seems serious. I did not
in any
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126200897
Hi @DaanHoogland
Nice you took time to have a look at those. It really helps sys admins to
know what is going on with ACS. However, I would rather h
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-126196695
Awesome, thanks!
Cheers,
Wilder
Sent from my iPhone
On 30 Jul 2015, at 07:22, kishankavala
mailto:notificati...@github.com>> wr
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-126186427
Hi @wilderrodrigues,
@sanjeevneelarapu filed ticket for "default policy ACCEPT" issue.
https://issues.apache.org/jira/browse/CLOUDSTACK-8688
---
If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126185823
Since all these "ignore" messages are logged at INFO level, it needs to be
ensured that logs are not getting filled up too soon. Also I see lot of
instances for
Hi,
In latest ACS builds, the ip table rules in VR have ACCEPT as the default
policy in INPUT and FORWARD chains, instead of DROP.
Created a blocker bug for this issue
https://issues.apache.org/jira/browse/CLOUDSTACK-8688
Can somebody please fix it?
Thanks,
Sanjeev
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/637#issuecomment-126094297
@wilderrodrigues @wido @bhaisaab @rajesh-battala @koushik-das @kishankavala
@K0zka
I am taking this by exception type now so this is going to give conflicts
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/637
Cloudstack 8656
filling empty catch clauses with log messages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack CL
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/636#issuecomment-126047538
does every version of nvp support vxlan?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Hi Miguel,
I appreciate your willingness to help - thanks!
As it turns out, however - and you may have read this in a subsequent
e-mail after you sent yours, I was able to perform a rebase without issue
by switching over to another dev machine.
I don't know if it was due to switching the OS Git
On 28-07-15 04:51, Pierre-Luc Dion wrote:
> Hi,
>
> I've create this jira filter[1] for the Release Manager, based on it, there
> would be only 4 maybe just 3 blockers on 4.6. Based on this, should we
> consider placing a target date for RC1 somewhere like end of August ?
>
Well, the S3 is sti
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/636#issuecomment-125961987
@sspans any testing done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
GitHub user sspans opened a pull request:
https://github.com/apache/cloudstack/pull/636
Update NiciraNvpGuestNetworkGuru.java
Add support for VXLAN as isolation method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sspans/cloudst
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/635#issuecomment-125917105
please add unit- or integration tests. for instance for prepareTemplate,
prepareTemplateInOneStoragePool and prepareTemplateInAllStoragePools to show
that expec
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125915603
Awesome! Thanks a lot, @karuturi and @kishankavala
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have yo
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125915281
Thanks @wilderrodrigues
I merged https://github.com/apache/cloudstack/pull/634/
I'll created separate ticket to track "default policy ACCEPT" issue.
-
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/634
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/634#issuecomment-125912564
@wilderrodrigues agreed. we can take it up as a new issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/634#issuecomment-125912381
LGTM :+1:
@karuturi, should we perhaps create an issue to follow up on this? I think
we should refactor the early-config a bit and, as you mentioned
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/634#issuecomment-125910552
looks good :+1: but, should this processing be part of the
setup_[router|vpcrouter|dhcpserver] itself?
---
If your project is set up for it, you can reply to this
GitHub user devdeep opened a pull request:
https://github.com/apache/cloudstack/pull/635
CLOUDSTACK-8687: Prepare template only on a given storage pool
Update prepare template api to seed/prepare a template only on a given
primary storage. Currently, the prepare template api will se
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35743142
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,185 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Hi Mike,
I’m willing to help you with this, but the easiest way would be for you to
point me to the repo you are working on.
This way I could actually see what’s going on.
Anyway, from your description, all the files might be new in your modified
branch, but a file with the same name might have
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/633
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/633#issuecomment-125896500
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/633#issuecomment-125896323
Thanks, @DaanHoogland!
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/634#issuecomment-125895559
Awesome, @kishankavala!
Will wait for the build/travis to vote/merge it.
Cheers,
Wilder
---
If your project is set up for it, you can r
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125894943
Hi @kishankavala
Let's try to focus on 1 change at a time:
1. the port 3922 is blocked
2. default policy ACCEPT
So, the changes
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125890106
@wilderrodrigues iptables issue is not specific to dhcpsrvr (shared VR). On
isolated VR also default policy is ACCEPT
```
root@r-23-VM:~# iptables -L -nv
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/634
CLOUDSTACK-8683: process cmd_line.json for shared network VR in
cloud-early-config
- SSH access on link_local_ip is blocked for shared VR
- MS is unable to program rules on VR. Vm deplo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125889027
Hi @kishankavala,
If it doesn't match the content of rules.v4 perhaps the iptables-save is
not being called when dhcpsrvr.
By adding the cha
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/632#issuecomment-125886503
LGTM except one small change suggested.
Please don't mix intended changes and pep8 fixes, you can add another
review request for pep8 fixes subsequently. Th
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/632#discussion_r35739964
--- Diff: test/integration/smoke/test_snapshots.py ---
@@ -123,65 +126,78 @@ def test_01_snapshot_root_disk(self):
#the reqd volume
Github user manasaveloori commented on the pull request:
https://github.com/apache/cloudstack/pull/632#issuecomment-125886157
@DaanHoogland
This is just an enhancement to existing test in the script.
The output is from nose test result of the script.
---
If your project is se
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/632#issuecomment-125884841
@manasaveloori can you give us the command to which this output fits?
@gauravaradhye can you review this, please? (looks like a lot of code to me)
---
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/633
unittesting: test resolution is not guaranteed to be exact
a lot of validation pull requests are failing over this test. It should
pass but it's failure is environmental in any observed cas
GitHub user manasaveloori opened a pull request:
https://github.com/apache/cloudstack/pull/632
Added a test to verify that listSnapshots response returns zone id
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk |
Status : SUCCESS ===
ok
-
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125882216
Sure @wilderrodrigues
I'll create a PR.
But iptables rules are more open now (default ACCEPT).
root@r-30-VM:~# iptables -L INPUT -nv
Chain
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125878438
Nice catch, @kishankavala !
I checked the history of the file and found out that the changes for VPC
router and normal router were added in the commi
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/631#issuecomment-125875443
I can only judge this on code cleanliness. An added pep8 pull request
builder might help;) @pritisarap12 please solicit review from test experts that
have acces
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/630#issuecomment-125874159
@manuiiit your change has checkstyle error, can you look at these? (at
least I see tabs instead of spaces)
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/607#issuecomment-125873205
thanks @koushik-das , as the test issue is being addressed now please don't
let it block this PR
---
If your project is set up for it, you can reply to this em
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125864299
@wilderrodrigues
Below changes fixed the issue but not sure if it breaks anything else:
kk-cloudstack > git diff
diff --git a/systemvm/patches/de
46 matches
Mail list logo
