[GitHub] cloudstack pull request: CLOUDSTACK-8566: Filter sensitive details...

2015-06-30 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/536#discussion_r33651106 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java --- @@ -203,9 +201,22 @@ public void execute() { ho

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-06-30 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/535#issuecomment-117444526 @wilderrodrigues Guava provides [EqualsTester](http://guava-libraries.googlecode.com/svn-history/r144/trunk/javadoc/com/google/common/testing/EqualsTester.html) to

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-06-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/535#discussion_r33650706 --- Diff: framework/config/src/org/apache/cloudstack/framework/config/ConfigKey.java --- @@ -122,6 +122,13 @@ public boolean equals(Object obj) {

[GitHub] cloudstack pull request: findbugs: impossible cast(s) fixed by cha...

2015-06-30 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/538#issuecomment-117444046 Hi @DaanHoogland @K0zka als added a unit tests to cover his changes. Check this class: CreateSecondaryStagingStoreCmdTest Any chance to get

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-06-30 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/531#issuecomment-117443894 changes looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

2015-06-30 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/547 CLOUDSTACK-8601. VMFS storage added as local storage can be re-added … …as shared storage. Fail addition of a VMFS shared storage pool in case it has already been added as local sto

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-06-30 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/535#issuecomment-117443363 Hi @DaanHoogland What about unit tests for the classes that were changed, are those already in place? A bunch of well written unit tests wo

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-06-30 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/531#issuecomment-117441816 @runseb @DaanHoogland @remibergsma Does this one needs 2 LGTM as well? I'm willing to close a few PRs. Cheers, Wilder --- If

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-06-30 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/531#issuecomment-117441768 LGTM I executed the command on one of my machines and it's fine - although my eyes could already see it was. Result: [wrodrigues@mc

[GitHub] cloudstack pull request: CLOUDSTACK-8566: Filter sensitive details...

2015-06-30 Thread serverchief
Github user serverchief commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/536#discussion_r33648388 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java --- @@ -203,9 +201,22 @@ public void execute() {

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8590 Refactoring NiciraNVP res...

2015-06-30 Thread Wilder Rodrigues
Hey guys, Anyone willing to have a look at this PR? Thanks in advance. Cheers, Wilder Sent from my iPhone > On 30 Jun 2015, at 14:41, wilderrodrigues wrote: > > GitHub user wilderrodrigues opened a pull request: > >https://github.com/apache/cloudstack/pull/546 > >CLOUDSTACK-8590 Re

[GitHub] cloudstack pull request: CLOUDSTACK-8566: Filter sensitive details...

2015-06-30 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/536#discussion_r33625103 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java --- @@ -203,9 +201,22 @@ public void execute() { ho

Re: Travis-ci build timeout error.

2015-06-30 Thread Rafael Fonseca
Hi Jayapal, I took a quick look at your branch and there are problems in your implementation, that's why it doesn't start up: Error creating bean with name 'userVmManagerImpl' defined in URL [jar:file:/root/.m2/repository/org/apache/cloudstack/cloud-server/4.6.0-SNAPSHOT/cloud-server-4.6.0-SNAPSH

Re: 4.4.4 RPMs not on repo

2015-06-30 Thread Francois Gaudreault
Oh I see. I misunderstood the concept then :) I went ahead with ShapeBlue's repo. Thanks! FG On 2015-06-30 4:00 PM, Erik Weber wrote: Currently there are no "official" packages or templates AFAIK, only source code. apt-get.eu is a courtesy from Wido (IIRC), whilst shapeblue.com obviously com

Re: 4.4.4 RPMs not on repo

2015-06-30 Thread Erik Weber
Currently there are no "official" packages or templates AFAIK, only source code. apt-get.eu is a courtesy from Wido (IIRC), whilst shapeblue.com obviously comes from them. -- Erik On Tue, Jun 30, 2015 at 9:56 PM, Will Stevens wrote: > I think he is looking for the templates based on the offic

Re: 4.4.4 RPMs not on repo

2015-06-30 Thread Will Stevens
I think he is looking for the templates based on the official 4.4.4 commit. I am not sure of the official templates are the ones on Jenkins or not: http://jenkins.buildacloud.org/view/4.4/ I personally find this a bit confusing. Obviously the shapeblue templates are not the official ACS template

Re: 4.4.4 RPMs not on repo

2015-06-30 Thread Francois Gaudreault
The apt-get.eu one. FG On 2015-06-30 3:42 PM, Rohit Yadav wrote: On 30-Jun-2015, at 9:42 pm, Rohit Yadav wrote: why typo, *why -> which Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out mor

Re: 4.4.4 RPMs not on repo

2015-06-30 Thread Rohit Yadav
> On 30-Jun-2015, at 9:42 pm, Rohit Yadav wrote: > > why typo, *why -> which Regards, Rohit Yadav Software Architect, ShapeBlue M. +91 88 262 30892 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services

Re: 4.4.4 RPMs not on repo

2015-06-30 Thread Rohit Yadav
> On 30-Jun-2015, at 9:31 pm, Francois Gaudreault > wrote: > > Hi Folks, > > Looks like the 4.4.4 RPMs are not published on the upstream repository yet. > Is this expected? Not sure why upstream repository you were looking at, I’ve published them in these rpm/deb upstream repos: http://packag

4.4.4 RPMs not on repo

2015-06-30 Thread Francois Gaudreault
Hi Folks, Looks like the 4.4.4 RPMs are not published on the upstream repository yet. Is this expected? Thanks! -- Francois Gaudreault Gestionnaire de Produit | Product Manager - Cloud Platform & Services t:514-629-6775 CloudOps Votre partenaire infonuagique | Cloud Solutions Experts 420 rue

RE: Windows Template Startup time

2015-06-30 Thread prashant priyam
Hi Timothy, Please fine the attached CSV for io performance report of VM . I have generated it with tool called iometer. With warm regards,Prashant Priyam(+91-8802955489)http://in.linkedin.com/in/prashantpriyam > From: tlother...@datacentrix.co.za > To: us...@cloudstack.apache.org; dev@clouds

[GitHub] cloudstack pull request: As an operator I want to be able to chang...

2015-06-30 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/527#issuecomment-117186219 As long as people make good commits, that are atomic, capture relevant changes together, and have descriptive messages, IMHO squashing only make things worse

[GitHub] cloudstack pull request: CLOUDSTACK-8590 Refactoring NiciraNVP res...

2015-06-30 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/546 CLOUDSTACK-8590 Refactoring NiciraNVP resource Hi there, The motivation behind the refactor of the NiciraNvpResource class was to decouple the execute of the commands, which was

[GitHub] cloudstack-cloudmonkey pull request: Dockerfile

2015-06-30 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/7#issuecomment-117162274 Files updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack-cloudmonkey pull request: Dockerfile

2015-06-30 Thread pdion891
Github user pdion891 commented on a diff in the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/7#discussion_r33566260 --- Diff: Dockerfile --- @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: Travis-ci build timeout error.

2015-06-30 Thread Jayapal Reddy Uradi
Hi Rafael, I have merged the changed and added branch in ACS. But there are time out issue. Travis-ci job: https://travis-ci.org/apache/cloudstack/jobs/68765082 Branch: https://github.com/apache/cloudstack/tree/dhcpoffload Thanks, Jayapal On 26-Jun-2015, at 5:57 PM, Rafael Fonseca mailto:rsaf

[GitHub] cloudstack pull request: CLOUDSTACK-8600. Upon detaching a disk, d...

2015-06-30 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/545 CLOUDSTACK-8600. Upon detaching a disk, delete VM folder if empty. You can merge this pull request into a Git repository by running: $ git pull https://github.com/likitha/cloudstack CLOUDS

RE: Windows Template Startup time

2015-06-30 Thread prashant priyam
Hi Timothy, I have installed xen tools on before converting it to template. With warm regards,Prashant Priyam(+91-8802955489)http://in.linkedin.com/in/prashantpriyam > From: tlother...@datacentrix.co.za > To: us...@cloudstack.apache.org; dev@cloudstack.apache.org > Subject: RE: Windows Templat

RE: Windows Template Startup time

2015-06-30 Thread prashant priyam
Reboot from ACS UI With warm regards,Prashant Priyam(+91-8802955489)http://in.linkedin.com/in/prashantpriyam > Date: Mon, 29 Jun 2015 16:17:08 +0200 > Subject: Re: Windows Template Startup time > From: andrija.pa...@gmail.com > To: us...@cloudstack.apache.org > CC: dev@cloudstack.apache.org >

[GitHub] cloudstack pull request: CLOUDSTACK-8598. CS reports migration as ...

2015-06-30 Thread likitha
Github user likitha commented on the pull request: https://github.com/apache/cloudstack/pull/542#issuecomment-117069118 Yes, since migration is only one of the many affected operations, it seemed appropriate to merge it with https://github.com/apache/cloudstack/pull/543. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8599. CS reports failure for a...

2015-06-30 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/544 CLOUDSTACK-8599. CS reports failure for a successful migration. While cancelling a vCenter task, check if the task is cancellable and wait for the task to complete. You can merge this pull requ

RFH: CLOUDSTACK-6276: project support in affinitygroups

2015-06-30 Thread Rene Moser
Hi I started to work on adding project support in affinity groups. You can see the commits in a PR https://github.com/apache/cloudstack/pull/508. There is still some work to do like fix current unit test and adding new unit test and test it generally. I don't feel I can work on it for the next

[GitHub] cloudstack pull request: CLOUDSTACK-8598. CS reports migration as ...

2015-06-30 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/542#issuecomment-117063526 you closed this in favor of #543 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-8598. CS reports volume migrat...

2015-06-30 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/543 CLOUDSTACK-8598. CS reports volume migration as successful but the vo… …lume is not migrated in vCenter.. For the following disk operations - migration, snapshot creation, resize, d

[GitHub] cloudstack pull request: CLOUDSTACK-8598. CS reports migration as ...

2015-06-30 Thread likitha
Github user likitha closed the pull request at: https://github.com/apache/cloudstack/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8598. CS reports migration as ...

2015-06-30 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/542 CLOUDSTACK-8598. CS reports migration as successful but the volume is… … not migrated in vCenter. During migration, CS should do an exact disk match between volume path and vCenter

[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-06-30 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/541 CLOUDSTACK-8597. Failed to migrate volume from zone-wide to cluster-w… …ide storage. While live migrating a volume, CS chooses the endpoint to perform the migration by selecting any