Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

2013-08-25 Thread Daan Hoogland
You are right, I incorporated Alex' auto format for eclipse. Sorry for that. Being sick at home today, I will try to submit an update without it tomorrow. regards, On Mon, Aug 26, 2013 at 6:04 AM, Dave Cahill wrote: > Hi Daan, > > I started to take a look - the diff is ~10k lines long, most o

Re: [ACS42] Closing resolved issues

2013-08-25 Thread Nitin Mehta
Sudha - I understand, but its always better that another pair of eyes look into it. The fixer has already verified the fix when he/she is committing it but devs are always biased or looking for happy cases only :). I have numerous bugs filed against myself as well, so better someone else verifies

Re: registerSSHKeyPair

2013-08-25 Thread Harikrishna Patnala
I have created a bug ticket for tracking https://issues.apache.org/jira/browse/CLOUDSTACK-4493 and this needs to be resolved. -Harikrishna On 23-Aug-2013, at 6:41 PM, Chip Childers wrote: > On Thu, Aug 22, 2013 at 08:33:42AM -0400, Sebastien Goasguen wrote: >> >> On Aug 22, 2013, at 7:57 AM,

Re: System VMs not running

2013-08-25 Thread Amit Das
Thanks Nitin. This helped. Setting the verbose mode & running the script manually showed me 'Permission Denied' error on vhd-util file. I had to change the permission on vhd-util for things to work. Regards, Amit *CloudByte Inc.* On Fri, Aug 23, 2013 at 3:56 PM, Nit

Review Request 13803: CLOUDSTACK-4491: Added NS setup

2013-08-25 Thread Sowmya Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13803/ --- Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhan

Re: Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

2013-08-25 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13800/#review25533 --- Commit bc5b6ae0e41a04ab2c892ce53199c1d7f1d0902c in branch refs/head

Re: Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

2013-08-25 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13800/#review25532 --- Commit f724c912969fb4c6fcfe02d48d31afcd82480b43 in branch refs/heads

Re: Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

2013-08-25 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13800/#review25531 --- Ship it! - Prasanna Santhanam On Aug. 25, 2013, 5:10 p.m., Sowmya

Re: System VM stuck in Expunging State

2013-08-25 Thread Mike Tutkowski
I'm not seeing any recognition from CS that this VM exists at all...no print outs in the console at least. On Sat, Aug 24, 2013 at 7:08 PM, Marcus Sorensen wrote: > Yes, there are expunge global settings. > On Aug 24, 2013 6:35 PM, "Mike Tutkowski" > wrote: > > > That would be great. > > > > Is

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

2013-08-25 Thread Dave Cahill
Hi Daan, I started to take a look - the diff is ~10k lines long, most of which appears to be whitespace changes. Are the whitespace changes important? Without them, the patch might be a lot easier to review. Thanks, Dave. On Sun, Aug 25, 2013 at 7:37 PM, Daan Hoogland wrote: > Sheng, Dave,

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-08-25 Thread John Burwell
Kelven, Please don't take my proposal as a criticism of the approach taken in 4.1. I think the current model is a big improvement over the previous approach. Given the time constraints and ambitions of that work, I think it was a solid, pragmatic first step. I believe we are at a point to as

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-08-25 Thread John Burwell
Daan, I think I mentioned in my proposal to defer hot loading/unloading to a later release. It is a hard issue, and not required to address the current pain points. Thanks, -John On Aug 25, 2013, at 7:43 AM, Daan Hoogland wrote: > It seems I am the only one not sharing your reservations reg

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-08-25 Thread John Burwell
Darren, Please see my responses in-line below. Thanks, -John On Aug 21, 2013, at 11:42 AM, Darren Shepherd wrote: > I also agree with this. Spring XML should always be treated as code not > really configuration. It's not good to have a sysadmin touch spring config > and frankly it's just

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-08-25 Thread John Burwell
Prasanna, Generally, Spring configuration files should be packaged in their associated JARs with property substitution for configurable items (e.g. connection pool min and max sizes). Unfortunately, Spring does not allow component wiring to be modified through property files. Since plugins ar

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-08-25 Thread John Burwell
Daan, Please see my responses in-line below. The TL;DR is that I am extremely skeptical of the complexity and flexibility of OSGi. My experience with it in practice has not been positive. However, I want to focus on our requirements for a driver mechanism, and then determine the best impleme

OT: XenServer dev list

2013-08-25 Thread David Nalley
Folks: Was asked to point out that XenServer development is now out in the open and if we need to ask questions/request features or help we can do so now on their mailing list: xs-de...@lists.xenserver.org --David

Re: Templates via Vagrant Provider and Veewee

2013-08-25 Thread Prasanna Santhanam
All our systemVMs come from veewee + vagrant. see tools/appliance On Sun, Aug 25, 2013 at 05:57:50PM +0100, Ian Duffy wrote: > Hey, > > Has anybody tried to use the vagrant provider through veewee in order to > create templates? -- Prasanna., Powered by BigRock.com

Review Request 13800: CLOUDSTACK-4487 Offering deletes are not enforced including the waits

2013-08-25 Thread Sowmya Krishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13800/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-4487 R

Re: Review Request 13798: CLOUDSTACK-1525: [DOC] Added - Accessing System VMs via SSH

2013-08-25 Thread Marty Sweet
> On Aug. 25, 2013, 3:42 p.m., David Nalley wrote: > > Marty: On the new file can you put in a license header. See > > http://www.apache.org/legal/src-headers.html for details on the policy - > > and see any of the other XML files in publican for examples. Can you fix > > and resubmit? > > Ot

Templates via Vagrant Provider and Veewee

2013-08-25 Thread Ian Duffy
Hey, Has anybody tried to use the vagrant provider through veewee in order to create templates?

Re: Review Request 13798: CLOUDSTACK-1525: [DOC] Added - Accessing System VMs via SSH

2013-08-25 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13798/#review25518 --- Marty: On the new file can you put in a license header. See http://

Re: [ACS4.2] Don;t use libvirt 0.10.2+ if you are using NFS as primary storage on KVM

2013-08-25 Thread David Nalley
Have you filed this on RHT's Bugzilla? If so whats the BZ#? If not, can you please do so? --David On Sun, Aug 25, 2013 at 1:20 AM, Edison Su wrote: > There is a "bug" in libvirt 0.10.2+: > > /* Short-circuit if already mounted */ > 385

Review Request 13798: CLOUDSTACK-1525: [DOC] Added - Accessing System VMs via SSH

2013-08-25 Thread Marty Sweet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13798/ --- Review request for cloudstack. Bugs: CLOUDSTACK-1525 Repository: cloudstack-g

Re: [DISCUSS/PROPOSAL] Upgrading Driver Model

2013-08-25 Thread Daan Hoogland
It seems I am the only one not sharing your reservations regarding OSGi, so let's go for it, John. I would personally try to not bother with the hot-loading and -unloading of drivers and create a install and a drivers directory for all running processes, where these will be checked upon starting

Re: Review Request 13771: CLOUDSTACK-4346 replace URI getHost() and create(String) calls

2013-08-25 Thread Daan Hoogland
Sheng, Dave, Chiradeep and Hugo, Can you please review this? In my experience the time that this patch will expire is rather short, I have been resolving conflicts on this a lot. If now, given the 4.2 release is inconvenient, I would like to set a window for submitting this in which I will rebase