Re: Review Request 11479: SolidFire storage plug-in and enhancements to the storage framework and GUI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11479/#review23613 --- Review 11479 failed the build test : FAILURE The url of build clouds

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23612 --- Review 12720 failed the build test : FAILURE The url of build clouds

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23611 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request 9871: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/#review23610 --- Commit 7260e8d83f07d90b48c34adaeb227de265019487 in branch refs/heads/

Re: Regarding the bug Cloudstack-3589 VM created from VPC network is not getting IP

Hi Dann, The commit d73bb22802cba9116f27fada6780c966b0060b30 changes the name of the dnamsqTo to dhcpTo and adds some dns specific config as a part of the review comments. The bug Cloudstack-3589 is because of passing null value to the dhcpto ( As a result the dhcp setting has a null in

Re: Using the ACS simulator for jclouds "live" tests - some questions. =)

Hi - the advanced zone setup should work without troubles. The current master is broken and a couple of bugs are pending for this after the baremetal merge done recently. CLOUDSTACK-3481 and CLOUDSTACK-1812. On Sun, Jul 21, 2013 at 08:32:42PM -0700, Andrew Bayer wrote: > Finally got a chance to

Re: Using the ACS simulator for jclouds "live" tests - some questions. =)

Finally got a chance to work on this - trying to get the basic networking setup with Marvin seems to be barfing - I get the following exception in the CS logs when I run mvn -Pdeveloper,marvin.setup -Dmarvin.config=setup/dev/basic.cfg -pl :cloud-marvin integration-test: WARN [cloud.network.Networ

Re: Error to start MS on 4.2

I have checked in a fix to insert that config value in schema410to420.sql. Frank, you can review to see if more code is needed. Thanks -min Sent from my iPhone On Jul 20, 2013, at 11:03 PM, "Koushik Das" wrote: > The code needs to handle the case when the db. entry is not present. It > shoul

RE: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

Sheng / Daan, Please let us know once revert the commit; I can run regression test after that. Regards, Rayees -Original Message- From: Sheng Yang [mailto:sh...@yasker.org] Sent: Sunday, July 21, 2013 11:32 AM To: ; Bharat Kumar Cc: dhoogl...@schubergphilis.com; Alena Prokharchyk; Abhin

Re: GlusterFS QEMU libgfapi

On a side note, we aren't limited to libvirt-supported storage. KVMStoragePoolManager allows for multiple storage adaptors, so you can just add yours to the adaptor map in there and create a MyStorageAdaptor that implements the various methods like CreatePhysicalDisk, etc , similar to LibvirtStorag

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

After talking with Daan, we decided to revert the commit for now. After Bharat complete the rewrite of dnsmasqconfigurator in bash script. A new patch would be committed to fix CLOUDSTACK-3357 before the code freeze, --Sheng On Sun, Jul 21, 2013 at 9:52 AM, Sheng Yang wrote: > And it's also my

Re: GlusterFS QEMU libgfapi

Greetings, CloudStackers. I noticed there was a question re: libgfapi as it pertains to libvirt and QEMU. As of last January/February, all new versions of the KVM/QEMU/libvirt/oVirt virtualization stack have been "glusterized" and use the libgfapi client library when you specify the gluster pro

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

I've got into at least two exceptions lately. They made me skeptic. --Sheng On Sun, Jul 21, 2013 at 10:38 AM, David Nalley wrote: > On Sun, Jul 21, 2013 at 12:52 PM, Sheng Yang wrote: > > And it's also my fault on this issue because I didn't look at the patch > > when it's in reviewboard. I wa

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

On Sun, Jul 21, 2013 at 12:52 PM, Sheng Yang wrote: > And it's also my fault on this issue because I didn't look at the patch > when it's in reviewboard. I was not that diligent at reviewboard before... > > To prevent the same thing happen again, we may want to do something like > xxx area's code

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

And it's also my fault on this issue because I didn't look at the patch when it's in reviewboard. I was not that diligent at reviewboard before... To prevent the same thing happen again, we may want to do something like xxx area's code need to be reviewed by xxx, xxx, xxx in the future? --Sheng

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

Sorry, the integration test of VPC has been failed for quite some time, I just found this issue after fixing some other issues in the integration test... --Sheng On Sun, Jul 21, 2013 at 9:23 AM, Daan Hoogland wrote: > I am happy to redo the work with a different approach, but it did not break >

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

I am happy to redo the work with a different approach, but it did not break integration last week, did it? So a newer patch needs to be reverted, no? The problem might be cumulative due to more then one commit, in which case a role forward might be the quickest way to go. On Sun, Jul 21, 2013 at

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

In fact DnsMasqConfigurator has other issues since it would complete override the whole configuration file modified by bash scripts in the VR. So Bharat is working on that and should send out patch soon, using bash scripts on the dnsmasq.conf instead. Also that's our preferred approach to modify dn

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

So if I understand your mail correctly, a VpcDnsMasqConfigurator should be created to be used in configDnsMasq in VpcVirtualApplienceManagerImpl, instead of the one used now? On Sun, Jul 21, 2013 at 6:01 PM, Sheng Yang wrote: > Hi Daan, > > We're talking about vpc router. Your patch affect the

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

On Sun, Jul 21, 2013 at 4:10 AM, Daan Hoogland wrote: > please se inline comments > > On Sun, Jul 21, 2013 at 12:49 PM, Daan Hoogland >wrote: > > > H Sheng et al, > > > > I have no overview of what effect my patch has on guest vm's. It is > > supposed to only generate a dnsmasq.conf for vpc-route

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

Hi Daan, We're talking about vpc router. Your patch affect the guest vm because guest VM cannot get ip address from VPC router(DHCP request fail). The VPC indeed using a different dnsmasq.conf. See /etc/vpcdnsmasq.conf(which is a template of VPC used dnsmasq). You're using DnsMasqConfigurator, w

Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

Your remarks on the assert resembles a comment in the code that I didn't write ;) But seriously; If the string contains a scheme that is not in the enum, you want a exception to be thrown instead of UnDecided or UnDefined? regards, On Sun, Jul 21, 2013 at 5:32 PM, Alex Huang wrote: > Daan,**

RE: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

Daan, I'm not sure I understand what you're saying here. --Alex From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Sunday, July 21, 2013 4:23 AM To: Alex Huang Cc: Hugo Trippaers; cloudstack Subject: Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs Alex, I

Re: Regarding the bug Cloudstack-3589 VM created from VPC network is not getting IP

Bharat, sorry to haven't noticed this post earlier; Your commit d73bb22802cba9116f27fada6780c966b0060b30 is changing code of commit b903262df5e2ff5d174859ce28abae75c4689f0c. What is the rationale behind changing configDnsMasq() in VpcVirtualNetworkApplianceManagerImpl? regards, Daan On Thu, Ju

Re: Review Request 12685: CLOUDSTACK-1532 added utility functions to scan URIs

Alex, I saw you put you comments in the commit as comment...??? why not as code then? On Sat, Jul 20, 2013 at 3:42 PM, Alex Huang wrote: > Daan, > > ** ** > > It should assert and throw a CloudRuntimeException. > > ** ** > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Exc

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

please se inline comments On Sun, Jul 21, 2013 at 12:49 PM, Daan Hoogland wrote: > H Sheng et al, > > I have no overview of what effect my patch has on guest vm's. It is > supposed to only generate a dnsmasq.conf for vpc-router-vm's. not > guestnetwork-vm's. I am happy to look at it, but have no

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

H Sheng et al, I have no overview of what effect my patch has on guest vm's. It is supposed to only generate a dnsmasq.conf for vpc-router-vm's. not guestnetwork-vm's. I am happy to look at it, but have no overview of the issue yet. Should a sepperate dnsmasq.conf instance be created for vpc route