Re: [PR] CAUSEWAY-3734 excel reader uses pass through interaction [causeway]

2024-05-08 Thread via GitHub
andi-huber merged PR #2403: URL: https://github.com/apache/causeway/pull/2403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@causeway.a

Re: [PR] CAUSEWAY-3734 excel reader uses pass through interaction [causeway]

2024-05-08 Thread via GitHub
andi-huber commented on PR #2403: URL: https://github.com/apache/causeway/pull/2403#issuecomment-2100087643 Thanks Dan. I guess you are confirming what I had suspected. Unmarshalling / de-serialization should be a perfect fit with `PASSTHROUGH` execution. -- This is an automated message f

Re: [PR] CAUSEWAY-3734 excel reader uses pass through interaction [causeway]

2024-05-08 Thread via GitHub
andi-huber commented on PR #2403: URL: https://github.com/apache/causeway/pull/2403#issuecomment-2100078194 In other words 'when to allow bypassing of change events' is an open research question, which I must admit, I had not yet taken my time to investigate in more detail. For reference, t

Re: [PR] CAUSEWAY-3734 excel reader uses pass through interaction [causeway]

2024-05-08 Thread via GitHub
danhaywood commented on PR #2403: URL: https://github.com/apache/causeway/pull/2403#issuecomment-2100074714 We have our own fork of this module, and so this was the correct solution for us. It certainly shouldn't be `InteractionInitiatedBy.USER`, our reasoning was that `PASSTHROUGH` (rathe

Re: [PR] CAUSEWAY-3734 excel reader uses pass through interaction [causeway]

2024-05-08 Thread via GitHub
andi-huber commented on PR #2403: URL: https://github.com/apache/causeway/pull/2403#issuecomment-2100066943 Pass-through execution will also ignore any events that are potentially involved with action execution or property change. Using pass-through for some use cases to speed up thin