Re: [PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-28 Thread via GitHub
bkalbfus commented on PR #1: URL: https://github.com/apache/causeway-app-referenceapp/pull/1#issuecomment-2689903238 My implementation was faulty as well - I was just glad to have it built. I updated my branch to better serve the Complex Number. Adding to it gives a different error.

Re: [PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-28 Thread via GitHub
andi-huber commented on PR #1: URL: https://github.com/apache/causeway-app-referenceapp/pull/1#issuecomment-2690151530 Composite value type issue (as affects the Complex Number demo here) now fixed in _Causeway_. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-27 Thread via GitHub
bkalbfus commented on PR #1: URL: https://github.com/apache/causeway-app-referenceapp/pull/1#issuecomment-2689947212 I was at the screen to create the PR and decided to test a bit first. Somehow the PR got forwarded to you before I submitted it on that screen. On Thu, Feb 27, 2025,

Re: [PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-27 Thread via GitHub
andi-huber closed pull request #1: Fixed dependencies and impl of ComplexNumber URL: https://github.com/apache/causeway-app-referenceapp/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-27 Thread via GitHub
andi-huber commented on PR #1: URL: https://github.com/apache/causeway-app-referenceapp/pull/1#issuecomment-2689840202 However, I as well do see the complex number demo broken currently. So thats a recent regression with Causeway. I'm going to fix that (in Causeway). -- This is an automa

Re: [PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-27 Thread via GitHub
andi-huber commented on PR #1: URL: https://github.com/apache/causeway-app-referenceapp/pull/1#issuecomment-2689813429 Not going to merge! This project's **v3** branch needs to build against the Causeway's **main** branch (not against any particular releases). Such that it allows

Re: [PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-26 Thread via GitHub
bkalbfus commented on PR #1: URL: https://github.com/apache/causeway-app-referenceapp/pull/1#issuecomment-2686966220 Coding blind here. Did I do it correctly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] Fixed dependencies and impl of ComplexNumber [causeway-app-referenceapp]

2025-02-26 Thread via GitHub
bkalbfus opened a new pull request, #1: URL: https://github.com/apache/causeway-app-referenceapp/pull/1 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu