Re: Thrift out of memory crashes

2010-03-26 Thread Ted Zlatanov
On Fri, 26 Mar 2010 09:44:23 -0500 Jonathan Ellis wrote: JE> The workarounds we can apply at the Cassandra level have too high a JE> cost:benefit ratio. The long term fix is to move to Avro. Can you list the workarounds you've considered? Is TBinaryProtocol.setReadLength completely useless?

Re: Thrift out of memory crashes

2010-03-26 Thread Jonathan Ellis
The workarounds we can apply at the Cassandra level have too high a cost:benefit ratio. The long term fix is to move to Avro. 2010/3/26 Ted Zlatanov : > On Fri, 26 Mar 2010 07:48:43 -0500 Jonathan Ellis wrote: > > JE> 2010/3/26 Ted Zlatanov : >>> I know this has been discussed in tickets and her

Re: Thrift out of memory crashes

2010-03-26 Thread Ted Zlatanov
On Fri, 26 Mar 2010 07:48:43 -0500 Jonathan Ellis wrote: JE> 2010/3/26 Ted Zlatanov : >> I know this has been discussed in tickets and here previously.  I just >> wanted to comment on it because of the upcoming 0.6 release. >> >> In my environment I patch Cassandra to prevent the OOM errors fro

Re: Thrift out of memory crashes

2010-03-26 Thread Jonathan Ellis
Catching OOME is a bug, not a fix. OOME is the JVM saying "I give up; you're screwed." The JVM isn't stable anymore. 2010/3/26 Ted Zlatanov : > I know this has been discussed in tickets and here previously.  I just > wanted to comment on it because of the upcoming 0.6 release. > > In my environm

Thrift out of memory crashes

2010-03-26 Thread Ted Zlatanov
I know this has been discussed in tickets and here previously. I just wanted to comment on it because of the upcoming 0.6 release. In my environment I patch Cassandra to prevent the OOM errors from malformed incoming Thrift data, which as everyone knows let anyone crash the servers hard with a ne