Re: Somewhat Weekly Cassandra Dev Wrapup

2017-11-01 Thread Jeff Jirsa
Good questions. Right now we're not actively using it (at least not publicly, as far as I know, individual contributors may be using it or sonar or something else). For the specific warning (index out of bounds) you point out below, if map.length was odd, then the consumer.consume(map[i],map[i+1])

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-11-01 Thread Salih Gedik
Hi, As an undergrad student I actually question the output of static analysis tools. Are you guys actively using it or do you find projects like Sonar efficient in such open source projects? Last time I heard that FindBugs are no longer maintained because the code was hard to maintain. For inst

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-11-01 Thread Jeff Jirsa
Ah, I remember that now. Blocked by a guava bug? 4.0 seems like a good time to upgrade guava. -- Jeff Jirsa > On Nov 1, 2017, at 2:49 AM, Stefan Podkowinski wrote: > > >> 2) Static Analysis stuff: > > I think it's worth mentioning that I also tried to integrate the Error > Prone analyzer (

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-11-01 Thread Stefan Podkowinski
> 2) Static Analysis stuff: I think it's worth mentioning that I also tried to integrate the Error Prone analyzer (http://errorprone.info/) a while ago as part of CASSANDRA-13175. Eventually I dropped the ball there due to some classpath issues, but maybe that can be fix or worked around. Having

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-11-01 Thread Malcolm Taylor
Glad to hear you are finding lgtm.com useful. I work for Semmle, the company behind lgtm.com. I see you are interested in checking regularly for new and fixed alerts on lgtm.com. This can be achieved through our Github integration described in https://lgtm.com/docs/lgtm/using-lgtm-analysis-contin

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-10-31 Thread Jeff Beck
On the hashCode violations they are all on https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/dht/Range.java which does seem to get the correct hashcode impl from https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/dht/AbstractBounds.java Jeff On

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-10-31 Thread kurt greaves
Looks like that solves that problem. Probably wouldn't be a bad idea to include that list in the release posts as well as link to changes.txt? At the very least it will make us a bit more careful about assigning fix versions (maybe). On 1 November 2017 at 00:36, Michael Shuler wrote: > On 10/31/

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-10-31 Thread Michael Shuler
On 10/31/2017 07:17 PM, kurt greaves wrote: > It's usually pretty clear what is a fix in the changes log but they > definitely require checking. However I'd say putting more boilerplate in > the changes log isn't really necessary and would be hard to enforce. If we > could generate a report with th

Re: Somewhat Weekly Cassandra Dev Wrapup

2017-10-31 Thread kurt greaves
It's usually pretty clear what is a fix in the changes log but they definitely require checking. However I'd say putting more boilerplate in the changes log isn't really necessary and would be hard to enforce. If we could generate a report with this information from JIRA with desired information wo

Somewhat Weekly Cassandra Dev Wrapup

2017-10-30 Thread Jeff Jirsa
Trying really hard to do this as close to weekly as possible, but it's been pretty quiet and I've been pretty busy. A few things to note: 1) Sylvain opened a JIRA ( https://issues.apache.org/jira/browse/CASSANDRA-13910) about deprecating (dclocal_)read_repair_chance (the probabilistic async read