Re: Timeout unit tests in trunk

Cool, I think I fixed the ViewTest by changing from updateView("TRUNCATE %s") to execute("TRUNCATE %s"). I also split it into several smaller unit tests. Patch is here: https://issues.apache.org/jira/browse/CASSANDRA-14280 I haven't got time to look into BatchMetricsTest yet. Thanks Dikang. On

Re: Timeout unit tests in trunk

All, As @kjellman pointed out, the timeouts on ViewTest & ViewBuilderTaskTest are being addressed in CASSANDRA-14194 (I have a patch, almost ready to release). @dikang if you want to refactor those tests for fun, go for it - but note that th

Re: Timeout unit tests in trunk

Yes, give it a go. I am not 100% sure if it will help a whole lot but try it out and let's see what happens! Dinesh On Tuesday, February 27, 2018, 2:57:41 PM PST, Dikang Gu wrote: I took some look at the cql3.ViewTest, it seems too big and timeout very often. Any objections if I split

Re: Timeout unit tests in trunk

i've seen it timeout a lot too. if you think breaking it up will fix it that definitely sounds like a good approach! > On Feb 27, 2018, at 2:57 PM, Dikang Gu wrote: > > I took some look at the cql3.ViewTest, it seems too big and timeout very > often. Any objections if I split it into two or mul

Re: Timeout unit tests in trunk

I took some look at the cql3.ViewTest, it seems too big and timeout very often. Any objections if I split it into two or multiple tests? On Tue, Feb 27, 2018 at 1:32 PM, Michael Kjellman wrote: > well, turns out we already have a jira tracking the MV tests being broken > on trunk. they are legit

Re: Timeout unit tests in trunk

well, turns out we already have a jira tracking the MV tests being broken on trunk. they are legit broken :) thanks jaso https://issues.apache.org/jira/browse/CASSANDRA-14194 not sure about the batch test timeout there though.. did you debug it at all by chance? On Feb 27, 2018, at 1:27 PM, M

Re: Timeout unit tests in trunk

hey dikang: just chatted a little bit about this. proposal: let's add the equivalent of @resource_intensive to unit tests too.. and the first one is to stop from running the MV unit tests in the free circleci containers. thoughts? also, might want to bug your management to see if you can get som

Re: Timeout unit tests in trunk

Some tests might require additional resources to spin up the required components. 2 CPU / 4GB might not be sufficient. You may need to bump up the resources to 8CPU / 16GB. Dinesh On Tuesday, February 27, 2018, 11:24:34 AM PST, Dikang Gu wrote: Looks like there are a few flaky/timeou