Re: Parallel Compaction

2010-12-18 Thread Germán Kondolf
I've created the patch ticket: https://issues.apache.org/jira/browse/CASSANDRA-1876 On Fri, Dec 17, 2010 at 12:30 PM, Germán Kondolf wrote: > On Fri, Dec 17, 2010 at 11:15 AM, Jonathan Ellis wrote: >> On Fri, Dec 17, 2010 at 8:01 AM, Germán Kondolf >> wrote: >> >>> Thanks Jonathan for the feedb

Re: Parallel Compaction

2010-12-17 Thread Germán Kondolf
On Fri, Dec 17, 2010 at 11:15 AM, Jonathan Ellis wrote: > On Fri, Dec 17, 2010 at 8:01 AM, Germán Kondolf > wrote: > >> Thanks Jonathan for the feedback. >> >> By flush/schema migration you mean the SSTables replace lock? I've put >> that lock just to be sure, if it's fine by you I'll remove it.

Re: Parallel Compaction

2010-12-17 Thread Jonathan Ellis
On Fri, Dec 17, 2010 at 8:01 AM, Germán Kondolf wrote: > Thanks Jonathan for the feedback. > > By flush/schema migration you mean the SSTables replace lock? I've put > that lock just to be sure, if it's fine by you I'll remove it. > I'll clean up the code according to the code-style article, add t

Re: Parallel Compaction

2010-12-17 Thread Germán Kondolf
Thanks Jonathan for the feedback. By flush/schema migration you mean the SSTables replace lock? I've put that lock just to be sure, if it's fine by you I'll remove it. I'll clean up the code according to the code-style article, add the parameter to the configuration using a default of "1" and I'll

Re: Parallel Compaction

2010-12-16 Thread Jonathan Ellis
Hi Germán, Thanks for taking a stab at this! I don't actually think there are going to be any tricky race conditions with flush or schema migration; flush has been parallel for a long time itself, and we already have the lock in CompactionManager for schema migration. To clean this up for submis