Thank you for input.
I will disable gen-doc in addition to checkstyle locally, but I would still
suggest that in short-term we should at very least remove/disable the part that
auto-installs go (or at least have a discussion or vote about it, in case folks
believe auto-installing is a good idea
I don't see it necessary to port Gradle stuff to Ant. I have noticed zero
problems with it after CEP-15 merge. Basically a non-event.
It just looks strange that we have Ant + Maven poms / resolver wired into
it + submodule on Gradle. I mean ... wow. There is nothing wrong per se but
... strange. O
It is not installed when it is present on the computer already, it should
take that instead.
If we treat Go the same way as Python then we might drop its installation.
It is there for convenience mostly. We also do not install Python so ...
On Thu, Apr 24, 2025 at 12:24 PM Brandon Williams wrote
Why do we depend on python3 but install golang? I can relate to those
who don't want random binaries installed and executed on their system.
Kind Regards,
Brandon
On Thu, Apr 24, 2025 at 3:39 AM Mick Semb Wever wrote:
>
> it's for the website docs. these are in-tree under doc/
> there's stuff
Hi Alex, all
The way I use it is that I have this in build.properties (just copy
build.properties.default in repo) and change the content.
build.properties file is in .gitignore and I think it is the most idiomatic
way to do this kind of stuff.
$ cat build.properties
ant.gen-doc.skip=true
ant.no
it's for the website docs. these are in-tree under doc/
there's stuff that's auto-generated. e.g. nodetool, yaml, native protocol
pages from their corresponding classes.
it was an oversight to not have raised a discuss thread for the
introduction of golang into the build system. this was only d
We should separate out any grade discussion. I’m happy to migrate accord to ant if that’s the project preference, but there’s continual discussion to begin modularising Cassandra (at least a little), and a proposal to use grade for the modules - which might be a happy medium for everyone’s competin
Could you elaborate how specifically having a generate docs task on by default
is helping newcomers, and how code changes break docs? Also, are we talking
about javadoc or documentation website?
On Thu, Apr 24, 2025, at 8:25 AM, Mick Semb Wever wrote:
> Does this also apply to gradle, which now
Does this also apply to gradle, which now gets downloaded and installed,
and is the most recent addition ?
The python requirement from gen-doc has been around for over three years
now.
I agree with the rationale that `ant` should default to `ant check`,
keeping newcomers in mind while being more
I didn’t say we should disable checks. I thought this was a purpose of CI : to
check everything: there’s likely more to break semantically anyways, also
harder to detect and fix. I’m also not proposing removing something that was
long in place, these dependencies were introduced very recently.
> If you want to run check but skip it, it's to add `-Dant.gen-doc.skip=true`
I do not think developers have to be forced skip it. Such checks can be a part
of CI or merge, but not a common development workflow. It should be in a
separate task, and simply calling `ant` should most certainly not i
I think the default build should be to build and check everything. I think
that if someone is new it is better to have everything built and checked by
default to flag issues.
If someone knows what they are doing and wants to speed up the process it
is very easy to add the right settings to the an
Should we consider making that the default and then passing false
explicitly in CI/builds? I agree with Alex it’s a bit surprising and
shorter build times when developing would be helpful.
Jordan
On Wed, Apr 23, 2025 at 13:37 Mick Semb Wever wrote:
> Python and Go are used by the gen-doc target
Python and Go are used by the gen-doc target.
Code changes can break these, hence it is part of `ant check`.
It is not called by `ant jar`
If you want to run check but skip it, it's to add `-Dant.gen-doc.skip=true`
On Wed, 23 Apr 2025 at 22:06, Alex Petrov wrote:
> Hi folks,
>
> Building Cas
Hi folks,
Building Cassandra jar has been getting increasingly slow, and now it looks
like we depend not only on python3 (which was already not optimal), but also on
go:
ant -Dno-checkstyle=true
...
[exec] python3 ./scripts/gen-nodetool-docs.py
[exec] python3 ./scripts/convert_y
15 matches
Mail list logo
