Re: Presubmit checks in github

2017-09-22 Thread Corentin Chary
I guess adding a hook for circle would work as well :) On Wed, Sep 20, 2017 at 5:04 PM, Jeff Jirsa wrote: > At one point we tested with a travis config very similar to what circle does > (run all the unit tests, etc). The free options for Travis can’t run the > basic unit test suite reliably, w

Re: Presubmit checks in github

2017-09-20 Thread Jeff Jirsa
At one point we tested with a travis config very similar to what circle does (run all the unit tests, etc). The free options for Travis can’t run the basic unit test suite reliably, where circle could, so we put the circle yaml in - no reason we can’t ADD Travis as well The ASF has a paid Travi

Presubmit checks in github

2017-09-20 Thread Corentin Chary
Hello, Looks like currently we don't automatically run any check when a new pull request is created on github. It could be as simple as https://github.com/criteo-forks/cassandra/blob/cassandra-3.11-criteo/.travis.yml (minus the release part) I guess circleci could be used too since apparently it'