Re: JMX exposing non-standard java classes, to fix requires a breaking change

2022-05-05 Thread David Capwell
Filed CASSANDRA-17580 and have a patch ready which will hide non-native java exceptions from leaking into JMX (Cassandra and third-party libraries), this is enabled by default but can be disabled via config or system property Config: jmx_hide_non_java_exceptions: false System property -Dcassan

Re: JMX exposing non-standard java classes, to fix requires a breaking change

2022-04-06 Thread David Capwell
> > I noticed in DatabaseDescriptor there are setters that are leaking it to > JMX since cassandra-3.0. I am not sure whether we can just change it to > IllegalArgumentException which will be then also thrown on startup where > they were ConfigurationExceptions before My concern here is maintenan

Re: JMX exposing non-standard java classes, to fix requires a breaking change

2022-04-06 Thread Ekaterina Dimitrova
I would say keep the old ones and add new ones to be compatible in addition. Now your catch led me to more thinking and I think throwing ConfigurationException deserves more attention. I noticed in DatabaseDescriptor there are setters that are leaking it to JMX since cassandra-3.0. I am not sure wh

JMX exposing non-standard java classes, to fix requires a breaking change

2022-04-05 Thread David Capwell
There are 2 places that expose non-standard java classes, so JMX only works if and only if the JMX client also has Cassandra's jars, else they will fail; the 2 examples are org.apache.cassandra.service.StorageServiceMBean#enableAuditLog throws org.apache.cassandra.exceptions.ConfigurationException