Re: CASSANDRA-8527

2018-01-09 Thread kurt greaves
I think tombstone rows is more appropriate. Calling them deleted rows initially confused me and it took a few reads of the problem for me to work it out. Especially when you put it in context and "tombstone cells" follows.​

Re: CASSANDRA-8527

2018-01-09 Thread Aleksey Yeshchenko
id any more > configuration settings as complex as back_pressure_strategy going forward. > > > On Jan 5, 2018, at 9:36 AM, Alexander Dejanovski > wrote: > > > > Hi Aleksey, > > > > ok we'll split the work and only deal with row level tombsto

Re: CASSANDRA-8527

2018-01-05 Thread Alexander Dejanovski
have to think about. I would prefer to avoid any more > configuration settings as complex as back_pressure_strategy going forward. > > > On Jan 5, 2018, at 9:36 AM, Alexander Dejanovski > wrote: > > > > Hi Aleksey, > > > > ok we'll split the work and only d

Re: CASSANDRA-8527

2018-01-05 Thread Aleksey Yeshchenko
and only deal with row level tombstones in > CASSANDRA-8527 <https://issues.apache.org/jira/browse/CASSANDRA-8527> and > create a follow up ticket to work on the separate counts you're suggesting. > My understanding of what you say is that you would not include range >

Re: CASSANDRA-8527

2018-01-05 Thread Jon Haddad
7;ll split the work and only deal with row level tombstones in > CASSANDRA-8527 <https://issues.apache.org/jira/browse/CASSANDRA-8527> and > create a follow up ticket to work on the separate counts you're suggesting. > My understanding of what you say is that you would not

Re: CASSANDRA-8527

2018-01-05 Thread Alexander Dejanovski
Hi Aleksey, ok we'll split the work and only deal with row level tombstones in CASSANDRA-8527 <https://issues.apache.org/jira/browse/CASSANDRA-8527> and create a follow up ticket to work on the separate counts you're suggesting. My understanding of what you say is that you would n

Re: CASSANDRA-8527

2017-12-27 Thread Aleksey Yeshchenko
st aren’t there. > > > > On Dec 19, 2017, at 11:07 PM, Alexander Dejanovski < > a...@thelastpickle.com> wrote: > > > > Hi folks, > > > > I'm working on CASSANDRA-8527 > > <https://issues.apache.org/jira/browse/CASSANDRA-8527&g

Re: CASSANDRA-8527

2017-12-22 Thread Alexander Dejanovski
r of the change in behavior of this patch > but > > I wanted to get some more feedback before committing to it. Are there > any > > objections to what Alex described? > > > > Regarding Mockito, I’ve been meaning to bring this up for a while, and > I’m > > a soli

Re: CASSANDRA-8527

2017-12-21 Thread kurt greaves
, but > realistically that’s a multi year process and we just aren’t there. > > > > On Dec 19, 2017, at 11:07 PM, Alexander Dejanovski < > a...@thelastpickle.com> wrote: > > > > Hi folks, > > > > I'm working on CASSANDRA-8527 > > <https:/

Re: CASSANDRA-8527

2017-12-21 Thread Qingcun Zhou
Maybe I should rephrase my words but I think you got that thread. Singleton is one big thing and possibly we can use powermock, or totally get rid of it. But without mock, I'm frustrated to work on so-called unit test cases. On Thu, Dec 21, 2017 at 2:28 PM, Jeff Jirsa wrote: > On Thu, Dec 21, 20

Re: CASSANDRA-8527

2017-12-21 Thread Jeff Jirsa
On Thu, Dec 21, 2017 at 12:33 PM, Qingcun Zhou wrote: > I brought up Mockito topic couple of months ago but some committers don't > think we should introduce more dependencies. > > I don't see any indication of this in the dev@ archives. There was a comment from a contributor who said they weren'

Re: CASSANDRA-8527

2017-12-21 Thread Jeff Jirsa
On Tue, Dec 19, 2017 at 11:07 PM, Alexander Dejanovski < a...@thelastpickle.com> wrote: > Hi folks, > > I'm working on CASSANDRA-8527 > <https://issues.apache.org/jira/browse/CASSANDRA-8527> and would need to > discuss a few things. > > The ticket makes it vi

Re: CASSANDRA-8527

2017-12-21 Thread Jon Haddad
19, 2017, at 11:07 PM, Alexander Dejanovski < >> a...@thelastpickle.com> wrote: >>> >>> Hi folks, >>> >>> I'm working on CASSANDRA-8527 >>> <https://issues.apache.org/jira/browse/CASSANDRA-8527> and would need to >>>

Re: CASSANDRA-8527

2017-12-21 Thread DuyHai Doan
g it to help with testing. In an ideal world we’d > have no singletons and could test everything in isolation, but > realistically that’s a multi year process and we just aren’t there. > > > > On Dec 19, 2017, at 11:07 PM, Alexander Dejanovski < > a...@thelastpickle.com> wr

Re: CASSANDRA-8527

2017-12-21 Thread Qingcun Zhou
with testing. In an ideal world we’d > have no singletons and could test everything in isolation, but > realistically that’s a multi year process and we just aren’t there. > > > > On Dec 19, 2017, at 11:07 PM, Alexander Dejanovski < > a...@thelastpickle.com> wrote: &

Re: CASSANDRA-8527

2017-12-21 Thread Jon Haddad
ski > wrote: > > Hi folks, > > I'm working on CASSANDRA-8527 > <https://issues.apache.org/jira/browse/CASSANDRA-8527> and would need to > discuss a few things. > > The ticket makes it visible in tracing and metrics that rows shadowed by > range tombs

CASSANDRA-8527

2017-12-19 Thread Alexander Dejanovski
Hi folks, I'm working on CASSANDRA-8527 <https://issues.apache.org/jira/browse/CASSANDRA-8527> and would need to discuss a few things. The ticket makes it visible in tracing and metrics that rows shadowed by range tombstones were scanned during reads. Currently, scanned range tombst