Re: Adding wiremock to test dependencies

2023-06-21 Thread Derek Chen-Becker
Generally +1 on this one because it looks different, but am I correct that we already have a couple of mocking libs in our dependencies? I guess my concern is that adding a dependency is probably as much about adding some documentation on why it's included and how/when to use it as it is about upda

Re: Adding wiremock to test dependencies

2023-06-20 Thread Josh McKenzie
Speaking only to the "we don't want to add a dependency on something that's unstable or likely to fizzle out", looks good there to me: • Long-term project health / activity looks robust: https://github.com/wiremock/wiremock/graphs/contributors • Pretty diverse set of contributors in the last co

Re: Adding wiremock to test dependencies

2023-06-20 Thread Brandon Williams
I was concerned about 'jre8' being in the dependency name and looked into which java versions were supported, and it looks like 17 is, so we should verify but I am +1 if that is the case. https://github.com/wiremock/wiremock/issues/1655 Kind Regards, Brandon On Tue, Jun 20, 2023 at 6:35 AM Miklo

Re: Adding wiremock to test dependencies

2023-06-20 Thread Miklosovic, Stefan
retty much imagine that the testing efforts might be expanded to all other snitches as well. From: Miklosovic, Stefan Sent: Tuesday, June 20, 2023 13:35 To: dev@cassandra.apache.org Subject: Adding wiremock to test dependencies Hi, we want to introduce wiremo

Adding wiremock to test dependencies

2023-06-20 Thread Miklosovic, Stefan
Hi, we want to introduce wiremock library (1) into the project as a test dependency to test CASSANDRA-16555. In that patch, (wip here (2)), we want to test how would such snitch behave based on what Amazon EC2 Identity Service of version 2 returned to that snitch. AWS Identity service of versi