Thank you all! It seems there is a consensus here so I updated accordingly
CASSANDRA-18239
On Fri, 16 Jun 2023 at 8:56, Jeremiah Jordan
wrote:
> +1 from me.
>
> On Jun 15, 2023 at 1:01:01 PM, Ekaterina Dimitrova
> wrote:
>
>> Hi everyone,
>> Happy Thursday!
>> Some time ago, Jacek raised the po
+1 from me.
On Jun 15, 2023 at 1:01:01 PM, Ekaterina Dimitrova
wrote:
> Hi everyone,
> Happy Thursday!
> Some time ago, Jacek raised the point that ant eclipse-warnings is generating
> too many false positives and not really working as expected. (CASSANDRA-18239)
>
> Reminder: ant eclipse-warn
Later, we may enable more checks than just leaked resources to improve the
code gradually.
- - -- --- - -
Jacek Lewandowski
pt., 16 cze 2023 o 13:48 Ekaterina Dimitrova
napisał(a):
> Got so excited that I forgot to say which of the two options exactly I
> meant - runn
Got so excited that I forgot to say which of the two options exactly I
meant - running the analysis only on changed files after the initial full
pass is done sounds like a good improvement to me
On Fri, 16 Jun 2023 at 7:43, Ekaterina Dimitrova
wrote:
> I think this is a great idea and it will p
I think this is a great idea and it will probably reduce the time to run
it. Thank you!
On Fri, 16 Jun 2023 at 7:40, Jacek Lewandowski
wrote:
> Additional question is whether we want to run the checks against the whole
> project or just against the file changes between the feature branch and the
Additional question is whether we want to run the checks against the whole
project or just against the file changes between the feature branch and the
target release branch?
- - -- --- - -
Jacek Lewandowski
pt., 16 cze 2023 o 13:09 Aleksey Yeshchenko napisał(a):
> Sou
Sounds like a clear improvement to me. Only once this check flagged a
legitimate issue I missed, if I’m remembering correctly. All other instances
have just been annoyances, forcing to add a redundant suppressed annotation.
> On 15 Jun 2023, at 19:01, Ekaterina Dimitrova wrote:
>
> Hi everyon
Hi everyone,
Happy Thursday!
Some time ago, Jacek raised the point that ant eclipse-warnings is
generating too many false positives and not really working as
expected. (CASSANDRA-18239)
Reminder: ant eclipse-warnings is a task we run with the goal to check
Cassandra code - static analysis to warn
