Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-11-15 Thread Caleb Rackliffe
Added one nit to the PR. Otherwise, this is awesome :) On Wed, Nov 15, 2023 at 11:01 AM Jordan West wrote: > I would also like to back this proposal. We change this default because > several incidents have occurred by leaving the default of auto. There are > rare cases where auto/mmap is the bet

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-11-15 Thread Jordan West
I would also like to back this proposal. We change this default because several incidents have occurred by leaving the default of auto. There are rare cases where auto/mmap is the better option but as for a default mmap_index_only is safer. On Wed, Nov 15, 2023 at 6:35 AM Paulo Motta wrote: > Hi

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-11-15 Thread Paulo Motta
Hi, I would like to get back to this. I proposed this default configuration change on the user list ~1 month ago and there were no comments [1]. I created CASSANDRA-19021 [2] to make the proposed change and Stefan kindly submitted a patch, CI is looking good. Any objections to making this change

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-09-06 Thread Paulo Motta
> I wonder why disk_access_mode property is not in cassandra.yaml (looking into trunk right now) I think there's a prehistoric reason why it was removed but I can't remember right now. > Do you all think we can add it there with brief explanation what each option does? We could reinclude it as l

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-09-06 Thread Ekaterina Dimitrova
Thanks for starting this discussion, Paulo! Shall we also share this thread with @user? On Wed, 6 Sep 2023 at 16:35, C. Scott Andreas wrote: > Supportive of switching the default to mmap_index_only as well. > > I don’t have numbers handy to share, but my experience has been > significantly lowe

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-09-06 Thread Miklosovic, Stefan
@cassandra.apache.org Subject: Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0 NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. +100 to this We'd have to come up

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-09-06 Thread Caleb Rackliffe
+100 to this We'd have to come up w/ a pretty compelling counterexample to NOT switch the default to mmap_index_only at this point. On Wed, Sep 6, 2023 at 11:40 AM Brandon Williams wrote: > Given https://issues.apache.org/jira/browse/CASSANDRA-17237 I think it > makes sense. At the least I thi

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-09-06 Thread Brandon Williams
Given https://issues.apache.org/jira/browse/CASSANDRA-17237 I think it makes sense. At the least I think we should restore disk_access_mode so that users are more aware of the options available. Kind Regards, Brandon On Wed, Sep 6, 2023 at 10:50 AM Paulo Motta wrote: > > Hi, > > I've been bitte

Re: [DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-09-06 Thread C. Scott Andreas
Supportive of switching the default to mmap_index_only as well. I don’t have numbers handy to share, but my experience has been significantly lower read latency and I wouldn’t run with auto. I’ve also not observed substantial heap pressure after switching - it was strictly an improvement. - Sco

[DISCUSS] Update default disk_access_mode to mmap_index_only on 5.0

2023-09-06 Thread Paulo Motta
Hi, I've been bitten by OOMs with disk_access_mode:auto/mmap that were fixed by changing to disk_access_mode:mmap_index_only. In a particular benchmark I got 5x more read throughput on 3.11.x with disk_access_mode: mmap_index_only vs disk_access_mode: auto/mmap. Changing disk_access_mode to mmap_