Re: [DISCUSS] Remove Dead Pull Requests

2022-08-11 Thread Benedict Elliott Smith
 Perhaps we just restrict “trivial” patches to trunk? If it requires several PRs/branches then a Jira is perhaps warranted, and perhaps if it is trivial and unimportant it’s better not to waste the project’s time managing the overhead. This would also be simplified with a modified merge strateg

Re: [DISCUSS] Remove Dead Pull Requests

2022-08-11 Thread Claude Warren, Jr via dev
I agree the amount of work is somewhat overwhelming for the proposed change, but I was referring to the lack of a Jira ticket blocking the pull request. At least that is how it looks to the new observer. Perhaps we should add a "trivial change" label for requests that do not have a ticket and are

Re: [DISCUSS] Remove Dead Pull Requests

2022-08-11 Thread Benjamin Lerer
> > Is there an objection to accepting "typo" corrections without a ticket? > One problem to be aware of is that those pull requests need to be converted in patches and merged manually up to trunk if they were done on older branches. So it might not look like it at first but it can be quite time c

Re: [DISCUSS] Remove Dead Pull Requests

2022-08-11 Thread Benedict
Those all seem like good suggestions to me > On 11 Aug 2022, at 08:44, Claude Warren, Jr via dev > wrote: > >  > My original goal was to reduce the number of pull requests in the backlog as > it appears, from the outside, that the project does not really care for > outside contributions when

Re: [DISCUSS] Remove Dead Pull Requests

2022-08-11 Thread Claude Warren, Jr via dev
My original goal was to reduce the number of pull requests in the backlog as it appears, from the outside, that the project does not really care for outside contributions when there are over 200 pull requests pending and many of them multiple years old. I guess that is an optics issue. Upon looki

Re: [DISCUSS] Remove Dead Pull Requests

2022-08-10 Thread Josh McKenzie
I think of this from a discoverability and workflow perspective at least on the JIRA side, though many of the same traits apply to PR's. Some questions that come to mind: 1. Are people grepping through the backlog of open items for things to work on they'd otherwise miss if they were closed out

Re: [DISCUSS] Remove Dead Pull Requests

2022-08-10 Thread Paulo Motta
I recently came across a github automation in the docker project that I found interesting: https://github.com/docker/for-win/issues/7905#issuecomment-787212626 "Issues go stale after 90 days of inactivity. Mark the issue as fresh with /remove-lifecycle stale comment. Stale issues will be closed

Re: [DISCUSS] Remove Dead Pull Requests

2022-08-10 Thread C. Scott Andreas
Claude, can you say more about the goal or purpose that closing tickets advances? There are quite a lot of tickets with patches attached that the project has either not been able to act on at the time; or which the original contributor started but was unable to complete. We’ve picked up many of

[DISCUSS] Remove Dead Pull Requests

2022-08-10 Thread Claude Warren, Jr via dev
At the moment we have 222 open pull requests. Some dating back 4 years. For some the repository from which they were pulled from has been deleted. For many there are branch conflicts. Now, I am new here so please excuse any misstatements and attribute to ignorance not malice any offence. I would