Re: [DISCUSS] Fixing coverage reports for jvm-dtest-upgrade

2024-03-19 Thread David Capwell
Thanks, looks good to me! > On Mar 19, 2024, at 10:19 AM, Abe Ratnofsky wrote: > > Here's where ClassLoader names were introduced in JDK9: > https://bugs.java.com/bugdatabase/view_bug?bug_id=6479237 > > And where Jacoco introduced support for the exclclassloader agent option: > https://github

Re: [DISCUSS] Fixing coverage reports for jvm-dtest-upgrade

2024-03-19 Thread Abe Ratnofsky
Here's where ClassLoader names were introduced in JDK9: https://bugs.java.com/bugdatabase/view_bug?bug_id=6479237 And where Jacoco introduced support for the exclclassloader agent option: https://github.com/jacoco/jacoco/commit/b8ee4efe9c2ba93485fe5d9e25340113efc2390b My understanding is that n

Re: [DISCUSS] Fixing coverage reports for jvm-dtest-upgrade

2024-03-18 Thread David Capwell
Are there any side effects to naming ClassLoaders? How do we do this? I am +1 to the idea but don’t know enough to know what negatives could happen. > On Mar 17, 2024, at 7:25 AM, Josh McKenzie wrote: > > +1 from me > >> If classloaders are appropriately named in the current versions of >> C

Re: [DISCUSS] Fixing coverage reports for jvm-dtest-upgrade

2024-03-17 Thread Josh McKenzie
+1 from me > If classloaders are appropriately named in the current versions of Cassandra, > we should be able to test upgrade paths to that version without updating the > older branches or building new jvm-dtest JARs for them. Pretty sure Caleb was wrestling w/something recently that might have

[DISCUSS] Fixing coverage reports for jvm-dtest-upgrade

2024-03-15 Thread Abe Ratnofsky
Hey folks, I'm working on gathering coverage data across all of our test suites. The jvm-dtest-upgrade suite is currently unfriendly to Jacoco: it uses classes from multiple versions of Cassandra but with the same class names, so Jacoco's analysis fails due to "Can't add different class with sa