*"Glad you brought up compaction here - I think there would be a
significant benefit to moving compaction to direct i/o."*
Support Direct I/O for SSTable writing
https://issues.apache.org/jira/browse/CASSANDRA-19707
On Mon, 16 Oct 2023 at 17:38, Jon Haddad wrote:
> Glad you brought up compacti
Thanks for your contribution 😀
Pawar, Amit 于2023年10月26日 周四下午11:41写道：
> [Public]
>
> Default behavior is not changed. Thank you, Josh for your appreciation.
> This is my first patch, and it means lot to me.
>
>
>
> Thanks again,
>
> Amit
>
>
>
> +1 to adding the feature, clear and easy configurab
[Public]
Default behavior is not changed. Thank you, Josh for your appreciation. This is
my first patch, and it means lot to me.
Thanks again,
Amit
+1 to adding the feature, clear and easy configurability, and if after a major
cycle we can say with confidence it's beating the status quo in the
[Public]
Default behavior won’t be changed as per your feedback and a ‘direct’ mode can
be used to enable this feature. Thank you all again.
--
Amit
I think introducing the feature is a good idea.
I also think that it should _NOT_ be enabled by default for all the reasons
stated above.
Findin
+1 to adding the feature, clear and easy configurability, and if after a major
cycle we can say with confidence it's beating the status quo in the vast
majority of general cases, flip default. I mean, logically it *should* be, but
infra software at the scale we do requires great care. :)
This i
I think introducing the feature is a good idea.
I also think that it should _NOT_ be enabled by default for all the reasons
stated above.
Finding a cohort of users who are interested in turning it on would provide
a nice testbed to shake out any issues without affecting everyone.
On Tue, Oct 17,
Let’s please not change the default at the same time the feature is introduced.Making the capability available will allow users to evaluate and quantify the benefit of the work, as well as to call out any unintended consequences. As users and the project gain confidence in the results, we can evalu
-1
I still think we should keep it as it is until the direct io
for commitlog (read and write) is ready and relatively stable. And then we
may change the default value to direct io from mmap in a future version,
such as 5.2, or 6.0.
Pawar, Amit 于2023年10月17日周二 19:03写道：
> [AMD Official Use Only
[AMD Official Use Only - General]
Thank you all for your input. Received total 6 replies and below is the summary.
1. Mmap : 2/6
2. Direct-I/O : 4/6
Default should be changed to Direct-IO then ? please confirm.
Thanks,
Amit
Strongly agree with this point of view that direct IO can bring
Strongly agree with this point of view that direct IO can bring great
benefits.
I have reviewed part of the code, and my preliminary judgment is that it is
not very common and limited in some situations, for example, it works for
commitlog's write path only for this patch.So I suggest that the d
*Glad you brought up compaction here - I think there would be a significant
benefit to moving compaction to direct i/o.*
+1. Would love to see this get traction.
On Mon, 16 Oct 2023 at 19:38, Jon Haddad wrote:
> Glad you brought up compaction here - I think there would be a significant
> benefi
I haven't looked at the patch yet so take whatever I say here with a pinch of
salt.
Philosophically, defaults should not change unless there is a clear
demonstrable benefit in majority cases for our users. In this case DirectIO
should have clear benefits. That said, this is a new feature and I
Glad you brought up compaction here - I think there would be a significant
benefit to moving compaction to direct i/o.
On 2023/10/16 16:14:28 Benedict wrote:
> I have some plans to (eventually) use the commit log as memtable payload
> storage (ie memtables would reference the commit log entries
I have some plans to (eventually) use the commit log as memtable payload
storage (ie memtables would reference the commit log entries directly, storing
only indexing info), and to back first level of sstables by reference to commit
log entries. This will permit us to deliver not only much bigger
I haven't looked at the patch, but at a high level, defaulting to direct I/O
for commit logs makes a lot of sense to me.
On 2023/10/16 06:34:05 "Pawar, Amit" wrote:
> [Public]
>
> Hi,
>
> CommitLog uses mmap (memory mapped ) segments by default. Direct-IO feature
> is proposed through new PR
I think what we should do is provide options, and let users make their own
decisions.
The default behavior should not be modified until some future released
version.
Pawar, Amit 于2023年10月16日周一 15:51写道：
> [Public]
>
> Hi,
>
>
>
> CommitLog uses mmap (memory mapped ) segments by default. Direct
[Public]
Hi,
CommitLog uses mmap (memory mapped ) segments by default. Direct-IO feature is
proposed through new PR[1] to improve the CommitLog IO speed. Enabling this by
default could be useful feature to address IO bottleneck seen during peak load.
Need your input regarding changing this def
17 matches
Mail list logo
