Re: [DISCUSS] CASSANDRA-18743 Deprecation of metrics-reporter-config

2023-08-16 Thread Doug Rohrer
My only concern about removal in 5.1 would be that removing it in a “minor” release would really be a breaking change, and semver says that should happen in a major version. If we really want to be semver compliant, it shouldn’t be removed until 6.0 (or, if we remove it in the next release, we

Re: [DISCUSS] CASSANDRA-18743 Deprecation of metrics-reporter-config

2023-08-16 Thread Abe Ratnofsky
There's consensus here to deprecate metrics-reporter-config in 5.0. Is there any objection to removing it in 5.1? > On Aug 11, 2023, at 10:01 AM, Maxim Muzafarov wrote: > > +1 > > The rationale for deprecating/removing this library is not just that > it is obsolete and doesn't get updates. In

Re: [DISCUSS] CASSANDRA-18743 Deprecation of metrics-reporter-config

2023-08-11 Thread Maxim Muzafarov
+1 The rationale for deprecating/removing this library is not just that it is obsolete and doesn't get updates. In fact, when the metrics-reporter-config [1] was added the dropwizard metrics library (formerly com.yammer.metrics [2]) didn't support exporting metrics to files like csv, so it made se

Re: [DISCUSS] CASSANDRA-18743 Deprecation of metrics-reporter-config

2023-08-11 Thread Caleb Rackliffe
+1 > On Aug 11, 2023, at 8:10 AM, Brandon Williams wrote: > > +1 > > Kind Regards, > Brandon > >> On Fri, Aug 11, 2023 at 8:08 AM Ekaterina Dimitrova >> wrote: >> >> >> “ The rationale for this proposed deprecation is that the upcoming 5.0 >> release is a good time to evaluate dependencie

Re: [DISCUSS] CASSANDRA-18743 Deprecation of metrics-reporter-config

2023-08-11 Thread Brandon Williams
+1 Kind Regards, Brandon On Fri, Aug 11, 2023 at 8:08 AM Ekaterina Dimitrova wrote: > > > “ The rationale for this proposed deprecation is that the upcoming 5.0 > release is a good time to evaluate dependencies that are no longer receiving > updates and will become risks in the future.” > > Th

Re: [DISCUSS] CASSANDRA-18743 Deprecation of metrics-reporter-config

2023-08-11 Thread Ekaterina Dimitrova
“ The rationale for this proposed deprecation is that the upcoming 5.0 release is a good time to evaluate dependencies that are no longer receiving updates and will become risks in the future.” Thank you for raising it, I support your proposal for deprecation On Fri, 11 Aug 2023 at 8:55, Abe Ratn

[DISCUSS] CASSANDRA-18743 Deprecation of metrics-reporter-config

2023-08-11 Thread Abe Ratnofsky
Hey folks, Opening a thread to get input on a proposed dependency deprecation in 5.0: metrics-reporter-config has been archived for 3 years and not updated in nearly 6 years. This project has a minor security issue with its usage of unsafe YAML loading via snakeyaml’s unprotected Constructor: