Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-14 Thread Mike Adamson
We can't use open-nlp because it is JDK 17 only. I'll pull the smile-nlp dependency and write something to do the same thing. Our usage was trivial. On Thu, 14 Sept 2023 at 00:10, J. D. Jordan wrote: > Reading through smile license again, it is licensed pure GPL 3, not GPL > with classpath excep

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread J. D. Jordan
Reading through smile license again, it is licensed pure GPL 3, not GPL with classpath exception. So I think that kills all debate here.-1 on inclusion On Sep 13, 2023, at 2:30 PM, Jeremiah Jordan wrote: I wonder if it can easily be replaced with Apache open-nlp?  It also provides an implemen

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Jeremiah Jordan
I wonder if it can easily be replaced with Apache open-nlp? It also provides an implementation of GloVe. https://opennlp.apache.org/docs/2.3.0/apidocs/opennlp-tools/opennlp/tools/util/wordvector/Glove.html On Sep 13, 2023 at 1:17:46 PM, Benedict wrote: > There’s a distinction for spotbugs an

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Benedict
There’s a distinction for spotbugs and other build related tools where they can be downloaded and used during the build so long as they’re not critical to the build process.They have to be downloaded dynamically in binary form I believe though, they cannot be included in the release.So it’s not rea

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Brandon Williams
On Wed, Sep 13, 2023 at 11:37 AM Jeff Jirsa wrote: > You can open a legal JIRA to confirm, but based on my understanding (and > re-confirming reading > https://www.apache.org/legal/resolved.html#category-a ): > > We should probably get clarification here regardless, iirc this came up when we were

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Jeff Jirsa
You can open a legal JIRA to confirm, but based on my understanding (and re-confirming reading https://www.apache.org/legal/resolved.html#category-a ): - The restriction is on what can be in A PROJECT. tests are part of the project, and not distinguished from the compiled product (especially since

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Ekaterina Dimitrova
Jeff, isn’t this ok as long as it is used only in tests? If we are not sure we can open a Jira to legal? On Wed, 13 Sep 2023 at 12:23, Jeff Jirsa wrote: > Just to be clear - this repo? > https://github.com/haifengl/smile/blob/master/LICENSE > > That shows GPL + Commercial? > > > > On Wed, Sep 13

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Jeff Jirsa
Just to be clear - this repo? https://github.com/haifengl/smile/blob/master/LICENSE That shows GPL + Commercial? On Wed, Sep 13, 2023 at 9:10 AM Brandon Williams wrote: > I don't see any problem with this, +1. > > Kind Regards, > Brandon > > > On Wed, Sep 13, 2023 at 11:09 AM Mike Adamson >

Re: [DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Brandon Williams
I don't see any problem with this, +1. Kind Regards, Brandon On Wed, Sep 13, 2023 at 11:09 AM Mike Adamson wrote: > CEP-30: [Approximate Nearest Neighbor(ANN) Vector Search via > Storage-Attached Indexes] uses the smile-nlp library > (com.github.haifengl.smile-nlp) in its testing to allow the

[DISCUSS] Addition of smile-nlp test dependency for CEP-30

2023-09-13 Thread Mike Adamson
CEP-30: [Approximate Nearest Neighbor(ANN) Vector Search via Storage-Attached Indexes] uses the smile-nlp library (com.github.haifengl.smile-nlp) in its testing to allow the creation of word2vec embeddings for valid input into the HNSW graph index. The reason for this library is that we found that