Re: [DISCUSS] CEP-36: A Configurable ChannelProxy to alias external storage locations

2025-03-04 Thread Cheng Wang via dev
I agree with all the points mentioned by Soctt. We are actually very interested to explore the tiered storage for the same reasons above. Our first experiment with S3 single zone express was, unfortunately, awfully slow compared to ephemeral and EBS. On Tue, Mar 4, 2025 at 9:22 PM C. Scott Andreas

Re: Patrick McFadin joins the PMC

2025-01-22 Thread Cheng Wang via dev
Congratulations Patrick!! Well deserved! On Wed, Jan 22, 2025 at 9:36 AM Francisco Guerrero wrote: > Congrats, Patrick! It is well deserved. > > On 2025/01/22 16:05:09 Jordan West wrote: > > The PMC's members are pleased to announce that Patrick McFadin has > accepted > > an invitation to become

Re: Checkstyle as style contract for Cassandra

2025-01-17 Thread Cheng Wang via dev
And in an ideal world, we should never worry about the code style. Pointing out code style issues in PRs is a waste of time for both contributors and reviewers, imo. On Fri, Jan 17, 2025 at 9:52 AM Cheng Wang wrote: > Just share my personal experience as a new contributor to Cassandra. > It's ab

Re: Checkstyle as style contract for Cassandra

2025-01-17 Thread Cheng Wang via dev
Just share my personal experience as a new contributor to Cassandra. It's about the new-line braces. My muscle memory is the same line braces, so I need to set the Inteliij code style to have the Brace Placement option to Next Line, and do a Reformat Code for the files I changed. Also, I need to ch

Re: [Committer/reviewer needed] Request for Review of Cassandra PRs

2025-01-16 Thread Cheng Wang via dev
I can review the CASSANDRA-19248 first since it looks straight forward. For CASSANDRA−11303 and CASSANDRA− 20097 I will try but can't promise anything yet. How to add myself as a reviewer?

Re: Checkstyle as style contract for Cassandra

2025-01-16 Thread Cheng Wang via dev
I am personally in favor of more automatic code linting and enforcement than worrying about the code style. On Thu, Jan 16, 2025 at 1:56 PM Josh McKenzie wrote: > I merely remember Josh saying > > I say a lot of things. :D And I reserve the right to change my mind in the > face of better thought

Re: [DISCUSS] CASSANDRA-13704 Safer handling of out of range tokens

2024-09-12 Thread Cheng Wang via dev
> If we don’t reject by default, but log by default, my fear is that we’ll simply be alerting the operator to something that has already gone very wrong that they may not be in any position to ever address. Yes, logging and alerting is not enough here. We have seen the same issue before that we hav

Re: [DISCUSS] CASSANDRA-13704 Safer handling of out of range tokens

2024-09-12 Thread Cheng Wang via dev
I am +1 with enabling rejection by default. We had encountered similar situations before that we lost data in silence, which made us create a patch to trade availability with data loss. While I agree that it might be a surprise to operators, I think it's worth having good communication in the NEWS.

Re: Welcome Jordan West and Stefan Miklosovic as Cassandra PMC members!

2024-08-30 Thread Cheng Wang via dev
Congrats, Jordan and Stefan!! Well deserved!! Cheng On Fri, Aug 30, 2024 at 1:20 PM Jon Haddad wrote: > The PMC's members are pleased to announce that Jordan West and Stefan > Miklosovic have accepted invitations to become PMC members. > > Thanks a lot, Jordan and Stefan, for everything you hav

Re: [DISCUSS] Gossip Protocol Change

2024-05-16 Thread Cheng Wang via dev
Hi Cameron, Just want to make sure I understood correctly. So your observation was at the end of the shadow round, some nodes have empty endpointStateMap? But I read the code at GossipDigestSynVerbHandler::createShadowReply it seems that the receiving node will reply with a full stateMap? return

Re: Schema Disagreement Issue for Cassandra 4.1

2024-04-02 Thread Cheng Wang via dev
a.apache.org> napisał: >> >>> It sounds worthy of a Jira ticket. >>> >>> On 01/04/2024 06:23, Cheng Wang via dev wrote: >>> > Hello, >>> > >>> > I have recently encountered a problem concerning schema disagreement &g

Re: Schema Disagreement Issue for Cassandra 4.1

2024-04-02 Thread Cheng Wang via dev
apisał: > >> It sounds worthy of a Jira ticket. >> >> On 01/04/2024 06:23, Cheng Wang via dev wrote: >> > Hello, >> > >> > I have recently encountered a problem concerning schema disagreement >> > in Cassandra 4.1. It appears that the schem

Re: Schema Disagreement Issue for Cassandra 4.1

2024-04-01 Thread Cheng Wang via dev
: > It sounds worthy of a Jira ticket. > > On 01/04/2024 06:23, Cheng Wang via dev wrote: > > Hello, > > > > I have recently encountered a problem concerning schema disagreement > > in Cassandra 4.1. It appears that the schema versions do not reconcile > >

Schema Disagreement Issue for Cassandra 4.1

2024-03-31 Thread Cheng Wang via dev
Hello, I have recently encountered a problem concerning schema disagreement in Cassandra 4.1. It appears that the schema versions do not reconcile as expected. The issue can be reproduced by following these steps: - Disable the gossip in Node A. - Make a schema change in Node B, such as creating

Re: Welcome Patrick McFadin as Cassandra Committer

2023-02-02 Thread Cheng Wang via dev
Congrats, Patrick!! Cheng On Thu, Feb 2, 2023 at 10:24 AM Jordan West wrote: > Congratulations Patrick! Well deserved. > > Jordan > > On Thu, Feb 2, 2023 at 10:18 Brandon Williams wrote: > >> Congratulations, Patrick! >> >> Kind Regards, >> Brandon >> >> On Thu, Feb 2, 2023 at 11:58 AM Benjami

Re: dtests to reproduce the schema disagreement

2022-08-12 Thread Cheng Wang via dev
> On Tue, Aug 9, 2022 at 11:57 AM Cheng Wang via dev < > dev@cassandra.apache.org> wrote: > >> Thank you, Aleksey, >> Yes, I have tried this approach, the problem is there is a timing window >> that node 1 runs the CREATE TABLE while node 2 is down, and then we brin

Re: dtests to reproduce the schema disagreement

2022-08-09 Thread Cheng Wang via dev
> > On 9 Aug 2022, at 07:48, Konstantin Osipov via dev < > dev@cassandra.apache.org> wrote: > > > > * Cheng Wang via dev [22/08/09 09:43]: > > > >> I am working on improving the schema disagreement issue. I need some > dtests > >> which can

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
>> >> >> On Mon, Aug 8, 2022 at 3:54 PM Jeff Jirsa wrote: >> >>> Which (of the many) schema disagreement issue(s)? >>> >>> >>> >>> On Mon, Aug 8, 2022 at 3:29 PM Cheng Wang via dev < >>> dev@cassandra.apache.org>

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
Jirsa wrote: > Which (of the many) schema disagreement issue(s)? > > > > On Mon, Aug 8, 2022 at 3:29 PM Cheng Wang via dev < > dev@cassandra.apache.org> wrote: > >> Thank you for the reply, Brandon! It is helpful! >> >> I was thinking of creating a clus

Re: dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
? Thanks, Cheng On Mon, Aug 8, 2022 at 3:19 PM Brandon Williams wrote: > If you simply do a lot of schema changes quickly without waiting for > agreement, that should get you there. > > Kind Regards, > Brandon > > On Mon, Aug 8, 2022 at 5:08 PM Cheng Wang via dev > wrote:

dtests to reproduce the schema disagreement

2022-08-08 Thread Cheng Wang via dev
Hello, I am working on improving the schema disagreement issue. I need some dtests which can reproduce the schema disagreement. Anyone know if there are any existing tests for that? Or something similar? Thanks Cheng