Re: CASSANDRA-20490 Question about broken forced ephemeral snapshots during repair

2025-05-13 Thread Jaydeep Chovatia
>So if we moved to determanisticId for both branches of if / else and remove force, we should be good? RepairJobDesc#deterministicId is basically unique? The challenge with using RepairJobDesc#deterministicId in the SNAPSHOT_MSG is that it will create N snapshots for N token-splits for a table. How

Re: Test Strategy for Cassandra

2025-05-13 Thread manish khandelwal
Thanks Josh for your insights. That distinction between unit tests and dtests—especially in relation to intra-node vs. multi-node behavior—really helps clarify things. I’ll take another look at the patch and work on writing appropriate test cases accordingly, potentially shifting towards an in-jvm

Re: Facets | Cassandra v5.0

2025-05-13 Thread Caleb Rackliffe
Facets as supported by ES, Solr, etc. (i.e. count aggregates on groups w/ global queries) are not on the roadmap (if we want to call it that) for SAI. One thing we haven't explored much yet is what utility we might get out of combining SAI (for filtering) w/ Cassandra's existing partition-restrict

Re: [DISCUSS] CEP-48: First-Class Materialized View Support

2025-05-13 Thread Runtian Liu
> Looking at the details of the CEP it seems to describe Paxos as PaxosV1, but PaxosV2 works slightly differently (it can read during the prepare phase). I assume that supporting Paxos means supporting both V1 and V2 for materialized views? We are going to support Paxos V2. The CEP is not clear on

Re: Welcome Abe Ratnofsky as Cassandra committer!

2025-05-13 Thread Bernardo Botella
That’s awesome! Congrats Abe! > On May 13, 2025, at 7:54 AM, Patrick McFadin wrote: > > Congratulations Abe! > > On Tue, May 13, 2025 at 1:52 AM Berenguer Blasi > wrote: >> Nice one congrats! >> >> On 13/5/25 3:08, Paulo Motta wrote: >>> Congrats Abe, well de

Re: CASSANDRA-20490 Question about broken forced ephemeral snapshots during repair

2025-05-13 Thread Štefan Miklošovič
That true / false for "force" argument seems to be purely derived from whether it is global repair (force set to false) or not (set to true). https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/repair/RepairMessageVerbHandler.java#L185-L192 On Tue, May 13, 2025 at 5:25 PM

Re: CASSANDRA-20490 Question about broken forced ephemeral snapshots during repair

2025-05-13 Thread David Capwell
That method can be backported even if it’s just for this single case. For the vtable I needed something more friendly so made this for that. It’s also used for dedup logic in repair retry works.  I didn’t look closely, what sets force to be true or false? I assumed this was the force flag in repair

Re: Welcome Abe Ratnofsky as Cassandra committer!

2025-05-13 Thread Patrick McFadin
Congratulations Abe! On Tue, May 13, 2025 at 1:52 AM Berenguer Blasi wrote: > Nice one congrats! > On 13/5/25 3:08, Paulo Motta wrote: > > Congrats Abe, well deserved! > > On Mon, May 12, 2025 at 8:57 PM Jordan West wrote: > >> Congratulations!! >> On Mon, May 12, 2025 at 14:41 Josh McKenzie w

Re: Test Strategy for Cassandra

2025-05-13 Thread Josh McKenzie
Given the title on 20291: "Batch queries timeout when private IP of a node fails in multi-dc Cassandra setup", this seems like a prime candidate for an in-jvm dtest. The way I think about it: if I need to exercise intra-node communication or functionality to confirm that something operates the w

Re: [DISCUSS] Replace airlift/airline library with Picocli

2025-05-13 Thread Dmitry Konstantinov
Hi Maxim, I will take a look too. Regards, Dmitry On Tue, 13 May 2025 at 08:59, Štefan Miklošovič wrote: > Hi Maxim, > > I took yet another look after my initial review some time ago and I still > do not see any issues with it. > > I appreciate that by default it behaves exactly the same way as

Re: Welcome Abe Ratnofsky as Cassandra committer!

2025-05-13 Thread Berenguer Blasi
Nice one congrats! On 13/5/25 3:08, Paulo Motta wrote: Congrats Abe, well deserved! On Mon, May 12, 2025 at 8:57 PM Jordan West wrote: Congratulations!! On Mon, May 12, 2025 at 14:41 Josh McKenzie wrote: Congratulations Abe! On Mon, May 12, 2025, at 4:16 PM, Arj

Re: [DISCUSS] Replace airlift/airline library with Picocli

2025-05-13 Thread Štefan Miklošovič
Hi Maxim, I took yet another look after my initial review some time ago and I still do not see any issues with it. I appreciate that by default it behaves exactly the same way as before and one has to just flip a switch (env property / system property) to start to use another layout. Arguments /

Re: Welcome Abe Ratnofsky as Cassandra committer!

2025-05-13 Thread Mick Semb Wever
Congrats ! On Tue, 13 May 2025 at 08:59, Štefan Miklošovič wrote: > Congratulations! > > On Mon, May 12, 2025 at 6:48 PM Alex Petrov wrote: > >> Hello folks of the dev list, >> >> The Apache Cassandra PMC is very glad to announce that Abe Ratnofsky has >> accepted our invitation to become a com

Re: [VOTE] CEP-46: Finish Transient Replication/Witnesses

2025-05-13 Thread Mick Semb Wever
. The vote will be open for 72 hours. A vote passes if there are at least 3 > binding +1s and no binding vetoes. > +1

Test Strategy for Cassandra

2025-05-13 Thread manish khandelwal
Hi everyone I have a question regarding test strategy in Cassandra. Under what circumstances is a dtest preferred over a unit test? Specifically, what criteria should guide the decision to write a dtest instead of a unit test? I’ve prepared a patch for CASSANDRA-20291, but I’m encountering some c