Re: Constraint's "not null" alignment with transactions and their simplification

2025-04-15 Thread Patrick McFadin
I may be to blame for some of that energy. :D No, we don't have consensus on that direction, but I think we will eventually. CQL started out as a subset of SQL but has drifted because features get added async and there just hasn't been any formal standard or road map or lofty goal. We've been layi

Re: Constraint's "not null" alignment with transactions and their simplification

2025-04-15 Thread Josh McKenzie
> If we have a goal of eventually providing ANSI SQL support one day, we should > at least stick to the ANSI SQL standard where applicable for features in the > meantime. Do we collectively have that goal? Not disagreeing with it at all, genuinely curious. Broadly I agree that we should definit

Re: Project hygiene on old PRs

2025-04-15 Thread Štefan Miklošovič
On Mon, Apr 14, 2025 at 3:22 PM Josh McKenzie wrote: > Funny that people don't forget to create a PR when trying to make a change > but as soon as it is delivered the respective PR is "memory holed". > > We use the PR mechanisms for review but don't use the PR mechanism for > merge. Makes sense t

Re: Project hygiene on old PRs

2025-04-15 Thread Josh McKenzie
> I think that there might be legitimate cases when a PR is up just for > extended periods of time because it depends on other functionality or it is > just worked on for such a long time, If something has 0 discussion, movement, or code changes for 6 months I think it's probably safe to close i

Re: Merging compaction improvements to 5.0

2025-04-15 Thread Chris Lohfink
+1 On Sun, Apr 13, 2025 at 12:32 PM Jordan West wrote: > Hi Folks, > > A bit delayed but I have the backport for 20092 ready. The branch can be > found here: > https://github.com/apache/cassandra/compare/cassandra-5.0...jrwest:cassandra:jwest/20092-5.0-backport. > I've run tests and all looked g

Re: Constraint's "not null" alignment with transactions and their simplification

2025-04-15 Thread Benedict
If we have a goal of eventually providing ANSI SQL support one day, we should at least stick to the ANSI SQL standard where applicable for features in the meantime. AFAICT the reason everyone else does this the same is it is part of the standard. So, I am more than happy to stick to the CHECK quali

Re: Project hygiene on old PRs

2025-04-15 Thread Paulo Motta
> 3) having e.g. a GitHub trigger which would scan commit message when it is merged, extracting JIRA ticket number and then go to GitHub and close respective PRs. This is implementation detail, but I don't think that scanning the commit message on merge would be needed. When a PR is opened with a

Re: Project hygiene on old PRs

2025-04-15 Thread Paulo Motta
Just to clarify option 3), I'm not sure ASF INFRA currently provides the ability of auto-closing PRs associated with a JIRA, this would be a feature request that would obviously need to be triaged and prioritized at their pace. Assuming this is a feasible and reasonable request, then I'd suggest w

Re: Constraint's "not null" alignment with transactions and their simplification

2025-04-15 Thread Benedict
I am not certain if the ANSI SQL standard requires that any _expression_ be supported, but either way it is much better to implement a strict subset of a feature than to implement an overlapping feature we can never synchronise with the standard.Accord is also capable of imposing multi column expre