Re: Checkstyle as style contract for Cassandra

Hi Stefan, > So I think we do not need to do anything. It is all configured properly already. People just need to hit the formatter (ctrl + shift + l). > You also correctly pointed out that you can format automatically on saving so you don't even need to think about it. I reformat code very often

Re: [DISCUSS] Review Guide for the project

Having updated guides is great and probably we can also put links to them into the PR template, for convenience sake. Thus anyone who opens a PR will see them. On Sat, 18 Jan 2025 at 18:46, Jordan West wrote: > I generally support a guide we can point new contributors to as well. > > Jordan > >

Re: [DISCUSS] Bracing style on trunk

I'm leaning toward not changing the bracing style we already have unless there's a powerful reason (hard to imagine what it could be). So currently -1. I would rather focus on enabling lints we all agree on, and/or the consensus is easy to achieve. There are many such lints, and much work to be don

Re: [DISCUSS] Review Guide for the project

I generally support a guide we can point new contributors to as well. Jordan On Sat, Jan 18, 2025 at 10:20 Dinesh Joshi wrote: > As a growing community with new committers and contributors, I would > support establishing a review guide to ensure consistency and uniformity of > feedback. > > On

[VOTE] Release Apache Cassandra Java Driver 3.12.1

Greetings all! I’m proposing the Cassandra Java Driver 3.12.1 for release. sha1: 873e6f764a499bd9c5a42cafa53dc77184711eea git: https://github.com/apache/cassandra-java-driver/tree/3.12.1 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecassandra-1355 The Sourc

Re: [DISCUSS] Bracing style on trunk

I honestly did not want to debate stylistic topics on a beautiful Saturday afternoon. As a project we have other, more pressing, topics to discuss. However, I just wanted to chime in and say that we have 3 options – 1. Continue placing the brace on a new line. 2. Move to accepting both new line br

Re: [DISCUSS] Bracing style on trunk

That is how I see it and how I personally understood you, Blake! Thanks! Also, Jon, appreciate your point of view too. I would support it for a new project though, Cassandra codebase is too big, too old, and too active IMHO for such a lift. Also, from my experience being around for about 5 years a

Re: [DISCUSS] Bracing style on trunk

Just to be clear, I do think it would be good for the project to conform to a more standard java style. I just think that the contributor friction from this issue is pretty small, and the impact to work in progress would be pretty severe. If the goal is to reduce contributor friction, there's pr

Re: [DISCUSS] Bracing style on trunk

+ .9 for me. I think it would be a good thing for the project in the long run to conform to a more standard Java style, but I'm unable to provide any time to make it happen. I don't think it's reasonable to impose this burden on anyone if I'm not willing to take it on myself, so this is why I'm n

Re: Checkstyle as style contract for Cassandra

Let’s also keep in mind that this is a discussion about the pros and cons of automatic formatting. Everyone wants what’s best for the project, although they may have different views about how to get there. One person thinking we should use a tool does not make them lazy, nor does it affect the

Re: [DISCUSS] CEP-45: Mutation Tracking

That's an interesting idea. Basically allow for a window of uncertainty between the memtable and log and merge mutations within that window directly into the response. It sounds like something that could work. I'll have to think about how not embedding id info into the storage layer might inter

Re: [DISCUSS] Bracing style on trunk

I also do not see huge benefit in switching the style, honestly. And I see risks more than benefits. I also share Blake’s opinion that this would be more suitable for a new project. On Sat, 18 Jan 2025 at 15:27, Blake Eggleston wrote: > I lean pretty strongly towards -1 on this. If we were star

Re: [DISCUSS] Bracing style on trunk

I lean pretty strongly towards -1 on this. If we were starting a new project, then yeah it would make sense. As an older project though, I don’t see any clear benefits for switching the style at this point, and can foresee it causing a lot of pain. Even if we were to wait for accord before going

Re: [DISCUSS] CEP-45: Mutation Tracking

That’s great to hear, I had thought the goal for embedding this information in sstables was that the log could be truncated. If not, is the below snippet the main motivation?For the nodes returning data _and_ mutation ids, the data and mutation ids need to describe each other exactly. If the data r

Re: Checkstyle as style contract for Cassandra

Andy, I have checked if ant generate-idea-files sets up the formatter correctly and it seems it still does the job. When I removed .idea dir and opened e.g. cassandra-5.0 branch in IDEA, then the code style / formatter was not applied. But as soon as you execute "ant generate-idea-files" on a cle

Re: [DISCUSS] CEP-45: Mutation Tracking

No, mutations are kept intact. If a node is missing a multi-table mutation, it will receive the entire mutation on reconciliation. Regarding HLCs, I vaguely remember hearing about a paxos outage maybe 9-10 years ago that was related to a leap hour or leap second or something causing clocks to n

Re: [DISCUSS] Review Guide for the project

As a growing community with new committers and contributors, I would support establishing a review guide to ensure consistency and uniformity of feedback. On Sat, Jan 18, 2025 at 5:21 AM Josh McKenzie wrote: > See thread "Checkstyle as style contract for Cassandra >

Re: [DISCUSS] Bracing style on trunk

I agree with Benedict wholeheartedly. Yes, I am happy where the braces currently are and I don't understand that placing braces and the whole "problematic" is such a big topic for other people. 99% of problems with braces are caused by people not having their formatter in IDEA (or any IDE of thei

Re: [DISCUSS] Bracing style on trunk

This is a mad idea that I can’t believe anyone is seriously entertaining. -1.On 18 Jan 2025, at 13:17, Josh McKenzie wrote:Trying to break out discussions here to keep things moving - see thread "Checkstyle as style contract for Cassandra"One topic that came up on the thread was whether we were c

Re: Checkstyle as style contract for Cassandra

> You have a map in your brain of how to read the code base. You know where to > find these things. And they are _exactly there_, If you've memorized the specific placement of where things are within discrete files Stefan and you're able to keep up with all the other diffs and churn in our codeb

[DISCUSS] Review Guide for the project

See thread "Checkstyle as style contract for Cassandra ". One area where we haven't formalized much guidance is around our code review culture as a project. I've worked with guides based on google's "How to do a code review

[DISCUSS] Bracing style on trunk

Trying to break out discussions here to keep things moving - see thread "Checkstyle as style contract for Cassandra " One topic that came up on the thread was whether we were collectively happy with our current newline bracing st

Re: [DISCUSS] CEP-45: Mutation Tracking

Does this approach potentially fail to guarantee multi table atomicity? If we’re reconciling mutation ids separately per table, an atomic batch write might get reconciled for one table but not another? I know that atomic batch updates on a single partition key to multiple tables is an important pro