Re: [DISCUSS] Replace Sigar with OSHI (CASSANDRA-16565)

2023-12-17 Thread Claude Warren, Jr via dev
Can I get an another review/approval for the pull request? https://github.com/apache/cassandra/pull/2842/files On Fri, Dec 15, 2023 at 4:04 AM guo Maxwell wrote: > +1 too > > Mick Semb Wever 于2023年12月15日周五 10:01写道: > >> >> >> >>> >>> Are there objections to making this switch and adding a new d

Re: Custom FSError and CommitLog Error Handling

2023-12-17 Thread Dinesh Joshi
> On Dec 11, 2023, at 11:27 AM, Raymond Huffman > wrote: > > On our fork of Cassandra, we've implemented some custom behavior for handling > CommitLog and SSTable Corruption errors. Specifically, if a node detects one > of those errors, we want the node to stop itself, and if the node is > re

Re: Custom FSError and CommitLog Error Handling

2023-12-17 Thread Maxim Muzafarov
Hello Raymond, Do you have draft changes to look at? I'd suggest a more general approach, as some interfaces seem to overlap each other. There is the FSErrorHandler, and the JVMStabilityInspector both of which are currently not configurable via user configuration. I think it would be possible to